19870 - Split bill description and currency is shown wrong by BhuvaneshPatil · Pull Request #20115 · Expensify/App

BhuvaneshPatil · 2023-06-03T07:41:18Z

Details

Split Description page doesn't show the correct description/comment and currency

Fixed Issues

$ #19870
PROPOSAL: #19870 (comment)

Tests

Create a split bill
Add All necessary info and description.
Create split bill.
Create another split bill.
Open the previously created bill.
Description and currency is as expected.
Create a split bill with empty description and also change the currency.
Create a new split bill with some description.
Open the first created split bill, description should be empty and currency should be the same that when created.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Web.Safari.mp4

Mobile Web - Chrome

Android.Chrome.mp4

Mobile Web - Safari

ios.safari.compressed.mp4

Desktop

Desktop.-.MAC.mp4

iOS

IOS.APP.COMPRESSED.mp4

Android

Android.Compressed.mp4

- Passes two props currency code and split bill description and if they are undefined use the default from IOU(onyx)

github-actions · 2023-06-03T07:41:34Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2023-06-03T07:41:50Z

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

BhuvaneshPatil · 2023-06-03T08:03:21Z

I have read the CLA Document and I hereby sign the CLA

Julesssss · 2023-06-05T08:22:46Z

Hi, I'll review it today. Please review the GH_LINK text entirely next time, as our automation links the PR to the issue and will auto-assign the original proposal approver.

Julesssss

This works well when you add a description, but fails for splits where you do not add a description. Once fixed, can you please also add a new test case that covers NOT adding a description please:

BhuvaneshPatil · 2023-06-05T11:22:00Z

When we use MoneyRequestConfirmationList component while creating the split bill, this.props.iouComment will be undefined,

<MenuItemWithTopDescription
                    shouldShowRightIcon={!this.props.isReadOnly}
                    title={_.isUndefined(this.props.iouComment) ? this.props.iou.comment : this.props.iouComment}
                    description={this.props.translate('common.description')}
                    onPress={() => Navigation.navigate(ROUTES.MONEY_REQUEST_DESCRIPTION)}
                    style={[styles.moneyRequestMenuItem, styles.mb2]}
                    disabled={this.state.didConfirm || this.props.isReadOnly}
                />

we can use isUndefined() for checking that, shall I make new variable that will be used in title or keep the above implementation?

The above code solves the issue

Untitled.video.-.Made.with.Clipchamp.2.mp4

Julesssss · 2023-06-05T11:35:49Z

Can we just check if a comment exists and is not empty?

BhuvaneshPatil · 2023-06-05T11:39:03Z

Sure,

const titleForDescription = this.props.iouComment || this.props.iouComment === '' ? this.props.iouComment : this.props.iou.comment;

We can use this variable as the title prop for description field.

bernhardoj · 2023-06-06T03:53:43Z

Can we also pass this.props.iou.comment and this.props.iou.currency to a props from MoneyRequestConfirmPage instead of doing this.props.iouComment || this.props.iou.comment? Thanks!

BhuvaneshPatil · 2023-06-06T04:40:45Z

@bernhardoj thank you for your suggestion, yes this can be done. Let's wait for @Julesssss comment on the mentioned change.

Julesssss · 2023-06-06T08:46:38Z

The suggestion above sound good 👍

BhuvaneshPatil · 2023-06-06T09:10:40Z

Cool, the changes will be like these -

sending props from MoneyRequestConfirmationPage to MoneyRequestConfirmationList
Adding iou (from onyx) prop to MoneyRequestConfirmationPage

Julesssss · 2023-06-06T10:18:38Z

Hey @eVoloshchak 👋

Manually assigning you because this PR wasn't automatically linked to the issue.

BhuvaneshPatil · 2023-06-06T12:40:20Z

Bump @eVoloshchak for review.

eVoloshchak · 2023-06-06T17:18:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-06.at.20.30.34.mov

Mobile Web - Chrome

screen-20230606-203554.mp4

Mobile Web - Safari

Screen.Recording.2023-06-06.at.20.32.05.mov

Desktop

Screen.Recording.2023-06-06.at.20.29.34.mov

iOS

Screen.Recording.2023-06-06.at.20.32.48.mov

Android

screen-20230606-203512.mp4

eVoloshchak · 2023-06-06T17:25:45Z

@BhuvaneshPatil, there's still an issue with how a link to proposal is displayed, it's gotta look like this:
PROPOSAL: #19870 (comment)

BhuvaneshPatil · 2023-06-06T17:29:26Z

@BhuvaneshPatil, there's still an issue with how a link to proposal is displayed, it's gotta look like this: PROPOSAL: #19870 (comment)

Done. Thanks for mentioning

eVoloshchak

Looks good and tests well

BhuvaneshPatil · 2023-06-06T17:55:50Z

Hi @Julesssss , can you please close the review #20115 (review) as the changes are done.
Thank you.

Out of date

Julesssss

Testing well now

OSBotify · 2023-06-07T08:42:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-08T17:03:24Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.26-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T00:24:06Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

19870 - Split bill description and currency is shown wrong

277bc61

- Passes two props currency code and split bill description and if they are undefined use the default from IOU(onyx)

BhuvaneshPatil requested a review from a team as a code owner June 3, 2023 07:41

melvin-bot Bot requested review from madmax330 and removed request for a team June 3, 2023 07:41

This comment was marked as off-topic.

Sign in to view

Julesssss assigned BhuvaneshPatil Jun 5, 2023

Julesssss self-requested a review June 5, 2023 08:20

Julesssss previously requested changes Jun 5, 2023

View reviewed changes

handling case for blank description

8396c22

BhuvaneshPatil requested a review from Julesssss June 5, 2023 11:48

passing values as prop from MoneyRequestConfirmPage

7401787

Julesssss requested a review from eVoloshchak June 6, 2023 10:18

eVoloshchak approved these changes Jun 6, 2023

View reviewed changes

madmax330 removed their request for review June 7, 2023 06:35

Julesssss approved these changes Jun 7, 2023

View reviewed changes

Julesssss merged commit 9ab54c2 into Expensify:main Jun 7, 2023

OSBotify mentioned this pull request Jun 8, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

kbecciv mentioned this pull request Jun 9, 2023

Split Bill - First created bill description is not empty #20505

Closed

6 tasks

melvin-bot Bot mentioned this pull request Jun 12, 2023

[HOLD for payment 2023-06-19] [$1000] Split Bill preview not showing correct description/currency #19870

Closed

6 tasks

Conversation

BhuvaneshPatil commented Jun 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jun 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Jun 3, 2023

Uh oh!

BhuvaneshPatil commented Jun 3, 2023

Uh oh!

This comment was marked as off-topic.

Julesssss commented Jun 5, 2023

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

BhuvaneshPatil commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julesssss commented Jun 5, 2023

Uh oh!

BhuvaneshPatil commented Jun 5, 2023

Uh oh!

bernhardoj commented Jun 6, 2023

Uh oh!

BhuvaneshPatil commented Jun 6, 2023

Uh oh!

Julesssss commented Jun 6, 2023

Uh oh!

BhuvaneshPatil commented Jun 6, 2023

Uh oh!

Julesssss commented Jun 6, 2023

Uh oh!

BhuvaneshPatil commented Jun 6, 2023

Uh oh!

eVoloshchak commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Jun 6, 2023

Uh oh!

BhuvaneshPatil commented Jun 6, 2023

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

BhuvaneshPatil commented Jun 6, 2023

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 7, 2023

Uh oh!

OSBotify commented Jun 8, 2023

Uh oh!

OSBotify commented Jun 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BhuvaneshPatil commented Jun 3, 2023 •

edited

Loading

github-actions Bot commented Jun 3, 2023 •

edited

Loading

BhuvaneshPatil commented Jun 5, 2023 •

edited

Loading

eVoloshchak commented Jun 6, 2023 •

edited

Loading