[HOLD for payment 2023-06-19] [$1000] Split Bill preview not showing correct description/currency

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a Split Bill request using currency A and no description
2. Start a new money request flow (send/request/split)
3. Choose currency B and set description to any text
4. Don't complete it and close the page
5. Press the Split Bill preview to see the detail

Expected Result:

The currency and description should show the currency and description used when creating the request

Actual Result:

The currency and description dynamically changes every time we set a new value from money request flow

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.20-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-29.at.22.03.49.mov

Recording.818.mp4

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685369261418519

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012fa29a23a09e4f51
• Upwork Job ID: 1663824064534704128
• Last Price Increase: 2023-05-31

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[therealsujitk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The description in the split bill details page gets reset to the latest value saved in Onyx. Note that the same issue also occurs for the currency code.

What is the root cause of that problem?

The reason for this is because we are not getting these details from the report but rather from Onyx as shown in the code below.

App/src/components/MoneyRequestConfirmationList.js

Line 318 in 2157057

const formattedAmount = CurrencyUtils.convertToDisplayString(this.props.iouAmount, this.props.iou.selectedCurrencyCode);

App/src/components/MoneyRequestConfirmationList.js

Line 348 in 2157057

title={this.props.iou.comment}

What changes do you think we should make in order to solve the problem?

To fix this these values have to passed down as props (undefined by default) from the SplitBillDetailsPage. If they are undefined, values from Onyx will be used.

...
const splitAmount = parseInt(lodashGet(reportAction, 'originalMessage.amount', 0), 10);
const splitCurrencyCode = lodashGet(reportAction, 'originalMessage.currency');
const splitComment = lodashGet(reportAction, 'originalMessage.comment');

<MoneyRequestConfirmationList
    ...
    iouAmount={splitAmount}
    iouCurrencyCode={splitCurrencyCode}
    iouComment={splitComment}
    iouType={CONST.IOU.MONEY_REQUEST_TYPE.SPLIT}
    isReadOnly
    shouldShowFooter={false}
/>

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012fa29a23a09e4f51

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.