fix crash on DetailsPage by 0xmiroslav · Pull Request #10820 · Expensify/App

0xmiroslav · 2022-09-05T16:28:13Z

Details

refactor DetailsPage component from functional to class
redirect to root page if login query not exist in /details deep link
use lodash to safely get values from route.params without crash

Fixed Issues

$ #9545

Tests

Launch the app and login
For web, mWeb:
Go to /details (i.e. http://localhost:8080/details in dev).
Verify that app does not crash and redirects to the root page
For android, iOS, desktop:
Send message - 'https://new.expensify.com/details' in any chat room and click on it
Verify that app does not crash and nothing happens

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Launch the app and login
For web, mWeb:
Go to /details (i.e. http://localhost:8080/details in dev).
Verify that app does not crash and redirects to the root page
For android, iOS, desktop:
Send message - 'https://new.expensify.com/details' in any chat room and click on it
Verify that app does not crash and nothing happens

Verify that no errors appear in the JS console

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

…to issue-9545

Santhosh-Sellavel · 2022-09-07T19:55:08Z

+}

 DetailsPage.propTypes = propTypes;
 DetailsPage.displayName = 'DetailsPage';


Remove this as it's no longer needed since this is a class-based component!

Santhosh-Sellavel

Suggested a comment

Co-authored-by: Santhoshkumar Sellavel <85645967+Santhosh-Sellavel@users.noreply.github.com>

Santhosh-Sellavel · 2022-09-08T20:10:25Z

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀
C+ Reviewed

Santhosh-Sellavel

Looks good, tests well!

@iwiznia all you!

melvin-bot · 2022-09-12T11:33:43Z

@iwiznia looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2022-09-12T11:37:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

iwiznia · 2022-09-12T12:09:56Z

Are you drunk Melvin?! This had passing tests

OSBotify · 2022-09-13T15:18:39Z

🚀 Deployed to staging by @iwiznia in version: 1.2.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Beamanator · 2023-05-17T11:33:20Z

-    const GMTTime = `${timezone.toString().split(/[+-]/)[0].slice(-3)} ${timezone.zoneAbbr()}`;
-    const currentTime = Number.isNaN(Number(timezone.zoneAbbr())) ? timezone.zoneAbbr() : GMTTime;
-    const shouldShowLocalTime = !ReportUtils.hasExpensifyEmails([details.login]);
+    render() {


I'm a bit confused why this was turned into a class based component, was that necessary?

This is very old PR and at that time, we're not allowed to use functional component with hooks.
#9545 (comment)
Now this is deprecated.

Beamanator · 2023-05-17T11:40:29Z

-    let pronouns = details.pronouns;
+        // If we have a reportID param this means that we
+        // arrived here via the ParticipantsPage and should be allowed to navigate back to it
+        const shouldShowBackButton = Boolean(this.props.route.params.reportID);


Also this is quite interesting... In ROUTES.js we only have getDetailsRoute to construct this page's route, and we can only pass a Login here at the moment, no reportID - so how is reportID still available here??

At the moment I don't see the back button being shown on the details page anywhere... I thinkkkk the reportID you're looking for is in the ReportParticipantsPage, not DetailsPage

This was old old logic. Not introduced by this PR.
https://github.com/Expensify/App/pull/10820/files#diff-4426aa1d3788c60f7845305d45877244f89c00bc81e2322e1f1eeff653a13becR78-R79

fix crash on DetailsPage

f1769bc

0xmiroslav requested a review from a team as a code owner September 5, 2022 16:28

melvin-bot Bot requested review from Santhosh-Sellavel and iwiznia and removed request for a team September 5, 2022 16:28

Merge branch 'main' of https://github.com/vladnobenladen/Expensify in…

e766869

…to issue-9545

Santhosh-Sellavel suggested changes Sep 7, 2022

View reviewed changes

vladnobenladen added 2 commits September 7, 2022 14:31

remove displayName property as of class component

989fc86

add comment on dismissModal

dfb7d5c

Santhosh-Sellavel reviewed Sep 8, 2022

View reviewed changes

Comment thread src/pages/DetailsPage.js Outdated

Santhosh-Sellavel suggested changes Sep 8, 2022

View reviewed changes

update comment

a10cd6a

Co-authored-by: Santhoshkumar Sellavel <85645967+Santhosh-Sellavel@users.noreply.github.com>

Santhosh-Sellavel approved these changes Sep 8, 2022

View reviewed changes

iwiznia approved these changes Sep 12, 2022

View reviewed changes

iwiznia merged commit 2343eeb into Expensify:main Sep 12, 2022

melvin-bot Bot added the Emergency label Sep 12, 2022

iwiznia removed the Emergency label Sep 12, 2022

OSBotify mentioned this pull request Sep 13, 2022

Deploy Checklist: New Expensify 2022-09-13 #10958

Closed

30 tasks

kbecciv mentioned this pull request Sep 13, 2022

[$250] Web - Endless loading appears clicking on https://staging. new.expensify.com/details in concierge #10966

Closed

melvin-bot Bot mentioned this pull request Sep 16, 2022

[HOLD for payment 2022-09-23] [$500] 💥 Crash 💥 DetailsPage #9545

Closed

marcochavezf mentioned this pull request Feb 28, 2023

[HOLD for payment 2023-04-05] [HOLD][$2000] https://staging.new.expensify.com/details crashed app #15486

Closed

6 tasks

Beamanator reviewed May 17, 2023

View reviewed changes

Navigation Menu

fix crash on DetailsPage - #10820

fix crash on DetailsPage#10820
iwiznia merged 5 commits into
Expensify:mainfrom
0xmiroslav:issue-9545

0xmiroslav commented Sep 5, 2022

Uh oh!

Santhosh-Sellavel Sep 7, 2022

Uh oh!

Uh oh!

Uh oh!

Santhosh-Sellavel left a comment

Uh oh!

Santhosh-Sellavel commented Sep 8, 2022

PR Reviewer Checklist

Uh oh!

Santhosh-Sellavel left a comment

Uh oh!

melvin-bot Bot commented Sep 12, 2022

Uh oh!

OSBotify commented Sep 12, 2022

Uh oh!

iwiznia commented Sep 12, 2022

Uh oh!

OSBotify commented Sep 13, 2022

Uh oh!

Beamanator May 17, 2023

Uh oh!

0xmiroslav May 17, 2023

Uh oh!

Beamanator May 17, 2023

Uh oh!

0xmiroslav May 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

0xmiroslav commented Sep 5, 2022

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

Santhosh-Sellavel Sep 7, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Sep 8, 2022

PR Reviewer Checklist

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Sep 12, 2022

Uh oh!

OSBotify commented Sep 12, 2022

Uh oh!

iwiznia commented Sep 12, 2022

Uh oh!

OSBotify commented Sep 13, 2022

Uh oh!

Beamanator May 17, 2023

Choose a reason for hiding this comment

Uh oh!

0xmiroslav May 17, 2023

Choose a reason for hiding this comment

Uh oh!

Beamanator May 17, 2023

Choose a reason for hiding this comment

Uh oh!

0xmiroslav May 17, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants