Deploy Checklist: New Expensify 2022-09-13

[OSBotify]

Release Version: 1.2.0-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix the native link renderer #10503
• Add offline behavior and error handling for AcceptWalletTerms #10578
• Optimize report ordering in the LHN #10784
• fix crash on DetailsPage #10820
• Center loading indicator #10823
• Refactor withFullPolicy #10873
• [No QA] Update Onyx Fields When Creating Workspace #10874
• fix: web banner cut off #10879
• [No QA] Revert "Toggle staging and production server api" #10920
• Toggle staging and production server api #10935
• Return early if policy doesn't have customUnits to prevent crash #10937
• adding screen listener to participants page #10938
• CP a useless commit to fix failed release #10942
• [No QA][Refactor] Add helper method to build Onyx data for VBBA setup #10954
• Remove usages of onyxRates #10974
• Revert "Refactor withFullPolicy" #10979
• Add missing code from main into staging branch #10995
• Dummy change to allow new staging CP #11000
• Omit default Avatar param to prevent crash on app start #11006
• Use existing personal details' avatar when it exists #11022
• Add missing alternateText option in option #11023
• Only use personal detail login as alternateText if we're not making the option for a report #11029

Deploy Blockers:

• Custom units are broken #10978
• Android - Chat - App crashed after sign in with specific account #11003
• [$2000] Web/mweb - Chat - LHN does not display after signing out/signing in #11011
• All workspace member are showing with green avatar - Reported by @thesahindia #11019
• All workspace members are showing with green avatar #11020
• No emails are shown on the member Invite page - Reported by @parasharrajat #11021

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[mountiny]

Checking #10937 off as that has already been QA'ed in the previous version

[Julesssss]

@Expensify/applauseleads the automated message failed to post, but all platform builds should now be available for testing.

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.0-0 🚀

[mvtglobally]

@francoisl @Julesssss Regression is almost completed

PR #10820 is failing due to #10966
PR #10935 is failing due to #10963 & #10970

[jasperhuangg]

Just noticed that custom units are currently broken on staging but not on prod.. investigating

Screen.Recording.2022-09-13.at.2.01.02.PM.mov

cc @Julesssss @mvtglobally @francoisl

[jasperhuangg]

Are there any other deploy checklists that haven't hit prod yet?

[jasperhuangg]

Looks like reverting #10873 locally fixes things. I say we revert it on staging too.

cc @arosiclair

[mvtglobally]

There were couple issues logged around this area. Not sure if this related #10877

[jasperhuangg]

There were couple issues logged around this area. Not sure if this related #10877

Ah that's unrelated, that was fixed in a previous PR. I can confirm that the new issues are caused by #10873.

cc @mvtglobally

[francoisl]

PR #10820 is failing due to #10966

That one was already crashing in production, so no need to block the deploy on it.

PR #10935 is failing due to #10963 & #10970

Look into those

Ah that's unrelated, that was fixed in a previous PR. I can confirm that the new issues are caused by #10873.

@jasperhuangg thanks for looking. I'm trying to reproduce locally and see if there's a simple fix we could CP. Otherwise, let's revert that PR.

[mvtglobally]

@francoisl @jasperhuangg do you need a new issue created for this blocker?