Skip to content

[No QA] Unify "We couldn't" translation to Spanish - #10655

Merged
iwiznia merged 3 commits into
mainfrom
alberto-spanish
Aug 30, 2022
Merged

iwiznia merged 3 commits into
mainfrom
alberto-spanish

Conversation

@Gonals

@Gonals Gonals commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/225342

Tests / QA

None

@Gonals
Gonals requested a review from a team as a code owner August 29, 2022 15:07
@Gonals Gonals self-assigned this Aug 29, 2022
@melvin-bot
melvin-bot Bot requested review from Julesssss and removed request for a team August 29, 2022 15:07
@Gonals
Gonals requested review from iwiznia and removed request for Julesssss August 29, 2022 15:07
@Gonals

Gonals commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

Replacing reviewer, since this is just a translation 😁

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me based on Google translate.

@iwiznia
iwiznia merged commit 7f4d36a into main Aug 30, 2022
@iwiznia
iwiznia deleted the alberto-spanish branch August 30, 2022 10:36
@melvin-bot melvin-bot Bot added the Emergency label Aug 30, 2022
@melvin-bot

melvin-bot Bot commented Aug 30, 2022

Copy link
Copy Markdown

@iwiznia looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@iwiznia iwiznia removed the Emergency label Aug 30, 2022
@iwiznia

iwiznia commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

Either I fucked up and did not notice or the check failed. Anyway, the tests passed.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @iwiznia in version: 1.1.94-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants