[cp staging] Fix Select all label stacking below the checkbox in Search selection mode by war-in · Pull Request #105599 · Expensify/App

war-in · 2026-11-02T09:01:41Z

Explanation of Change

#105128 wrapped SearchSelectAllMenu in a View in SelectionTopBar. That menu returns a Fragment with the checkbox and the "Select all" label as siblings, so the plain View stacked them in a column. The label only renders on narrow layouts (no column header), which is why only narrow broke. The wrapper is now a centred row, which restores the old layout.

Fixed Issues

$ #105559
PROPOSAL: N/A

Tests

On a narrow layout (iOS/Android app or mWeb), go to Spend > Expenses with at least one expense
Long-press an expense and tap Select (on mWeb, tap and hold)
Verify that the "Select all" label sits to the right of the header checkbox, vertically centred with it, not below it
On wide web, go to Spend > Expenses
Verify that the header checkbox lines up with the row checkboxes and the column headings are unchanged

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Before:

105559-before-ios.mp4

After:

105559-after-ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Narrow (400px) before:

Narrow (400px) after:

Wide after (unchanged):

The wrapper View added around SearchSelectAllMenu defaulted to a column, stacking the checkbox and its Select all label on narrow layouts.

codecov · 2026-11-02T09:06:56Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...c/components/Search/primitives/SelectionTopBar.tsx	`0.00% <0.00%> (ø)`
... and 2 files with indirect coverage changes

melvin-bot · 2026-11-02T09:21:47Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-11-02T09:35:58Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-02T09:35:56.682820Z	`ee13326`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Krishna2323 · 2026-11-02T09:39:03Z

Reviewing...

Krishna2323 · 2026-11-02T10:28:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web_chrome.mp4

android_hybrid.mp4

Krishna2323

LGTM!

github-actions · 2026-11-02T13:04:16Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-11-02T13:07:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-11-02T13:08:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105599 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9408992d-f89e1f8-9821650952510ae53cb46b12d455781c778ea4b0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9408992d-f89e1f8-85e99c739d1014c214de426c5bb692615b265130/index.html

Web 🕸️
https://105599.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…ct-all-label-layout Fix Select all label stacking below the checkbox in Search selection mode (cherry picked from commit 9408992) (cherry-picked to staging by Beamanator)

OSBotify · 2026-11-02T14:38:11Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.5.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-11-02T14:40:33Z

No help site update needed. This PR is a one-line layout fix that moves the "Select all" label back next to the header checkbox on narrow layouts, so the app now looks the way users already expect and no help article sentence became incorrect.

OSBotify · 2026-11-02T18:24:26Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

fix: lay out Select all label next to the header checkbox

ee13326

The wrapper View added around SearchSelectAllMenu defaulted to a column, stacking the checkbox and its Select all label on narrow layouts.

melvin-bot Bot assigned war-in Nov 2, 2026

war-in marked this pull request as ready for review November 2, 2026 09:21

war-in requested review from a team as code owners November 2, 2026 09:21

melvin-bot Bot requested review from Krishna2323 and heyjennahay and removed request for a team November 2, 2026 09:21

melvin-bot Bot removed the request for review from a team November 2, 2026 09:21

war-in mentioned this pull request Nov 2, 2026

[CFI] Allow table columns to be manually resized on web/desktop #101331

Open

Krishna2323 approved these changes Nov 2, 2026

View reviewed changes

melvin-bot Bot requested review from Beamanator and JS00001 November 2, 2026 10:28

JS00001 approved these changes Nov 2, 2026

View reviewed changes

JS00001 merged commit 9408992 into Expensify:main Nov 2, 2026
48 of 50 checks passed

JS00001 changed the title ~~Fix Select all label stacking below the checkbox in Search selection mode~~ [cp staging] Fix Select all label stacking below the checkbox in Search selection mode Nov 2, 2026

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 2, 2026

OSBotify mentioned this pull request Nov 2, 2026

Deploy Checklist: New Expensify 2026-10-31 #105544

Closed

77 tasks done

melvin-bot Bot mentioned this pull request Nov 2, 2026

[Due for payment 2026-11-09] Android & iOS - Spend - Select all label appears below checkbox instead of next to checkbox #105559

Closed

2 of 7 tasks

Navigation Menu

Repository navigation

[cp staging] Fix Select all label stacking below the checkbox in Search selection mode - #105599

[cp staging] Fix Select all label stacking below the checkbox in Search selection mode#105599
JS00001 merged 1 commit into
Expensify:mainfrom
software-mansion-labs:war-in/fix-select-all-label-layout

war-in commented Nov 2, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Nov 2, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Nov 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 2, 2026

Uh oh!

Krishna2323 commented Nov 2, 2026

Uh oh!

Krishna2323 commented Nov 2, 2026

Uh oh!

Krishna2323 left a comment

Uh oh!

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

MelvinBot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

war-in commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Nov 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Nov 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 2, 2026

Codex Review Summary

Uh oh!

Krishna2323 commented Nov 2, 2026

Uh oh!

Krishna2323 commented Nov 2, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

MelvinBot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

war-in commented Nov 2, 2026 •

edited

Loading

codecov Bot commented Nov 2, 2026 •

edited by github-actions Bot

Loading