Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewing... |
|
🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/components/TransactionItemRow/TransactionItemRowWide.tsx
|
@Krishna2323 comments addressed! |
JmillsExpensify
left a comment
There was a problem hiding this comment.
This is feeling good to me! Going to approve though let's make sure we get a @Expensify/design review before merging.
|
That's a good point. I knew what I was looking for, but I could see a user not realizing that this is possible. |
BUG: Filters and Display dropdown doesn't open after resizingMonosnap.screencast.2026-10-30.16-14-56.mp4 |
@Krishna2323 have you been able to reproduce it on the latest adhoc build? I tried there an locally and couldn't :/ Are there any additional steps/config I could follow? |
|
@war-in Column widths are saved per data type, so Reports, Submit, Approve and Pay share one layout. Resizing in one changes all. Is that intended? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb_chrome.mp4 |
@Expensify/design are we fine with all those views sharing the layout? Or do we want them to save their own widths? |
Krishna2323
left a comment
There was a problem hiding this comment.
LGTM!
@Expensify/design approving, but flagging a product decisions for a quick look:
- Widths are saved per data type, not per search. Reports and the to-do searches ("Drafts", "Need approval", "Ready to Pay") share one layout, so resizing a column in one changes it across all of them. Filters also retain the same column widths.
I think this makes sense to me but I'd love to get confirmation from @trjExpensify & @JmillsExpensify |
JS00001
left a comment
There was a problem hiding this comment.
One issue I ran into while testing:
- Update the width of a column
- Hide the column
- Resize a different column
- Re-add the column
- The column width is reset
Can we fix this in a follow up?
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Mhm, that might feel a bit unexpected in practice.
This PR is merged now, so let's give it a test on staging I guess. |
|
This is behind a beta, so we can follow up on it if we want to change the behavior |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.27-0 🚀
|
|
No help site update needed. Resizable Spend columns only appear for accounts with the |
|
Deploy Blocker #105559 was identified to be related to this PR. |
|
Deploy Blocker #105560 was identified to be related to this PR. |
|
Deploy Blocker #105586 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Makes Spend tab columns resizable on web (behind
resizableTableColumns).useSearchColumnWidthsfeeds the existingTableresize engine through a sharedgetPersistedColumnLayout, cells read the same CSS width variables, and the handle moves to a sharedColumnResizeContext. Widths persist inTABLE_COLUMN_WIDTHS, one entry per data type (search:<type>). Grouped tables don't resize.Fixed Issues
$ #101331
PROPOSAL:
Tests
Prerequisite: an account with the
resizableTableColumnsbeta and a few expenses with a long merchant and description. Use a wide browser window.Test 1: Drag and persist
Test 2: Fit and reset
Test 3: Separate widths per table and no regressions elsewhere
Offline tests
QA Steps
Same as tests. On native and mobile web, verify that Spend renders exactly as before, with no resize handles.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
test1-drag-and-persist.mp4
test2-fit-and-reset.mp4
test3-separate-widths-and-regressions.mp4
offline-resize-persists.mp4