Skip to content

[Resizable columns] Spend tab - #105128

Merged
JS00001 merged 17 commits into
Expensify:mainfrom
software-mansion-labs:war-in/resizable-spend-tables
Oct 30, 2026
Merged

JS00001 merged 17 commits into
Expensify:mainfrom
software-mansion-labs:war-in/resizable-spend-tables

Conversation

@war-in

@war-in war-in commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Makes Spend tab columns resizable on web (behind resizableTableColumns). useSearchColumnWidths feeds the existing Table resize engine through a shared getPersistedColumnLayout, cells read the same CSS width variables, and the handle moves to a shared ColumnResizeContext. Widths persist in TABLE_COLUMN_WIDTHS, one entry per data type (search:<type>). Grouped tables don't resize.

Fixed Issues

$ #101331
PROPOSAL:

Tests

Prerequisite: an account with the resizableTableColumns beta and a few expenses with a long merchant and description. Use a wide browser window.

Test 1: Drag and persist

  1. Open Spend > Expenses and make sure the Merchant, Description, From and Category columns are shown (Display > Columns)
  2. Hover the right edge of the Merchant header and verify that a grip appears
  3. Drag the Merchant edge to the right
  4. Verify that a vertical line spans the header and all rows while dragging, Merchant widens to show more of its text, and the columns to its right shrink while Date and Amount keep their width
  5. Release, then reload the page
  6. Verify that Merchant keeps the width you dragged it to and the header and row columns stay aligned

Test 2: Fit and reset

  1. On Spend > Expenses, single-click the right edge of the Description header
  2. Verify that Description fits its longest value
  3. Double-click the right edge of a column you resized earlier
  4. Verify that the column goes back to the width it has on a fresh load

Test 3: Separate widths per table and no regressions elsewhere

  1. Resize Merchant on Spend > Expenses
  2. Open Spend > Reports and resize one of its columns, then go back to Spend > Expenses
  3. Verify that the Expenses widths are unchanged and the Reports widths are kept separately
  4. Group expenses by any option (Display > Group by) and verify that no resize handles appear on the grouped table
  5. Narrow the window below the large-screen breakpoint and verify that no resize handles appear and rows render as before
  6. Open an expense report from Spend and the Money Request report view and verify that its table looks and behaves as before

Offline tests

  1. Go offline
  2. On Spend > Expenses, resize the Merchant column and reload the page
  3. Verify that the resized width is kept, since column widths are stored locally on the device

QA Steps

Same as tests. On native and mobile web, verify that Spend renders exactly as before, with no resize handles.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
test1-drag-and-persist.mp4
test2-fit-and-reset.mp4
test3-separate-widths-and-regressions.mp4
offline-resize-persists.mp4

@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 95.90% <ø> (ø)
src/components/Search/SortableTableHeader.tsx 75.55% <100.00%> (+0.55%) ⬆️
...c/components/Search/hooks/useSearchColumnWidths.ts 93.50% <100.00%> (+78.25%) ⬆️
...mponents/Search/hooks/useSearchTableWidth/index.ts 0.00% <ø> (ø)
src/components/Search/index.tsx 70.48% <ø> (ø)
src/components/Table/TableContext.tsx 69.23% <ø> (ø)
src/components/Table/TableHeader.tsx 96.00% <100.00%> (+0.06%) ⬆️
...ts/Table/columnResize/ColumnResizeContext/index.ts 100.00% <100.00%> (ø)
...nents/Table/columnResize/columnWidthExpressions.ts 100.00% <ø> (ø)
...nts/Table/columnResize/getPersistedColumnLayout.ts 100.00% <100.00%> (ø)
... and 16 more
... and 99 files with indirect coverage changes

@war-in
war-in marked this pull request as ready for review October 27, 2026 15:35
@war-in
war-in requested review from a team as code owners October 27, 2026 15:35
@melvin-bot
melvin-bot Bot requested review from Krishna2323 and dylanexpensify and removed request for a team October 27, 2026 15:35
@melvin-bot

melvin-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-27T15:35:12.959761Z 4b398a9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewing...

@github-actions

Copy link
Copy Markdown
Contributor

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

# Conflicts:
#	src/components/TransactionItemRow/TransactionItemRowWide.tsx
@war-in

war-in commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

@Krishna2323 comments addressed!

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is feeling good to me! Going to approve though let's make sure we get a @Expensify/design review before merging.

@shawnborton

Copy link
Copy Markdown
Contributor

The indicator is very very subtle, I wonder if we should try using our theme icon color instead of border?
CleanShot 2026-10-28 at 9 46 47 PM@2x

Copy link
Copy Markdown
Contributor

That's a good point. I knew what I was looking for, but I could see a user not realizing that this is possible.

@Krishna2323

Krishna2323 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

BUG: Filters and Display dropdown doesn't open after resizing

Monosnap.screencast.2026-10-30.16-14-56.mp4

@war-in

war-in commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

BUG: Filters and Display dropdown doesn't open after resizing

@Krishna2323 have you been able to reproduce it on the latest adhoc build? I tried there an locally and couldn't :/ Are there any additional steps/config I could follow?

@Krishna2323

Copy link
Copy Markdown
Contributor

@war-in Column widths are saved per data type, so Reports, Submit, Approve and Pay share one layout. Resizing in one changes all. Is that intended?

@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome.mp4

@war-in

war-in commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

@war-in Column widths are saved per data type, so Reports, Submit, Approve and Pay share one layout. Resizing in one changes all. Is that intended?

@Expensify/design are we fine with all those views sharing the layout? Or do we want them to save their own widths?

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Expensify/design approving, but flagging a product decisions for a quick look:

  • Widths are saved per data type, not per search. Reports and the to-do searches ("Drafts", "Need approval", "Ready to Pay") share one layout, so resizing a column in one changes it across all of them. Filters also retain the same column widths.

@dannymcclain

Copy link
Copy Markdown
Contributor

Widths are saved per data type, not per search. Reports and the to-do searches ("Drafts", "Need approval", "Ready to Pay") share one layout, so resizing a column in one changes it across all of them. Filters also retain the same column widths.

I think this makes sense to me but I'd love to get confirmation from @trjExpensify & @JmillsExpensify

@JS00001 JS00001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue I ran into while testing:

  1. Update the width of a column
  2. Hide the column
  3. Resize a different column
  4. Re-add the column
  5. The column width is reset

Can we fix this in a follow up?

@JS00001
JS00001 merged commit adcfcac into Expensify:main Oct 30, 2026
49 of 76 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@trjExpensify

Copy link
Copy Markdown
Contributor

Widths are saved per data type, not per search. Reports and the to-do searches ("Drafts", "Need approval", "Ready to Pay") share one layout, so resizing a column in one changes it across all of them. Filters also retain the same column widths.

Mhm, that might feel a bit unexpected in practice.

  1. Resize some columns on "Expenses"
  2. Reports remain "as is" because it's a different "data type"
  3. Saved searches change.
  4. Group based search change because they're "type:expense" (??)
  5. Resize some columns on "Reports".
  6. Todos change.

This PR is merged now, so let's give it a test on staging I guess.

@JS00001

JS00001 commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

This is behind a beta, so we can follow up on it if we want to change the behavior

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.27-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. Resizable Spend columns only appear for accounts with the resizableTableColumns beta (isBetaEnabled(CONST.BETAS.RESIZABLE_TABLE_COLUMNS) in SearchListViewLayout.tsx), and the ungated changes are internal refactors with no visible behavior change.


view run

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #105559 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #105560 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #105586 was identified to be related to this PR.

@OSBotify

OSBotify commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.