[chrispader]

ReportActionsList.tsx is a 729-line component that mixes row preparation, scroll handling, telemetry and rendering. The LegendList migration in #100733 changes most of it, so that diff shows the whole file as deleted and rewritten across new modules. This PR does the module split first, on the current FlashList list and without behavior changes, so the migration diff only shows what LegendList changes.

@roryabraham @dmkt9

Explanation of Change

This is layer 6 of the twelve-part LegendList rollout. It moves ReportActionsList.tsx into a ReportActionsList directory and splits it along the same lines as the migration:

src/pages/inbox/report/ReportActionsList/
├── index.tsx                           wraps the content in the skeleton guard
├── ReportActionsListContent.tsx        renders the list (moved from ReportActionsList.tsx)
├── useReportActionsListData.ts         Concierge drafts, support surveys, collapsed updates
├── useReportActionsListRenderItem.tsx  renders each row and lists the values that re-render rows
├── useReportActionsListScroll.ts       positioning, pagination, unread tracking, edit scrolling
├── useReportActionsListTelemetry.ts    ends the warm open-report span on the first layout
└── types.ts

The code moves as it is. The list still uses the inverted FlashList, and existing imports of @pages/inbox/report/ReportActionsList resolve to index.tsx.

Fixed Issues

$ #98994

This PR is part of the migration split from #98270. No approved proposal is linked.

Tests

All platforms means desktop web, mobile web, Android, and iOS.

Use a second test account in the same chat for the incoming-message case.

All platforms, history and incoming messages

1. Open a chat with a long history shared with the second test account. The newest messages should appear at the bottom.
2. Scroll upward until older messages load. The message you were reading should stay in place.
3. Keep scrolling upward until the button for returning to the latest messages appears.
4. Send a message from the second account. The message you were reading should stay in place.
5. Use the button to return to the latest messages. The new message should be visible.
6. Open a different chat on the account being tested.
7. Send another message to the shared chat from the second account.
8. Open the shared chat on the account being tested. The unread marker should identify the new message.

All platforms, a link to an older message

1. Open a long chat.
2. Open an older message's action menu.
3. Copy the message link.
4. Open a different chat.
5. Paste the link into the message box.
6. Send the link.
7. Open the sent link. The linked message should be visible in the correct chat.

All platforms, editing an older message

1. Open a chat containing an older message that you sent.
2. Scroll to that message.
3. Open its action menu.
4. Choose Edit.
5. Change the message text.
6. Save the edit. The updated message should remain at its original place in the conversation.

All platforms, collapsed updates in an expense report

1. Open an expense report with several updates in a row, such as edits to its expenses. A "show N updates" row should replace them.
2. Tap the "show N updates" row. The updates should appear in place.

All platforms, Concierge reply

1. Open the Concierge chat.
2. Send a question. Concierge's reply should appear below it.

• Verify that no errors appear in the JS console

Offline tests

All platforms, cached chats offline and history after reconnecting

1. Open a chat with a long history while online.
2. Disconnect the internet.
3. Return to the inbox.
4. Reopen the chat. The cached messages should remain visible in the correct order.
5. Scroll to the beginning of the available history. Existing messages should remain visible.
6. Reconnect the internet.
7. Scroll upward. Older messages should load without duplicates or a jump in the message you were reading.

QA Steps

None. This PR moves code without changing behavior.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Cold chat open and initial loading

FlashList is on the left and LegendList is on the right. FlashList leaves the report body blank during loading; LegendList shows the report-action skeleton before messages appear.

ColdOpenLoading.mp4

Cold expense-chat open

FlashList is on the left and LegendList is on the right. Both progress from the loading skeleton to an expense preview and its surrounding report actions.

Android screen recording TBD.

Warm expense-chat open

FlashList is on the left and LegendList is on the right. Both open the cached expense preview and report actions from the inbox.

Android screen recording TBD.

Warm chat open

Side-by-side opens of the same cached chat, ending on the same report-action history. The implementations are not labeled in this recording.

Android screen recording TBD.

Android: mWeb Chrome

iOS: Native

Cold chat open and initial loading

FlashList is on the left and LegendList is on the right. FlashList leaves the report body blank during loading; LegendList shows the report-action skeleton before messages appear.

LegendListLoadingSkeletonVsFlashList.mp4

Cold expense-chat open

FlashList is on the left and LegendList is on the right. Both progress from the loading skeleton to an expense preview and its surrounding report actions.

ExpenseChatCold.mp4

Warm expense-chat open

FlashList is on the left and LegendList is on the right. Both open the cached expense preview and report actions from the inbox.

ExpenseChatWarm.mp4

Warm chat open

Side-by-side opens of the same cached chat, ending on the same report-action history. The implementations are not labeled in this recording.

LegendListWarmReportOpen.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-30T10:20:50.168183Z We couldn’t complete this review. Comment @codex review to try again.	ad3bf92	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/inbox/report/ReportActionsList/index.tsx	100.00% <100.00%> (ø)
...ort/ReportActionsList/ReportActionsListContent.tsx	98.47% <98.47%> (ø)
...portActionsList/useReportActionsListRenderItem.tsx	95.89% <95.89%> (ø)
...ReportActionsList/useReportActionsListTelemetry.ts	75.00% <75.00%> (ø)
...rt/ReportActionsList/useReportActionsListScroll.ts	94.05% <94.05%> (ø)
...port/ReportActionsList/useReportActionsListData.ts	91.46% <91.46%> (ø)
... and 157 files with indirect coverage changes

[chrispader]

@roryabraham feel free to merge this right away, since it's just a refactor.

[trjExpensify]

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

[roryabraham]

@MelvinBot review

[MelvinBot]

I found no behavior changes. The split is a faithful move of the old ReportActionsList.tsx, and it's safe to merge. The only failing check is Check independent approval, which clears once a reviewer approves.

There are two optional nits:

1. Stale doc path. contributingGuides/OBSERVABILITY_METRICS.md:45 still points to src/pages/inbox/report/ReportActionsList.tsx. The warm span now ends in useReportActionsListTelemetry.ts.
2. One name, two arrays. useReportActionsListData returns renderedVisibleReportActions as the rows before collapsing. useReportActionsListScroll takes a param with the same name but gets listData, the rows after collapsing (ReportActionsListContent.tsx:154, useReportActionsListScroll.ts:41). Renaming the scroll param to listData would avoid confusion in the LegendList diff.

What I checked

• Code blocks match. I diffed every block against the old file at the PR base (10cc6c30d1): draft insertion, support-survey filtering, presentation, render item, extraData, scroll and pagination handlers, and the telemetry span. All of them match apart from variable renames (displayedReportActions → listData, reportActionIDFromRoute → linkedReportActionID).
• List props match. InvertedFlashList gets the same props as before. The keys in listProps don't overlap with the explicit JSX props, so the spread order doesn't matter.
• Layout and scroll order is unchanged. onLayout still runs the parent's onLayout, then markOpenReportEnd on the first layout, then flushPendingScrollToBottom. The threshold state still lives in the content component.
• Effects run in the same order. The order is: didLayout reset, draft clear and reveal, expanded-focus scroll, scroll to the message being edited, useReportActionsScroll, then useFollowActionBadgeTarget.
• Identity checks still hold. isSyntheticDraftVisible compares arrays by reference. It still compares against the filtered sortedVisibleReportActions, because that is the array passed into the data hook.
• Nothing was lost from main. main hasn't changed the old file since the PR base, so the moved code doesn't drop any newer commits.
• Existing imports still work. @pages/inbox/report/ReportActionsList now resolves to index.tsx. The unit, UI, and perf tests that import it pass in CI.

---

view run

[roryabraham]

Ok, I'm digging in and might come to you with a suggestion for a broader simplification of the ReportActionsList data model, but for now since this PR just moves existing logic into more focused models, I think we can ship it.

[roryabraham]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105473 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a6738db9-27f6611-778a3d21dad149d304ec0cb933e79d5168a2c444/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a6738db9-27f6611-61f460b9cfa316d073b1ece54406bfd6a37f5926/index.html

Web 🕸️
https://105473.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.27-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

No help site update needed. This PR moves the report actions list code into separate modules and doesn't change behavior, so no help article sentence is now wrong.

---

view run

[OSBotify]

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS