[Insights] Improve chart tooltip dismissal by OlGierd03 · Pull Request #105388 · Expensify/App

OlGierd03 · 2026-10-29T14:35:15Z

Explanation of Change

Clicking a chart on Home opened another tab and Home was frozen with react-freeze instead of being unmounted. Freezing detached the Reanimated style from the tooltip view and the tooltip lived in a portal on body that the freeze didn't hide, so it kept its last opacity: 1 on every page. The portal now renders only while its screen is focused and every shown tooltip, hovered or pinned, is dismissed on blur, touch and resize, so the tooltip is removed before the screen freezes.

Fixed Issues

$ #102814

Tests

On Home, hover a bar in the Insights section and click it.
Verify the Spend page opens with no tooltip.
Go back and verify no tooltip shows until you hover the chart again.
Repeat steps 1–3 on the Insights page for Spend over time and Top spenders.
On mobile, tap a bar, then tap outside the chart and verify the tooltip hides.
On mobile, tap a bar, rotate the device and verify the tooltip hides.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

iOS: Native

Screen.Recording.2026-10-29.at.15.42.11.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-29.at.15.45.54.mov

codecov · 2026-10-29T14:41:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Charts/PieChart/PieChartContent.tsx	`79.38% <100.00%> (ø)`
...components/Charts/components/ChartTooltipLayer.tsx	`46.87% <ø> (ø)`
...rc/components/Charts/hooks/useChartInteractions.ts	`77.50% <100.00%> (ø)`
...c/components/Charts/hooks/useTouchPinnedTooltip.ts	`84.61% <100.00%> (-2.06%)`	⬇️
...onents/Charts/BarChart/VerticalBarChartContent.tsx	`2.56% <0.00%> (ø)`
...c/components/Charts/LineChart/LineChartContent.tsx	`3.66% <0.00%> (ø)`
...er/components/VictoryChartCartesianInteractive.tsx	`4.16% <0.00%> (-0.19%)`	⬇️
...ryChartRenderer/hooks/useVictoryBarInteractions.ts	`0.00% <0.00%> (ø)`
src/components/Charts/components/ChartTooltip.tsx	`1.21% <0.00%> (+0.01%)`	⬆️
... and 10 files with indirect coverage changes

mhawryluk

thanks!

chatgpt-codex-connector · 2026-10-29T15:10:32Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-29T15:33:21.677908Z	`1333e55`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

melvin-bot · 2026-10-29T15:10:32Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OlGierd03 · 2026-10-29T15:11:54Z

@MelvinBot request review from @truph01 instead of @abdulrahuman5196 (it's part of the Insights project)

MelvinBot · 2026-10-29T15:14:31Z

Done. I requested a review from truph01 and removed abdulrahuman5196. The requested reviewers are now truph01 and JmillsExpensify.

view run

OlGierd03 · 2026-10-29T15:15:07Z

@abdulrahuman5196 sorry for pulling you off this one. This PR is part of the Insights project and @truph01 is one of the reviewers assigned to that work, so I swapped them in

dannymcclain · 2026-10-29T15:18:32Z

Videos look good to me 👍

JmillsExpensify

Looks great to me

JmillsExpensify · 2026-10-29T15:48:45Z

@truph01 you're up

…k-On-Home

truph01 · 2026-10-30T07:32:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-10-30.at.14.31.45.mov

Android: mWeb Chrome

Screen.Recording.2026-10-30.at.14.30.17.mov

iOS: HybridApp

Screen.Recording.2026-10-30.at.12.57.56.mov

iOS: mWeb Safari

Screen.Recording.2026-10-30.at.12.51.56.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-30.at.12.51.06.mov

mountiny

LGTM and Carlos already approved so moving this ahead

github-actions · 2026-10-30T08:58:41Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-30T09:04:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-30T09:04:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105388 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-223b285b-b074b1f-28cd454f22481b22f007b45066ed5e6053b24bd3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-223b285b-b074b1f-aa64b6920365b78754c0f497628815afbfeb2741/index.html

Web 🕸️
https://105388.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-31T07:22:20Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.27-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-31T07:25:20Z

No help site update needed. This PR fixes a bug where a chart tooltip stayed on screen after you left Home or Insights, so the app now behaves the way users already expect.

OSBotify · 2026-11-02T18:23:53Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Improve chart tooltip dismiss

1333e55

melvin-bot Bot assigned OlGierd03 Oct 29, 2026

OlGierd03 changed the title ~~[NoQA][Insights] Improve chart tooltip dismissal~~ [Insights] Improve chart tooltip dismissal Oct 29, 2026

mhawryluk approved these changes Oct 29, 2026

View reviewed changes

OlGierd03 marked this pull request as ready for review October 29, 2026 15:10

OlGierd03 requested review from a team as code owners October 29, 2026 15:10

melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team October 29, 2026 15:10

melvin-bot Bot requested review from JmillsExpensify and removed request for a team October 29, 2026 15:10

MelvinBot requested review from truph01 and removed request for abdulrahuman5196 October 29, 2026 15:14

JmillsExpensify previously approved these changes Oct 29, 2026

View reviewed changes

JmillsExpensify requested a review from luacmartins October 29, 2026 15:48

luacmartins previously approved these changes Oct 29, 2026

View reviewed changes

Merge branch 'main' into @OlGierd03/Insights-Tooltip-Stays-After-Clic…

049a4fa

…k-On-Home

OlGierd03 dismissed stale reviews from luacmartins and JmillsExpensify via 049a4fa October 29, 2026 17:19

luacmartins approved these changes Oct 29, 2026

View reviewed changes

truph01 approved these changes Oct 30, 2026

View reviewed changes

melvin-bot Bot requested review from cristipaval and luacmartins October 30, 2026 07:36

mountiny approved these changes Oct 30, 2026

View reviewed changes

mountiny merged commit 223b285 into Expensify:main Oct 30, 2026
38 of 42 checks passed

OSBotify mentioned this pull request Oct 31, 2026

Deploy Checklist: New Expensify 2026-10-31 #105544

Closed

77 tasks done

MelvinBot mentioned this pull request Oct 31, 2026

[Exploratory] Web - Home - Insights tooltip remains displayed in different pages after clicking on chart. #105357

Closed

1 of 7 tasks

melvin-bot Bot mentioned this pull request Nov 2, 2026

[Insights] [R1] Simplify Insights graphs, move row detail into tooltips, and polish chart styling #102814

Open

brunovjk mentioned this pull request Nov 3, 2026

[Due for payment 2026-10-30] Web - Home tab renders in the background and slows opening reports #104081

Closed

Conversation

OlGierd03 commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mhawryluk left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

melvin-bot Bot commented Oct 29, 2026

Uh oh!

OlGierd03 commented Oct 29, 2026

Uh oh!

MelvinBot commented Oct 29, 2026

Uh oh!

OlGierd03 commented Oct 29, 2026

Uh oh!

dannymcclain commented Oct 29, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify commented Oct 29, 2026

Uh oh!

truph01 commented Oct 30, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

OSBotify commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

OSBotify commented Oct 31, 2026

Uh oh!

MelvinBot commented Oct 31, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

OlGierd03 commented Oct 29, 2026 •

edited

Loading

codecov Bot commented Oct 29, 2026 •

edited by github-actions Bot

Loading

chatgpt-codex-connector Bot commented Oct 29, 2026 •

edited

Loading