Remove Insights page and comparison beta gates by luacmartins · Pull Request #104595 · Expensify/App

luacmartins · 2026-10-21T17:05:36Z

Explanation of Change

Remove the insightsPage and insightsCompare gates and their disabled paths. Keep the current beta-on behavior for navigation, Home insights and comparisons on every platform.

Keep this PR in draft until both betas are enabled for everyone and the native fixes have fully rolled out. Backend beta definitions remain unchanged for older clients.

Also remove the temporary desktop-only permission override introduced in #104591, which is now on main.

Fixed Issues

$ #100658
$ #100665

Tests

N/A

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-10-21T17:16:51Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.90% <ø> (ø)`
src/components/Navigation/AccountAvatarButton.tsx	`89.18% <100.00%> (-2.92%)`	⬇️
...s/Search/SearchRouter/useNavigationSuggestions.tsx	`90.83% <100.00%> (-0.23%)`	⬇️
...c/hooks/useIsSettingsDrawnOverTabs/index.native.ts	`100.00% <100.00%> (ø)`
src/hooks/useSearchTypeMenuSections.ts	`96.07% <ø> (+1.73%)`	⬆️
...bNavigator/useNativeTabBarOptions/index.android.ts	`100.00% <100.00%> (ø)`
...veTabNavigator/useNativeTabBarOptions/index.ios.ts	`100.00% <100.00%> (ø)`
...gators/NativeTabNavigator/useNativeTabNavigator.ts	`100.00% <100.00%> (+1.66%)`	⬆️
...on/AppNavigator/Navigators/TabNavigator.native.tsx	`100.00% <100.00%> (ø)`
src/libs/Permissions.ts	`100.00% <ø> (+4.54%)`	⬆️
... and 12 more
... and 7 files with indirect coverage changes

melvin-bot · 2026-10-27T17:37:23Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-27T17:37:24Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T17:40:49.430226Z	`01de9a4`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

aimane-chnaif · 2026-10-27T17:56:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

luacmartins · 2026-10-27T18:36:45Z

Updated

JmillsExpensify

All good on my end.

JS00001

lgtm, whats with all of the tab icon changes in this pr though?

aimane-chnaif · 2026-10-29T13:23:08Z

lgtm, whats with all of the tab icon changes in this pr though?

The tab icon code was added in #104972 to draw the status emoji on the Account avatar in the native bottom bar (#104966).
After removing beta, Account isn't in the native bottom bar anymore, so that code never runs and is removed here.

JS00001 · 2026-10-29T13:32:41Z

nice, lets ship it then

JS00001 · 2026-10-29T13:33:13Z

@luacmartins going to let you merge just in case its not meant to merge yet

github-actions · 2026-10-29T15:58:10Z

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-29T16:01:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-29T16:03:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104595 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-538aefeb-c16f6b4-65e5e21f3652e0e75144dc052f48d04c7ea98f79/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-538aefeb-c16f6b4-e62a2be7c9db305b49e5822fb8424ceffe001b10/index.html

Web 🕸️
https://104595.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

izarutskaya · 2026-10-29T21:04:21Z

@luacmartins @flaviadefaria Can I check this off the list?

QA Steps
N/A

luacmartins · 2026-10-29T21:12:02Z

@izarutskaya yes please

OSBotify · 2026-10-29T23:17:01Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

aimane-chnaif · 2026-11-01T00:24:52Z

@MelvinBot assign me in the linked PRs

MelvinBot · 2026-11-01T00:31:39Z

I assigned aimane-chnaif to both issues listed under Fixed Issues:

view run

luacmartins · 2026-11-02T18:36:20Z

I think automation failed here. This PR should be in prod already, see this checklist #105415

refactor: Remove Insights page and comparison beta gates

1238ef4

luacmartins requested a review from a team October 21, 2026 17:05

melvin-bot Bot assigned luacmartins Oct 21, 2026

Merge latest main into cmartins-insights-remove-beta-checks

b5a0808

luacmartins changed the title ~~refactor: Remove Insights page and comparison beta gates~~ Remove Insights page and comparison beta gates Oct 21, 2026

luacmartins added 2 commits October 21, 2026 13:41

fix: Remove unused spend insight keys export

99bf996

Merge latest main into cmartins-insights-remove-beta-checks

8d72b37

luacmartins closed this Oct 23, 2026

luacmartins reopened this Oct 23, 2026

Merge latest main into cmartins-insights-remove-beta-checks

8603133

luacmartins changed the title ~~Remove Insights page and comparison beta gates~~ [HOLD App 104595] Remove Insights page and comparison beta gates Oct 23, 2026

luacmartins changed the title ~~[HOLD App 104595] Remove Insights page and comparison beta gates~~ Remove Insights page and comparison beta gates Oct 23, 2026

luacmartins changed the title ~~Remove Insights page and comparison beta gates~~ [HOLD rollout] Remove Insights page and comparison beta gates Oct 23, 2026

luacmartins added 2 commits October 27, 2026 11:15

Merge latest main into cmartins-insights-remove-beta-checks

c4a9a85

Merge latest main into cmartins-insights-remove-beta-checks

01de9a4

luacmartins marked this pull request as ready for review October 27, 2026 17:37

luacmartins requested a review from a team as a code owner October 27, 2026 17:37

melvin-bot Bot requested review from aimane-chnaif and removed request for a team October 27, 2026 17:37

melvin-bot Bot requested a review from flaviadefaria October 27, 2026 17:37

melvin-bot Bot removed the request for review from a team October 27, 2026 17:37

luacmartins changed the title ~~[HOLD rollout] Remove Insights page and comparison beta gates~~ Remove Insights page and comparison beta gates Oct 27, 2026

aimane-chnaif reviewed Oct 27, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/Navigators/NativeTabNavigator/useNativeTabNavigator.ts Resolved

Comment thread tests/unit/SearchRouterNavigationTest.ts Resolved

Comment thread src/hooks/useIsSettingsDrawnOverTabs/index.native.ts Resolved

Remove obsolete native Account tab icon code

e384109

luacmartins requested review from a team as code owners October 27, 2026 18:33

luacmartins requested a review from aimane-chnaif October 27, 2026 18:38

TaduJR removed their request for review October 27, 2026 18:40

aimane-chnaif approved these changes Oct 27, 2026

View reviewed changes

JmillsExpensify previously approved these changes Oct 27, 2026

View reviewed changes

luacmartins requested review from JS00001 and removed request for aldo-expensify and cristipaval October 28, 2026 17:16

Merge latest main into cmartins-insights-remove-beta-checks

5aa9067

luacmartins dismissed JmillsExpensify’s stale review via 5aa9067 October 28, 2026 17:27

JS00001 approved these changes Oct 29, 2026

View reviewed changes

luacmartins merged commit 538aefe into main Oct 29, 2026
46 of 47 checks passed

luacmartins deleted the cmartins-insights-remove-beta-checks branch October 29, 2026 15:43

truph01 mentioned this pull request Oct 29, 2026

[NoQA][Insights] Add the AI insight card row #104564

Merged

36 tasks done

OSBotify mentioned this pull request Oct 29, 2026

Deploy Checklist: New Expensify 2026-10-29 #105415

Closed

55 tasks done

wildan-m mentioned this pull request Oct 29, 2026

Remove Android native tabs when React removes them #105020

Merged

38 tasks done

This was referenced Oct 31, 2026

[Due for payment 2026-11-07] [Insights][R1][App] Remove the Insights page beta #100658

Open

[Due for payment 2026-11-07] [Insights][R2][App] Remove the Insights compare beta #100665

Open

Conversation

luacmartins commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 27, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

aimane-chnaif commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luacmartins commented Oct 27, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JS00001 commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JS00001 commented Oct 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 29, 2026

Uh oh!

OSBotify commented Oct 29, 2026

Uh oh!

github-actions Bot commented Oct 29, 2026

Uh oh!

izarutskaya commented Oct 29, 2026

Uh oh!

luacmartins commented Oct 29, 2026

Uh oh!

OSBotify commented Oct 29, 2026

Uh oh!

aimane-chnaif commented Nov 1, 2026

Uh oh!

MelvinBot commented Nov 1, 2026

Uh oh!

luacmartins commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

luacmartins commented Oct 21, 2026 •

edited

Loading

codecov Bot commented Oct 21, 2026 •

edited by github-actions Bot

Loading

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

aimane-chnaif commented Oct 27, 2026 •

edited

Loading

aimane-chnaif commented Oct 29, 2026 •

edited

Loading

JS00001 commented Oct 29, 2026 •

edited

Loading