Skip to content

Freeze Home tab in the background on web #104078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
Oct 20, 2026
Merged

Freeze Home tab in the background on web #104078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/libs/Navigation/AppNavigator/Navigators/TabNavigator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import {bottomTabScreenLayoutWrapper} from '@libs/Navigation/PlatformStackNaviga
import type {TabNavigatorParamList} from '@libs/Navigation/types';
import {getSpan} from '@libs/telemetry/activeSpans';

import FreezeWrapper from '@navigation/AppNavigator/FreezeWrapper';

import CONST from '@src/CONST';
import NAVIGATORS from '@src/NAVIGATORS';
import SCREENS from '@src/SCREENS';
Expand Down Expand Up @@ -66,7 +68,16 @@ function withSuspense<P extends Record<string, unknown>>(LazyComponent: React.La
return SuspenseWrapper;
}

const HomePageScreen = withSuspense(LazyHomePage);
const HomePageWithSuspense = withSuspense(LazyHomePage);

// Outside the Suspense so the lazy chunk load still shows LazyFallback instead of suspending into Freeze.
function HomePageScreen() {
return (
<FreezeWrapper>
<HomePageWithSuspense />
</FreezeWrapper>
Comment on lines +76 to +78

@mkhutornyi mkhutornyi Oct 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR caused regression:

Bug: Web - Home - Empty state text keeps old theme color after theme switch

Image
Screen.Recording.2026-10-29.at.2.40.33.PM.mov

@mountiny mountiny Nov 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @adhorodyski

@nkdengineer is this fixed after your PR?

@mountiny mountiny Nov 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this is fixed

);
}
const ReportsSplitNavigatorScreen = withSuspense(LazyReportsSplitNavigator, CONST.TELEMETRY.SPAN_NAVIGATE_TO_INBOX_TAB);
const SettingsSplitNavigatorScreen = withSuspense(LazySettingsSplitNavigator);
const WorkspaceNavigatorScreen = withSuspense(LazyWorkspaceNavigator);
Expand Down
Loading