Skip to content

Freeze Home tab in the background on web - #104078

Merged
mountiny merged 1 commit into
Expensify:mainfrom
callstack-internal:perf/freeze-home-tab-web
Oct 20, 2026
Merged

mountiny merged 1 commit into
Expensify:mainfrom
callstack-internal:perf/freeze-home-tab-web

Conversation

@TMisiukiewicz

@TMisiukiewicz TMisiukiewicz commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

On web, the Home tab kept rendering while you were on another tab. Tabs are supposed to be frozen in the background (freezeOnBlur: true), but on web that option only hides the tab with display: none and doesn't stop React from rendering it. Home's sections (For You, Your Spend, Upcoming Travel) subscribe to whole Onyx collections like reports, transactions and report actions. Opening a report writes to those collections, so all three sections re-rendered in the background every time you opened a report, for example from Spend. On a large account on Windows, this adds about 100ms to opening a report.

This PR wraps the Home tab in the existing web FreezeWrapper, the same one the Search tab already uses. While another tab is focused, Home doesn't render at all. When you come back, it catches up in a single render. Native doesn't change, because freezeOnBlur already freezes tabs there.

  • The wrapper sits outside the lazy-load Suspense, so the first load of Home still shows the loading spinner.

Fixed Issues

$ #104081
PROPOSAL:

Tests

  1. Open the app on web and go to the Home tab. Note the data in For You, Your Spend and Upcoming Travel.
  2. Go to the Spend tab and open any expense report.
  3. Go back to the Home tab.
  4. Verify Home looks the same as before.
  5. On the Spend tab, approve or pay a report, then go back to Home. Verify the Your Spend totals and For You counts update.
  6. Reload the app on the Spend tab (for example /search), then click the Home tab. Verify the loading spinner shows briefly and Home loads normally.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests, but with the network connection turned off. Verify the app behaves the same and no errors appear.

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

🤖 Generated with Claude Code

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...avigation/AppNavigator/Navigators/TabNavigator.tsx 0.00% <0.00%> (ø)
... and 12 files with indirect coverage changes

@TMisiukiewicz
TMisiukiewicz marked this pull request as ready for review October 15, 2026 12:19
@TMisiukiewicz
TMisiukiewicz requested review from a team as code owners October 15, 2026 12:19
@melvin-bot
melvin-bot Bot requested review from brunovjk and flaviadefaria and removed request for a team October 15, 2026 12:19
@melvin-bot

melvin-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 15, 2026 12:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T12:32:40.090652Z 4989b1d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TMisiukiewicz

Copy link
Copy Markdown
Contributor Author

@MelvinBot test this pr

@MelvinBot

MelvinBot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Web test steps verification results: ⚠️ partial

Home renders live when you return from Spend. It shows no blank screen and picks up new data after you create an expense and after you submit its report. The full-page reload step (step 6) was skipped. Console errors could only be checked indirectly.

Home after submitting the report

Step Status
1. Open Home and note For You / Your Spend / Upcoming Travel dataNew test account. Home showed the greeting, the Getting Started checklist, "Spend over time" (chart unavailable, not enough data), the free trial card, and "Recently added" with no recent expenses. This account has no For You or Upcoming Travel sections.
Home tab initial state
✅
2. Go to Spend and open an expense reportNo expenses existed, so the tester created a $25 cash expense (merchant Coffee Shop). Then the tester opened "Expense Report 2026-10-19", which showed the correct amount, merchant, category and date.
Opened expense report
✅
3. Go back to HomeThe tester clicked Home in the left nav from the report view. The app returned to Home without errors.
✅
4. Verify Home looks the same as beforeHome rendered right away with the same section layout and no blank screen. It also showed the new expense under "Recently added" and a new "Submit 1 report" to-do, so the data was not stale.
Home after returning from Spend
✅
5. Change data on Spend, return to Home, verify totals/counts updateThe tester submitted the report with "Mark as done", and its status changed from Draft to Done. Back on Home, To-dos changed from "Submit 1 report" to "You're done!". "Recently added" still showed the $25.00 expense.
Home after submitting the report
✅
6. Reload on Spend (/search), click Home, verify spinner and normal loadNot run. A browser reload can sign the test session out and leave it stuck on a magic-code screen, so the test environment does not allow reloads. You still need to check this step by hand.
⚠️
7. No JS console errorsThe web test tool cannot capture console logs, so this was checked indirectly. Home never went blank or showed an error boundary. All observed network requests returned 200.
✅

view run · view recording

@brunovjk

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-10-20.at.11.17.10.mov
Android: mWeb Chrome
Screen.Recording.2026-10-20.at.11.20.41.mov
iOS: HybridApp
Screen.Recording.2026-10-20.at.11.19.45.mov
iOS: mWeb Safari
104078_ios_native.mov
MacOS: Chrome / Safari
104078_web_chrome.mov

@melvin-bot
melvin-bot Bot requested a review from rlinoz October 20, 2026 14:23

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Gonna move this ahead while Rodrigo is out today

@mountiny
mountiny merged commit 9f0cacd into Expensify:main Oct 20, 2026
46 of 48 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.16-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. This PR only stops the Home tab from re-rendering in the background on web, so it's a performance fix with no change to any feature, label, or workflow an article describes.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.18-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. This PR is a web performance fix that stops the Home tab from re-rendering in the background, so what users see and do on Home stays the same.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Comment on lines +76 to +78
<FreezeWrapper>
<HomePageWithSuspense />
</FreezeWrapper>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR caused regression:

Bug: Web - Home - Empty state text keeps old theme color after theme switch

Image
Screen.Recording.2026-10-29.at.2.40.33.PM.mov

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @adhorodyski

@nkdengineer is this fixed after your PR?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants