Revert "Restore: Show up to three report fields per row and edit them inline" by AndrewGable · Pull Request #103929 · Expensify/App

AndrewGable · 2026-10-13T17:40:19Z

Straight reverts #102142

$ #103913
$ #103917
$ #103918
$ #103926

… inline"

melvin-bot · 2026-10-13T17:40:25Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

chatgpt-codex-connector · 2026-10-13T17:40:30Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-13T17:52:19.371879Z	`253253c`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

melvin-bot · 2026-10-13T17:41:00Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-10-13T17:48:20Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.90% <ø> (ø)`
src/components/DatePicker/index.tsx	`63.20% <100.00%> (-0.35%)`	⬇️
...equestReportView/MoneyRequestReportActionsList.tsx	`96.73% <100.00%> (ø)`
...estReportView/MoneyRequestReportEmptyStateView.tsx	`100.00% <100.00%> (ø)`
...nents/Search/FilterDropdowns/FilterPopupButton.tsx	`100.00% <100.00%> (ø)`
src/libs/ReportFieldOptionsListUtils.ts	`96.15% <100.00%> (-3.85%)`	⬇️
src/libs/actions/Report/index.ts	`73.13% <ø> (ø)`
src/styles/index.ts	`61.81% <ø> (ø)`
...rc/components/ReportActionItem/MoneyReportView.tsx	`96.05% <86.36%> (-3.95%)`	⬇️
src/pages/EditReportFieldDropdown.tsx	`0.00% <0.00%> (-100.00%)`	⬇️
... and 2 more
... and 9 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

App/src/pages/DynamicEditReportFieldPage.tsx

Lines 169 to 171 in 253253c

    
           const isReportFieldDeletable = reportField.deletable && reportField?.fieldID !== CONST.REPORT_FIELD_TITLE_FIELD_ID; 
        
           if (isReportFieldDeletable) {

Keep deleted required report fields removable

When an administrator deletes a required date field from the workspace, its copy on an existing report can remain with deletable: false. Gating the menu on that stale flag removes the only deletion path, while handleReportFieldChange also ignores an empty value, so the obsolete field remains on the report permanently. Determine removability from whether the field still exists in the policy rather than relying only on the report copy's deletable flag.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-13T17:52:15Z

+        <OfflineWithFeedback
+            // Need to return undefined when we have pendingAction to avoid the duplicate pending action
+            pendingAction={pendingAction ? undefined : report?.pendingFields?.[reportField.fieldKey as keyof typeof report.pendingFields]}
+            errorRowStyles={styles.ph5}
+            key={`menuItem-${reportField.fieldKey}`}
+            onClose={() => clearReportFieldKeyErrors(report?.reportID, reportField.fieldKey)}


Pass report-field save errors to the feedback wrapper

When an UpdateReportField request fails after returning from the editor, the failure data writes report.errorFields[fieldKey] and rolls back the optimistic value, but this OfflineWithFeedback no longer receives that error. On multi-expense report views the save therefore appears to silently revert, unlike MoneyReportView, which still passes the same error field. Pass errors={report?.errorFields?.[reportField.fieldKey]} here so users can see and dismiss the failure.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-13T17:52:15Z

-        addBottomSafeAreaPadding: isSmallScreenWidth && !isKeyboardActive,
-        addOfflineIndicatorBottomSafeAreaPadding: false,
-    });
+    const bottomSafeAreaPaddingStyle = useBottomSafeSafeAreaPaddingStyle({addBottomSafeAreaPadding: isSmallScreenWidth && !isKeyboardActive});


Disable offline-indicator padding inside filter popovers

On a narrow screen while offline, this default enables addOfflineIndicatorBottomSafeAreaPadding, causing the hook to add CONST.OFFLINE_INDICATOR_HEIGHT to the popover content. The filter popover does not render an offline indicator, so users get a spurious blank gap that reduces the usable option-list area. Continue passing addOfflineIndicatorBottomSafeAreaPadding: false for this popover.

Useful? React with 👍 / 👎.

joekaufmanexpensify · 2026-10-13T18:19:36Z

No product review needed

github-actions · 2026-10-13T20:15:27Z

🚧 AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

melvin-bot · 2026-10-13T20:19:54Z

@AndrewGable looks like this was merged without a test passing. These checks had not passed on 253253c when it was merged:

ESLint check (failure)

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-10-13T20:21:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103929.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c456cd8-388c5ac-870f5d81dc9737f1d850da45436ab57fb306b296/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c456cd8-388c5ac-6358417681194e411000b157ac11055d99030592/index.html

Web 🕸️
https://103929.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

AndrewGable · 2026-10-13T20:21:28Z

Straight revert, no emergency.

…FieldsGridInlineEditing-restore Revert "Restore: Show up to three report fields per row and edit them inline" (cherry picked from commit c456cd8) (cherry-picked to staging by AndrewGable)

OSBotify · 2026-10-13T21:19:30Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.5.8-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-13T21:27:21Z

No help site update needed. This PR reverts Restore: Show up to three report fields per row and edit them inline, which never reached production, and no article in docs/articles describes the three-per-row layout or inline editing of report fields.

view run

OSBotify · 2026-10-14T13:01:01Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.8-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-10-14T13:21:10Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.5.9-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-14T13:25:42Z

No help site update needed. This PR and Restore: Show up to three report fields per row and edit them inline, the change it reverts, both reached production in the same release (9.5.8-5), so users never saw the change, and no article in docs/articles describes the three-per-row layout or inline editing of report fields.

view run

OSBotify · 2026-10-15T16:46:45Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.9-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Reverts the revert in Expensify#103929, putting back the changes from Expensify#102142 unchanged so the deploy blockers can be fixed one by one. Co-authored-by: daledah <daledah@users.noreply.github.com>

Revert "Restore: Show up to three report fields per row and edit them…

253253c

… inline"

AndrewGable self-assigned this Oct 13, 2026

AndrewGable requested review from a team as code owners October 13, 2026 17:40

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 13, 2026 17:40

melvin-bot Bot requested review from Gonals and removed request for a team October 13, 2026 17:40

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

joekaufmanexpensify removed their request for review October 13, 2026 18:19

neil-marcellini approved these changes Oct 13, 2026

View reviewed changes

AndrewGable merged commit c456cd8 into main Oct 13, 2026
46 of 50 checks passed

AndrewGable deleted the revert-102142-claude-reportFieldsGridInlineEditing-restore branch October 13, 2026 20:14

melvin-bot Bot added the Emergency label Oct 13, 2026

AndrewGable removed the Emergency label Oct 13, 2026

github-actions Bot mentioned this pull request Oct 13, 2026

Investigate workflow job failing on main: lint / ESLint check #103939

Closed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 13, 2026

OSBotify mentioned this pull request Oct 13, 2026

Deploy Checklist: New Expensify 2026-10-13 #103843

Closed

MelvinBot mentioned this pull request Oct 13, 2026

Clarify which transactions are deleted when removing or unassigning a card #103945

Open

38 tasks done

yuwenmemon mentioned this pull request Oct 13, 2026

[No QA] Fix ESLint and typecheck failures on main #103949

Merged

36 of 38 tasks

MelvinBot mentioned this pull request Oct 15, 2026

[$175] [CFI] Report Fields: Add up to 3 fields per row and add in-line editing #100259

Open

MelvinBot mentioned this pull request Oct 15, 2026

Restore: Show up to three report fields per row and edit them inline #104124

Merged

38 tasks done

MelvinBot mentioned this pull request Oct 20, 2026

Report field - System message shows "set text to """ after clearing text report field #104507

Open

3 of 7 tasks

	const isReportFieldDeletable = reportField.deletable && reportField?.fieldID !== CONST.REPORT_FIELD_TITLE_FIELD_ID;

	if (isReportFieldDeletable) {

Conversation

AndrewGable commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

melvin-bot Bot commented Oct 13, 2026

Uh oh!

codecov Bot commented Oct 13, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Oct 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

melvin-bot Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

AndrewGable commented Oct 13, 2026

Uh oh!

OSBotify commented Oct 13, 2026

Uh oh!

MelvinBot commented Oct 13, 2026

Uh oh!

OSBotify commented Oct 14, 2026

Uh oh!

OSBotify commented Oct 14, 2026

Uh oh!

MelvinBot commented Oct 14, 2026

Uh oh!

OSBotify commented Oct 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AndrewGable commented Oct 13, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 13, 2026 •

edited

Loading

codecov Bot commented Oct 13, 2026 •

edited by github-actions Bot

Loading