[Resizable columns] Absorb resize width in trailing columns by war-in · Pull Request #103186 · Expensify/App

war-in · 2026-10-06T13:37:07Z

Explanation of Change

Resizing a column now takes the width out of the resizable columns to its right instead of growing the row, so the table keeps its width. Absorbing columns shrink equally, never below their content width. Past that, the table scrolls. The drag and the stored widths go through the same resolver (resolveOverriddenColumnWidths), so columns don't jump on release.

Fixed Issues

$ #101331
PROPOSAL:

Tests

Important

Please clear onyx cache if you tested resizableTableColumns before, because the data structure changed

Preconditions: web, wide layout, resizableTableColumns beta enabled.

Go to Workspaces > pick a workspace > Members
Drag the right edge of the "Member" column to the right by ~100px, then release
Verify that the "Role" column narrows by the same amount while dragging, the row keeps the table's width, and no horizontal scrollbar appears
Keep dragging the "Member" edge to the right until "Role" reaches its content width
Verify that "Role" stops shrinking without truncating its text, and that the table starts scrolling horizontally from that point on
Release, then refresh the page
Verify that the column widths after the refresh match the ones at release, with no jump

Go to Workspaces > pick a workspace > Members
Drag the right edge of the "Member" column to the left by ~100px, then release
Verify that the "Role" column widens by the same amount while dragging, the row still fills the table width, and the caret column stays pinned to the right edge

Go to Workspaces > pick a workspace with taxes enabled and the "Tax code" column visible > Taxes
Drag the right edge of the "Name" column to the right by ~100px, then release
Verify that "Tax rate" and "Tax code" each narrow by about half of the drag
Drag the right edge of the "Tax rate" column to the right
Verify that "Name" keeps its width and only "Tax code" absorbs the change

Verify that no errors appear in the JS console

Offline tests

Go offline
Repeat the first test
Verify that resizing behaves the same, and the widths persist after refreshing the page (stored locally in Onyx, no API call)

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…mplement absorbed column resizing logic

…zable-table-columns-automatic-widths-on-right # Conflicts: # src/components/Table/columnResize/columnResizeGestures.ts # src/components/Table/columnResize/getResizableColumnLayout.ts # src/components/Table/columnResize/useColumnResize/index.ts

…ns` with `resizableColumnKeys` and `getResizedColumnWidths`; clean up related tests and types

codecov · 2026-10-06T14:33:08Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Table/Table.tsx	`92.45% <ø> (ø)`
...omponents/Table/columnResize/getColumnsWidthSum.ts	`100.00% <100.00%> (ø)`
...onents/Table/columnResize/getFrozenColumnWidths.ts	`100.00% <100.00%> (ø)`
...nts/Table/columnResize/getResizableColumnLayout.ts	`100.00% <100.00%> (ø)`
...s/Table/columnResize/resolveDraggedColumnWidths.ts	`100.00% <100.00%> (ø)`
...onents/Table/columnResize/useColumnResize/index.ts	`93.61% <100.00%> (+0.43%)`	⬆️
...columnResize/useStoredColumnWidths/index.native.ts	`100.00% <100.00%> (ø)`
src/components/Table/useDynamicColumnWidths.ts	`85.86% <100.00%> (+76.89%)`	⬆️
src/libs/actions/TableColumnWidths.ts	`100.00% <100.00%> (+100.00%)`	⬆️
src/selectors/TableColumnWidths.ts	`0.00% <ø> (-100.00%)`	⬇️
... and 2 more
... and 422 files with indirect coverage changes

…ble-columns-automatic-widths-on-right # Conflicts: # src/components/Table/columnResize/useColumnResize/index.ts

war-in · 2026-10-09T14:29:09Z

@codex review
@claude review
@MelvinBot review

chatgpt-codex-connector · 2026-10-09T14:29:37Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-12T11:45:48.961810Z	`0a32b50`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

MelvinBot · 2026-10-09T14:35:04Z

Review

I found one bug. When an earlier column has a stored width, starting a drag on a later column makes columns to its left jump.

Cause: resolveOverriddenColumnWidths.ts:57 excludes every overridden column from absorbing. Mid-drag, useColumnResize/index.ts:114 adds the dragged column to the overrides. That column stops absorbing the earlier override, so the earlier override's resize is redistributed among the remaining columns, including ones to the left of the dragged column.

Example: You have four 200px columns, a to d, in an 800px row, and a is stored at 260.

At rest, the columns are 260 / 180 / 180 / 180.
You start dragging c without moving it, which resolves {a: 260, c: 180}.
The columns become 260 / 170 / 180 / 190.

b shrinks 10px, so c's edge moves 10px away from the pointer on the first move. The release matches the drag, but the grab doesn't match the rest state. The test doesn't move anything when a column is stored at the width it's already painted at misses this because its third column has no room left.

Suggested fix: Drop columnWidthOverrides?.[column.key] === undefined from canColumnAbsorb. A later stored column still absorbs earlier overrides, then gets pinned to its stored width, and only its own delta moves on to the columns after it. Columns left of the dragged column then never depend on its width. By hand, the existing resolveOverriddenColumnWidths cases give the same results, including leaves a user-sized column alone ({260, 200, 140}). Please confirm by running the suite. A four-column regression test like the example above would cover this case.

Also checked, no issues

getAbsorbedColumnWidths: shares are whole px, they sum exactly, and an absorber that hits its minimum passes its share to the others.
The growable column's base includes floored leftover, so it absorbs from leftover first, and dragMinWidths still applies.
When you release, only the dragged column is stored, and clearLiveWidths clears every absorber's live width because they're all in liveWidthsRef.
The non-resizable fallback getResizedColumnWidths in useDynamicColumnWidths only returns the dragged column, which is fine.

view run

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0017576207

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ths-on-right

melvin-bot · 2026-10-12T11:28:08Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JS00001 · 2026-10-12T11:37:53Z

Looks like every CI check is failing haha @war-in

…ths-on-right

…tomatic-widths-on-right # Conflicts: # src/components/Table/columnResize/useColumnResize/types.ts # tests/unit/components/Table/useColumnResizeTest.ts

war-in · 2026-10-15T10:35:15Z

@Krishna2323 behaviour we agreed on here has been implemented

Could you re-review? 🙏

Krishna2323 · 2026-10-19T12:33:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web_chrome.mp4

Krishna2323

LGTM!

github-actions · 2026-10-20T11:13:31Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-20T11:17:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103186.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-fba2a68-bbab4b1-8432315c184aa40b79267d0ca033a50f991cd4b1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fba2a68-bbab4b1-45e51cb95c563f8e99b6436f5fd094828baf4389/index.html

Web 🕸️
https://103186.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-20T11:18:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-10-20T19:41:21Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.15-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-20T19:45:48Z

No help site update is needed: column resizing is still behind the resizableTableColumns beta, and this PR doesn't remove that beta or change anything a help article describes.

view run

lanitochka17 · 2026-10-20T20:24:07Z

Deploy Blocker #104506 was identified to be related to this PR.

lanitochka17 · 2026-10-20T20:36:24Z

Deploy Blocker #104508 was identified to be related to this PR.

OSBotify · 2026-10-21T19:30:11Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

war-in added 3 commits October 6, 2026 14:16

refactor: replace resizableColumnKeys with resizableColumns and i…

9b7bcff

…mplement absorbed column resizing logic

fix: make the last column shrink when dragging the previous column

acc0dd1

melvin-bot Bot assigned war-in Oct 6, 2026

war-in added 2 commits October 6, 2026 15:57

fix: rename and clean up code

73b9476

refactor: simplify column resizing logic by replacing `resizableColum…

0dc7ea6

…ns` with `resizableColumnKeys` and `getResizedColumnWidths`; clean up related tests and types

war-in mentioned this pull request Oct 7, 2026

[CFI] Allow table columns to be manually resized on web/desktop #101331

Open

war-in changed the title ~~[Resizable columns] Absorb resize width in trailing columns~~ [HOLD #102774][Resizable columns] Absorb resize width in trailing columns Oct 7, 2026

war-in mentioned this pull request Oct 7, 2026

[Resizable columns] Absorb resize width in trailing columns software-mansion-labs/expensify-app-fork#423

Closed

Krishna2323 mentioned this pull request Oct 8, 2026

feat: let the user resize table columns by dragging their edges #102774

Merged

43 tasks done

Merge remote-tracking branch 'upstream/main' into war-in/resizable-ta…

0017576

…ble-columns-automatic-widths-on-right # Conflicts: # src/components/Table/columnResize/useColumnResize/index.ts

war-in changed the title ~~[HOLD #102774][Resizable columns] Absorb resize width in trailing columns~~ [Resizable columns] Absorb resize width in trailing columns Oct 9, 2026

github-actions Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread src/components/Table/columnResize/getAbsorbedColumnWidths.ts Resolved

chatgpt-codex-connector Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread src/components/Table/columnResize/resolveOverriddenColumnWidths.ts Resolved

war-in added 2 commits October 12, 2026 12:49

Merge branch 'main' into war-in/resizable-table-columns-automatic-wid…

fdcbd4a

…ths-on-right

fix: drop the "not stored" check to fix UI jump

0a32b50

war-in marked this pull request as ready for review October 12, 2026 11:28

war-in requested review from a team as code owners October 12, 2026 11:28

melvin-bot Bot requested review from Krishna2323 and garrettmknight and removed request for a team October 12, 2026 11:28

JS00001 self-requested a review October 12, 2026 11:37

war-in added 6 commits October 13, 2026 14:21

Merge branch 'main' into war-in/resizable-table-columns-automatic-wid…

acc96cb

…ths-on-right

test: add user-resized columns test case

5d98846

refactor: freeze layout after the first drag

c2d7f93

test: improve tests

6aee9ea

test: improve tests

eb2a912

Merge branch 'refs/heads/main' into war-in/resizable-table-columns-au…

10011cd

…tomatic-widths-on-right # Conflicts: # src/components/Table/columnResize/useColumnResize/types.ts # tests/unit/components/Table/useColumnResizeTest.ts

MelvinBot mentioned this pull request Oct 15, 2026

Show approval workflow changes instead of a role change in the #admins log #103209

Merged

45 tasks done

chore: remove unused export

6aa43de

war-in mentioned this pull request Oct 15, 2026

Support pinning columns in the spend table #104080

Open

Krishna2323 reviewed Oct 15, 2026

View reviewed changes

Comment thread src/components/Table/columnResize/getFrozenColumnWidths.ts Resolved

Krishna2323 reviewed Oct 19, 2026

View reviewed changes

Comment thread src/components/Table/columnResize/getFrozenColumnWidths.ts Resolved

fix: let a drag use the leftover room a fixed-width last column fills

6cfb222

Krishna2323 approved these changes Oct 19, 2026

View reviewed changes

melvin-bot Bot requested a review from stitesExpensify October 19, 2026 13:47

JS00001 reviewed Oct 19, 2026

View reviewed changes

Comment thread src/libs/actions/TableColumnWidths.ts Resolved

JS00001 approved these changes Oct 20, 2026

View reviewed changes

JS00001 merged commit fba2a68 into Expensify:main Oct 20, 2026
37 of 42 checks passed

OSBotify mentioned this pull request Oct 20, 2026

Deploy Checklist: New Expensify 2026-10-20 #104495

Closed

81 tasks done

applause-bot Bot mentioned this pull request Oct 20, 2026

[Due for payment 2026-11-02] Workspace - "Find Member" input and "Filters" button are moved while resizing members table #104506

Open

1 of 7 tasks

applause-bot Bot mentioned this pull request Oct 20, 2026

Taxes - No action triggered while resizing "Tax Code" column to the left on "Taxes" table #104508

Closed

1 of 7 tasks

Conversation

war-in commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 6, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

war-in commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

Uh oh!

MelvinBot commented Oct 9, 2026

Review

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 12, 2026

Uh oh!

JS00001 commented Oct 12, 2026

Uh oh!

war-in commented Oct 15, 2026

Uh oh!

Uh oh!

Krishna2323 commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

MelvinBot commented Oct 20, 2026

Uh oh!

lanitochka17 commented Oct 20, 2026

Uh oh!

lanitochka17 commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

war-in commented Oct 6, 2026 •

edited

Loading

codecov Bot commented Oct 6, 2026 •

edited by github-actions Bot

Loading

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading

Krishna2323 commented Oct 19, 2026 •

edited

Loading