feat: let the user resize table columns by dragging their edges by war-in · Pull Request #102774 · Expensify/App

war-in · 2026-10-01T15:20:57Z

Explanation of Change

Adds web column resizing to Table via a new columnResizingID prop (needs shouldUseDynamicColumns and the resizableTableColumns beta), enabled on Workspace Members, Taxes, Expensify Cards and Company Cards. Dragging a column's edge updates CSS custom properties with no re-renders; on release the width is saved per device in the new tableColumnWidths Onyx key. No-op on native and narrow layout.

Fixed Issues

$ #101331
PROPOSAL:

Tests

On web (wide layout) with the resizableTableColumns beta enabled, go to Workspaces > pick a workspace > Members
Hover the right edge of the "Member" column header
Verify that the cursor changes to col-resize and no indicator line appears yet
Drag the edge right by ~150px, then release
Verify that the "Member" column widens while dragging, follows the pointer, and stays at the new width after release, and that a tall indicator line spans the table only while dragging
Verify that clicking or dragging the edge does not trigger sorting by "Member"
Drag the "Role" column edge far left
Verify that the column stops shrinking at a minimum width and its edge is still reachable
Refresh the page and open Members again
Verify that the dragged widths are restored

On web (wide layout), open the Members page of a workspace and widen the "Member" column
Open the Members page of a different workspace
Verify that the same "Member" width is applied (widths are shared per column set, not per workspace)
Drag the "Member" edge far right so the columns overflow the table
Verify that the table scrolls horizontally and the header stays aligned with the rows
Drag the "Member" edge back left until the columns fit the table again, then keep dragging the last labeled column's edge left
Verify that the last labeled column stops shrinking once the row fills the table, leaving no empty space at the row's end
Repeat a quick resize on the Taxes, Expensify Cards and Company Cards tables, and verify that each keeps its own widths

Disable the resizableTableColumns beta (or use an account without it) and open the Members page on web
Verify that no resize handles appear and the table renders as before
Resize the browser window to the narrow layout (or open mWeb / native) and open the Members page with the beta enabled
Verify that no resize handles or indicator lines appear and the list renders as before

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-10-02.at.15.48.33.mov

codecov · 2026-10-02T12:47:04Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.90% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/components/Table/Table.tsx	`92.45% <100.00%> (+0.72%)`	⬆️
src/components/Table/TableContext.tsx	`63.63% <ø> (ø)`
src/components/Table/TableRow.tsx	`87.40% <100.00%> (+0.30%)`	⬆️
src/components/Table/TableSemanticContainer.tsx	`100.00% <100.00%> (ø)`
src/components/Table/buildTableListData.ts	`100.00% <100.00%> (ø)`
...c/components/Table/calculateDynamicColumnWidths.ts	`100.00% <100.00%> (ø)`
...e/columnResize/ColumnResizeHandle/index.native.tsx	`100.00% <100.00%> (ø)`
...le/columnResize/ColumnResizeScope/index.native.tsx	`100.00% <100.00%> (ø)`
... and 27 more
... and 21 files with indirect coverage changes

war-in · 2026-10-02T13:45:41Z

@codex review
@claude review
@MelvinBot review

MelvinBot · 2026-10-02T13:52:29Z

The resize logic looks good. I found two things to fix before merge, plus a few smaller notes.

Should fix

The Members list remounts once on every page open. On the first render tableWidth is 0, so resizableColumnKeys is empty and useColumnResize returns undefined (useDynamicColumnWidths.ts:189, useColumnResize/index.ts:120). ColumnResizeScope then returns its children bare. After the first layout it wraps them in a <div> (ColumnResizeScope/index.tsx:10). The root element type changes, so React unmounts and remounts the header and the whole FlashList. That is costly for workspaces with many members. Fix: render the scope <div> whenever resizing is on. For example, return the controller as soon as columnResizingID is set, and have getHandleProps return undefined until the keys exist.
Possible header regression in the other dynamic tables. The list-header wrapper used to get width: scrollWidth explicitly. Now it doesn't, and the inner row only gets a width when rowWidth is set (TableHeader.tsx:220). Taxes, Company Cards and Expensify Cards use shouldUseDynamicColumns without columnResizingID, so they lose that width when their columns overflow. The comment you removed said the header background and bottom border fall short of the columns without it. Please check those tables in a narrow window. If the background or border falls short, keep getWidthStyle(scrollWidth) when scrollWidth is a number and rowWidth is unset.

Minor notes

Keyboard and screen-reader access: the handle only works with a pointer. It has no focus, role or value, so keyboard users can't resize columns. Consider role="separator", aria-orientation="vertical", tabIndex={0}, aria-valuenow, and ArrowLeft/ArrowRight steps. A follow-up is fine.
Cursor cleanup: useEffect(() => resetDrag, []) always clears document.body.style.cursor on unmount, even with no active drag (useColumnResize/index.ts:118). Only reset it when dragRef.current is set.
Last handle placement: the handle offset assumes the last column is always headless (useColumnResize/index.ts:135). getGrowableColumnKey supports a headed last column, so a future table that opts in could get a handle hanging past the row. Skip the handle on the final column, or document the requirement on columnResizingID.

view run

github-actions · 2026-10-02T14:16:45Z

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

# Conflicts: # src/components/Table/useDynamicColumnWidths.ts # src/libs/ExportOnyxState/masking.ts # tests/unit/useDynamicColumnWidthsTest.ts

war-in · 2026-10-09T09:33:06Z

When I open a table with saved column widths, it flickers. It first renders the default content-based widths, then jumps to the saved ones. This happens after a page refresh and also when I switch to another page and come back.

Monosnap.screencast.2026-10-08.23-20-25.mp4

@Krishna2323 fixed!

github-actions · 2026-10-09T10:32:23Z

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

Krishna2323 · 2026-10-09T10:56:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios_hybrid.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web_chrome.mp4

Krishna2323

LGTM!

The failing CI checks seem to be happening on main, so approving for the final round of review in the meantime.

JS00001 · 2026-10-09T11:22:23Z

Nice! Reviewing!

JS00001

This feels really great, few comments

war-in · 2026-10-09T13:20:39Z

@JS00001 review addressed!

JS00001

github-actions · 2026-10-09T13:24:48Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-09T13:28:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-09T13:29:01Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102774.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d1eff24-49dee98-cbd703b07b1eda3b0fc80d8bc157c769c300183d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d1eff24-49dee98-249f3b7e7305b3fae56d1a9af981b0b68bbbacc6/index.html

Web 🕸️
https://102774.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-09T20:49:13Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.7-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-09T20:54:27Z

No help site update is needed. Column resizing only turns on when the resizableTableColumns beta is enabled, so most users can't see it yet. The other changes don't affect what users see.

view run

OSBotify · 2026-10-13T09:59:42Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.5.7-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

feat: let the user resize table columns by dragging their edges

27928b1

melvin-bot Bot assigned war-in Oct 1, 2026

war-in added 6 commits October 1, 2026 17:37

chore: improve comments

1ca2910

fix: simplify code

67af793

fix: dont show the splitter on hover

54af672

test: export ONYXKEYS.TABLE_COLUMN_WIDTHS

b69e08a

fix: remove unnecessary prop

552f051

test: extract duplicated logic

1961c23

fix: typecheck

d0f45dd

war-in mentioned this pull request Oct 2, 2026

[CFI] Allow table columns to be manually resized on web/desktop #101331

Open

This comment has been minimized.

Sign in to view

fix: use CONST.TABLES.COLUMN_RESIZE directly

bcf8a8f

Krishna2323 self-requested a review October 5, 2026 20:23

war-in added 6 commits October 6, 2026 11:56

Merge branch 'main' into war-in/resizable-table-columns-basics

a84de72

# Conflicts: # src/components/Table/useDynamicColumnWidths.ts # src/libs/ExportOnyxState/masking.ts # tests/unit/useDynamicColumnWidthsTest.ts

refactor: remove unused code & cleanup

846bbc2

feat: add resizableTableColumns beta

8be1fbf

fix: put onyx keys in alphabetical order

71fe655

fix: block shrinking the last column when already at 100% width

a159dfd

test: improve tests

a1d6bce

war-in marked this pull request as ready for review October 6, 2026 12:49

war-in requested review from a team as code owners October 6, 2026 12:49

melvin-bot Bot requested review from JS00001, dylanexpensify and stitesExpensify October 6, 2026 12:49

fix: show the correct widths on first render

ce6e599

fix: review comments

f69826e

This comment has been minimized.

Sign in to view

Krishna2323 approved these changes Oct 9, 2026

View reviewed changes

melvin-bot Bot requested a review from stitesExpensify October 9, 2026 11:16

JakubKorytko mentioned this pull request Oct 9, 2026

Allow Apple Wallet retries after canceling Download Wallet Expensify/react-native-wallet#95

Merged

JS00001 requested changes Oct 9, 2026

View reviewed changes

Comment thread src/components/Table/Table.tsx Resolved

Comment thread src/components/Table/TableHeader.tsx Resolved

Comment thread src/components/Table/columnResize/useStoredColumnWidths/index.ts Resolved

Comment thread src/components/Table/columnResize/ColumnResizeHandle/index.tsx Resolved

war-in added 2 commits October 9, 2026 15:04

Merge branch 'main' into war-in/resizable-table-columns-basics

3c67c72

chore: improve comment

d7500bd

JS00001 approved these changes Oct 9, 2026

View reviewed changes

JS00001 merged commit d1eff24 into Expensify:main Oct 9, 2026
36 of 38 checks passed

OSBotify mentioned this pull request Oct 9, 2026

Deploy Checklist: New Expensify 2026-10-09 #103653

Closed

74 tasks done

MelvinBot mentioned this pull request Oct 12, 2026

Web - Report - Report table header is larger than rest of the table after merging reports. #103719

Open

1 of 7 tasks

This was referenced Oct 20, 2026

[Due for payment 2026-11-02] Workspace - "Find Member" input and "Filters" button are moved while resizing members table #104506

Open

Taxes - No action triggered while resizing "Tax Code" column to the left on "Taxes" table #104508

Closed

Conversation

war-in commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

war-in commented Oct 2, 2026

Uh oh!

MelvinBot commented Oct 2, 2026

Should fix

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

This comment has been minimized.

war-in commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

This comment has been minimized.

Krishna2323 commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Oct 9, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

war-in commented Oct 9, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

MelvinBot commented Oct 9, 2026

Uh oh!

OSBotify commented Oct 13, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

war-in commented Oct 1, 2026 •

edited

Loading

codecov Bot commented Oct 2, 2026 •

edited by github-actions Bot

Loading

Krishna2323 commented Oct 9, 2026 •

edited

Loading