Extract Report Details menu rows into self-subscribing components

[sosek108]

Explanation of Change

This moves the menu rows of the Report Details page out of the page into a new ReportDetailsMenuItems component and eight row components: GoToRoom, MembersOrInvite, Settings, PrivateNotes, MarkAsIncomplete, GoToWorkspace, Leave and Debug. A small useIsRoomCurrentlyOpen hook goes with them. Each row takes only reportID, opens its own Onyx subscriptions, decides on its own whether it is visible and renders MenuItem directly. There is no items array and no shared row wrapper, so a row only re-renders when the data it reads changes.

ReportDetailsMenuItems keeps the self DM and archived room checks that empty the menu. It still renders the four track expense rows inline, with their own subscriptions, until the last PR in the stack extracts them. ReportDetailsActions and ReportDetailsRequestActions now render ReportDetailsMenuItems directly, so the renderMenu render prop added in the previous PR is gone. The page itself drops from 19 to 2 useOnyx calls.

The row order does not change. I compared it against main for a self DM, an archived room, a group chat, an invite only room, a room that is open behind the page, a completed task and a track expense. A new unit test checks the order for each of these cases and checks that a chat opens no transaction subscription.

Deviations from the plan:

• The track expense subscriptions move in this PR, because issue [Performance] DynamicReportDetailsPage — PR 6: ReportDetailsMenuItems and the 15 menu-only subscriptions #102181 lists the menu only subscriptions here.
• The DynamicReportDetailsPageMenuItem type is removed because nothing uses it anymore.
• ReportDetailsActionsTest is updated for the removed renderMenu prop.
• The private notes fetch effect stays in the page.

Stack note: this is PR 6 of 8 in the DynamicReportDetailsPage decomposition (parent issue #102173).

Performance:

Fixed Issues

$ #102181
PROPOSAL:

Tests

1. Open a group chat, then open its Report details. Verify the same menu rows appear in the same order as on main, and each row navigates or acts as before
2. Open a workspace room, then open its Report details. Verify the same rows appear in the same order as on main, and Members, Settings, Private notes, Leave and Go to workspace behave as before
3. Open a workspace chat, then open its Report details. Verify the same rows appear in the same order as on main, and each row navigates or acts as before
4. Open a completed task, then open its Report details. Verify the Mark as incomplete row is shown where it was before and marks the task incomplete
5. Open your self DM, track an expense, then open the track expense Report details. Verify the track expense rows appear in the same order as on main and each one opens the same flow as before
6. Open an archived room, then open its Report details. Verify the menu shows the same rows as on main

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Nagranie.z.ekranu.2026-10-6.o.14.52.19.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-10-6.o.14.17.48.mov

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../DynamicReportDetailsPage/ReportDetailsActions.tsx	100.00% <100.00%> (ø)
...icReportDetailsPage/ReportDetailsMenuDebugItem.tsx	100.00% <100.00%> (ø)
...eportDetailsPage/ReportDetailsMenuGoToRoomItem.tsx	100.00% <100.00%> (ø)
...ailsPage/ReportDetailsMenuMarkAsIncompleteItem.tsx	100.00% <100.00%> (ø)
...cReportDetailsPage/ReportDetailsRequestActions.tsx	100.00% <100.00%> (ø)
src/pages/DynamicReportDetailsPage/index.tsx	80.00% <100.00%> (+1.69%)	⬆️
src/pages/DynamicReportDetailsPage/types.ts	100.00% <ø> (ø)
...eportDetailsPage/ReportDetailsMenuSettingsItem.tsx	92.30% <92.30%> (ø)
...cReportDetailsPage/hooks/useIsRoomCurrentlyOpen.ts	75.00% <75.00%> (ø)
...tailsPage/ReportDetailsMenuMembersOrInviteItem.tsx	95.34% <95.34%> (ø)
... and 4 more
... and 8 files with indirect coverage changes

[sosek108]

@MelvinBot review

[MelvinBot]

Review: no blocking issues ✅

I compared every extracted row with the getMenuItems code it replaces. Each row keeps the same visibility condition, onPress handler, and MenuItem props. The render order matches the old push order, including Members/Invite, Go to room/Go to workspace, and the track expense block after Settings. Each row now gets policy and reportMetadata from its own useOnyx. These use the same keys withReportOrNotFound used, so the data is unchanged. CI is green except for the checklist and approval checks.

Non-blocking notes

1. The chat menu still subscribes to transaction drafts. ReportDetailsMenuItems.tsx:69 subscribes to the whole transactionsDraft_ collection, plus the two policy_ collection selectors, for every case. That includes chats, rooms, tasks, and self DMs that return null at line 86. This isn't a regression, because the page already had these subscriptions, and PR 8 moves them out.
2. The subscription test misses that collection. The test at ReportDetailsMenuItemsTest.tsx:171 checks startsWith('transactions_'), which doesn't match transactionsDraft_. The test passes, but it doesn't prove the chat menu has no transaction-related subscriptions. You could tighten it in PR 8, once the track rows are extracted.
3. Each useIsRoomCurrentlyOpen call takes its own snapshot. Go to room and Go to workspace both call the hook. Each call keeps its own state, but both compute it the same way at the same time, so the two rows stay consistent. A comment saying the two rows depend on matching snapshots would help keep it that way.

What I checked

• Hooks run before every early return in all new components, so the rules of hooks hold.
• useDynamicBackPath(..., shouldShowMarkAsIncomplete) uses the existing isEnabled parameter. It skips the navigation-state work when the row is hidden, and the row returns null before it uses the path.
• Rows have no React.memo, but the React Compiler is enabled in babel.config.js. It memoizes <Row reportID={reportID} />, so a re-render of ReportDetailsMenuItems shouldn't cascade into the rows.
• Removing the renderMenu prop from ReportDetailsActions and ReportDetailsRequestActions keeps the menu in the same position as before, both for CASES.DEFAULT and for the money cases.

---

view run

[melvin-bot]

@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[sosek108]

About Melvin's review: nothing blocking so I will not change anything.

1 and 2 will be handled in PR 8 once the track rows are extracted and the draft subscription moves with them.
3 - I'd skip this. It is not any kind of hack or strange pattern.

[nkdengineer]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-10-07.at.00.09.40.mov

Android: mWeb Chrome

Screen.Recording.2026-10-07.at.00.00.37.mov

iOS: HybridApp

Screen.Recording.2026-10-07.at.00.09.19.mov

iOS: mWeb Safari

Screen.Recording.2026-10-07.at.00.01.04.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-06.at.23.52.33.mov

Screen.Recording.2026-10-06.at.23.53.18.mov

Screen.Recording.2026-10-06.at.23.53.44.mov

Screen.Recording.2026-10-06.at.23.54.25.mov

Screen.Recording.2026-10-06.at.23.55.13.mov

Screen.Recording.2026-10-06.at.23.56.11.mov

[nkdengineer]

LGTM!

[trjExpensify]

PR doesn’t need product input as a performance refactor PR. Unassigning and unsubscribing myself.

[github-actions]

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102988.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f63f8dc-82e2701-409fa2374d39bfb9dfa5df06f1f5a7ad865d396a/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://102988.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.5.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

No help site update needed. This PR refactors the Report details menu into separate components without changing any row labels, order, visibility rules, or behavior, so no help article sentence becomes incorrect.

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.5-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS