Skip to content

Gate Report Details request data behind ReportDetailsActions - #102749

Merged
mjasikowski merged 6 commits into
Expensify:mainfrom
callstack-internal:refactor/rd-05-actions-request
Oct 6, 2026
Merged

mjasikowski merged 6 commits into
Expensify:mainfrom
callstack-internal:refactor/rd-05-actions-request

Conversation

@sosek108

@sosek108 sosek108 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This moves the action area at the bottom of the Report Details page (the menu rows and the Delete row) behind a new ReportDetailsActions component. It takes only reportID, reads the report itself, works out which case the page is in and mounts different children per case.

For money requests, expense reports, invoices and track expense reports it renders ReportDetailsRequestActions. That component is now the only place that calls the new useReportDetailsRequestData hook, which holds the money request derivations the page used to compute for every report: the IOU report and transaction, the duplicate transactions, the delete options and the title of the Delete row. For chats, rooms and tasks it renders the new ReportDetailsTaskDeleteAction instead, which shows the task Delete row and runs the task delete. So a chat or a room no longer mounts any of the money request subscriptions. A track expense report still mounts them, as it did before, because its menu rows need that data.

The menu rows themselves are not extracted yet. ReportDetailsActions gets them from the page through a render prop and passes the request data in for the money cases only. The next PR in the stack replaces that render prop with its own menu component. useAncestors moves into the task delete component because the task delete is its only user. That component reads its own report, parent report, parent report action, report actions, Concierge report ID, guide account IDs and delegate email. The money delete flow and its confirm modal stay in the page until PR 7.

This should not change behaviour. A new unit test checks that a chat room does not mount the request data subscriptions and an expense report does.

Stack note: this is PR 5 of 8 in the DynamicReportDetailsPage decomposition (parent issue #102173).

Zrzut ekranu 2026-10-5 o 13 56 58

Fixed Issues

$ #102180
PROPOSAL:

Tests

  1. Open a workspace chat room, then open its Report details. Verify the menu rows look and behave as on prod and no Delete row is shown
  2. Open a task you can modify, then open its Report details. Verify the Delete row is shown, tap it, confirm, and verify the task is deleted and you are navigated back as on prod
  3. Open an expense report, then open its Report details. Verify the menu rows and the Delete row look and behave as on prod
  4. Open a money request (an expense in an expense report), then open its Report details. Tap Delete, confirm, and verify the expense is deleted and you are navigated back as on prod
  5. Open a split expense, then open its Report details. Verify the Delete row shows the split edit title and icon and opens the split edit flow as on prod
  6. Open an invoice, then open its Report details. Verify the menu rows look and behave as on prod
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Nagranie.z.ekranu.2026-10-5.o.09.57.59.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-10-5.o.09.53.42.mov

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
.../DynamicReportDetailsPage/ReportDetailsActions.tsx 100.00% <100.00%> (ø)
...cReportDetailsPage/ReportDetailsRequestActions.tsx 100.00% <100.00%> (ø)
...eportDetailsPage/ReportDetailsTaskDeleteAction.tsx 100.00% <100.00%> (ø)
src/pages/DynamicReportDetailsPage/index.tsx 78.30% <100.00%> (-2.41%) ⬇️
src/pages/DynamicReportDetailsPage/types.ts 100.00% <ø> (ø)
...icReportDetailsPage/useReportDetailsRequestData.ts 100.00% <100.00%> (ø)
... and 16 files with indirect coverage changes

@sosek108

sosek108 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

Review

I found no behavior regressions. The refactor matches main for every case I traced. I have one cleanup suggestion. CI is green apart from the checklist and approval checks.

Suggestion: remove the dead task logic from useReportDetailsRequestData

The hook only mounts for money cases, so the task branches can never be true:

The task logic now lives in ReportDetailsTaskDeleteAction. If you remove these branches, also drop the test that covers the unreachable path: useReportDetailsRequestDataTest.tsx:176 ("plain delete for a non-money report").

What I checked
  • Hidden Delete row in the default case: Before this PR, a chat or room could show the money Delete row only if canDeleteTransaction(report) returned true. That needs a money request report or an invoice (ReportUtils.ts:3045), so skipping the request data there removes nothing.
  • Task delete navigation: navigateToTargetUrl(undefined) now passes undefined for the transaction ID and child report. The old code also had no transaction ID for tasks, and getNavigationUrlOnMoneyRequestDelete returns early without one (DeleteMoneyRequest.ts:360). Both versions end in dismissModal.
  • Policy passed to useDeleteTransactions: The hook reads POLICY${report.policyID}, the same key withReportOrNotFound used for the old policy prop.
  • Track expense rows: These now need requestData. Track expense reports always resolve to MONEY_REQUEST, so they still get it.
  • Split edit and confirm flow: These run the same branches as before, with values captured when the row is pressed.

view run

@sosek108
sosek108 marked this pull request as ready for review October 5, 2026 08:00
@sosek108
sosek108 requested review from a team as code owners October 5, 2026 08:00
@melvin-bot
melvin-bot Bot requested review from garrettmknight and nkdengineer and removed request for a team October 5, 2026 08:00
@melvin-bot

melvin-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread src/pages/DynamicReportDetailsPage/ReportDetailsActions.tsx
@nkdengineer

nkdengineer commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-10-06.at.00.41.30.mov
Android: mWeb Chrome
Screen.Recording.2026-10-06.at.00.43.57.mov
iOS: HybridApp
Screen.Recording.2026-10-06.at.00.42.00.mov
iOS: mWeb Safari
Screen.Recording.2026-10-06.at.00.43.26.mov
MacOS: Chrome / Safari
Screen.Recording.2026-10-06.at.00.37.22.mov
Screen.Recording.2026-10-06.at.00.37.34.mov
Screen.Recording.2026-10-06.at.00.37.51.mov
Screen.Recording.2026-10-06.at.00.38.25.mov
Screen.Recording.2026-10-06.at.00.38.55.mov
Screen.Recording.2026-10-06.at.00.40.49.mov

@nkdengineer

Copy link
Copy Markdown
Contributor

@sosek108 Please resolve conflicts.

@sosek108

sosek108 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

@nkdengineer resolved

@nkdengineer nkdengineer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and test well.

@melvin-bot
melvin-bot Bot requested a review from mjasikowski October 6, 2026 07:25
@mjasikowski
mjasikowski merged commit 9f58921 into Expensify:main Oct 6, 2026
35 of 37 checks passed
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 6, 2026
100 tasks done
@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.5.4-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR is an internal refactor of the Report Details page. It moves the action rows into new components without changing any labels, steps, or behavior users see.


view run

@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants