Skip to content

[CP Staging] Revert "Open a deep link captured before onboarding instead of dropping it" - #102979

Merged
mountiny merged 1 commit into
mainfrom
revert-101558-fix/99940
Oct 5, 2026
Merged

mountiny merged 1 commit into
mainfrom
revert-101558-fix/99940

Conversation

@mountiny

@mountiny mountiny commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Reverts #101558

### Fixed issues

$ #102954

@mountiny mountiny self-assigned this Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/navigateAfterOnboarding.ts 89.28% <ø> (-1.13%) ⬇️
src/libs/actions/Link.ts 58.30% <35.29%> (+2.35%) ⬆️
... and 17 files with indirect coverage changes

@github-actions

This comment has been minimized.

@mountiny

mountiny commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Fixed on this build #102954 (comment)

@mountiny
mountiny marked this pull request as ready for review October 5, 2026 12:49
@mountiny
mountiny requested review from a team as code owners October 5, 2026 12:49
@melvin-bot
melvin-bot Bot requested review from chuckdries and garrettmknight and removed request for a team October 5, 2026 12:49
@melvin-bot

melvin-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
mountiny merged commit 1bf848f into main Oct 5, 2026
49 of 50 checks passed
@mountiny
mountiny deleted the revert-101558-fix/99940 branch October 5, 2026 12:59
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify pushed a commit that referenced this pull request Oct 5, 2026
[CP Staging] Revert "Open a deep link captured before onboarding instead of dropping it"

(cherry picked from commit 1bf848f)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 5, 2026
@OSBotify OSBotify mentioned this pull request Oct 5, 2026
59 tasks done
@os-botify

os-botify Bot commented Oct 5, 2026

Copy link
Copy Markdown

🔁 Filed a Staging retest request for deploy blockers #102954 after this PR was cherry-picked to staging.

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.5.2-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR reverts how the app handles a link opened before onboarding finishes, which is internal navigation behavior that no help article describes.


view run

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.2-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.5.3-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR reverts internal deep-link handling during onboarding, and no article in docs/articles describes where a link opens after onboarding, so no existing sentence becomes incorrect.


view run

@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.3-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants