Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Reviewing ASAP. Thanks. |
|
Thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-07.at.10.56.08.moviOS: HybridAppScreen.Recording.2026-10-07.at.11.09.58.mov |
mountiny
left a comment
There was a problem hiding this comment.
Thank you. Looks good to me. I don't want to hold on the test comments. Can you please address those in a follow-up no-QA PR, please?
There was a problem hiding this comment.
All the tests should follow the given-when-then comment structure.
There was a problem hiding this comment.
Thanks for review!
Here is the follow up PR -> #103442
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.6-0 🚀
|
|
No help site update is needed: this PR extends the existing Try again option to receipts that fail when added to an existing expense, which is a retry fix for an uncommon failure case, and it doesn't make any sentence in the help articles incorrect. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Follow-up to #99902. That PR added Try again to the receipt error row, but only for a failed
RequestMoney. Adding a receipt to an existing expense goes throughReplaceReceipt, so when that upload failed the row showed Save alone.This PR adds Try again for a failed
ReplaceReceipt. It reloads the receipt fromReceiptStorageand callsreplaceReceiptagain for the same transaction. Replace only updates an existing expense, so a retry can't create a duplicate.Fixed Issues
$ #102494
PROPOSAL:
Tests
On iOS and Android:
Offline tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOSReplaceReceipt.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari