Repository navigation
[Due for payment 2026-10-16] Android & iOS - Expense - Retry button is not shown when uploading receipt fails #102494
Description
Activity
- addedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deployment
on Sep 29, 2026 While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/b2fed4a385aabadf15907e78f354fdbba0f5b5a9e3edb7736313858fc22df01c- addedBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.
on Sep 29, 2026 You have been assigned to this deploy blocker because you recently merged this PR: #99902
github-actions commented
on Sep 29, 2026 on Sep 29, 2026 – with GitHub ActionsContributorMore actions👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
💬 A slack conversation has been started in #expensify-open-source
Deploy Blocker Analysis
Recommendation: demote. This is not a regression. Retry is a new feature from Add retry button and logic. That PR supports Retry only when creating a new expense fails. It deliberately leaves out adding or replacing a receipt on an existing expense, which is the flow in this issue. Reverting would also remove Retry from the new-expense flow, which works.
Why the button is missing: Adding a receipt to an existing expense calls
replaceReceipt. When that upload fails, the error is taggedREPLACE_RECEIPT(Receipt.ts:292).canBuildRetryPayloadreturnsfalsefor any action exceptMONEY_REQUEST. So the view passes no retry handler (MoneyRequestReceiptView.tsx:718) and shows only the Save option.Investigation details
- The limit is documented. The feature issue, Add a "Retry" button for a failed receipt upload, says: "Scoped to
RequestMoneyon a plain receipt expense;ReplaceReceiptandTrackExpensecan follow up." A unit test asserts it: ReceiptUploadRetryHandlerTest.ts:109. - Why only Android and iOS: Retry is native-only in every flow. isRetrySupported.ts:2 is
falseon web, so testers expected the button only on native. - No other PR is involved. Among the 71 PRs in Deploy Checklist: New Expensify 2026-09-28, only PR Add retry button and logic #99902 touches this code.
- Impact: The failed-upload message still makes sense on its own ("Upload failed. Save your receipt to keep it."). The user can save the receipt, and the expense keeps its previous receipt (Receipt.ts:291). The one change for this flow is that the PR removed "Delete expense" from the error row.
- Follow-up (not needed for this deploy):
replaceReceiptalready storesretryParamsin the error. To add Retry here, allowREPLACE_RECEIPTincanBuildRetryPayloadandretryReceiptUpload, reload the file fromReceiptStorage, and callreplaceReceiptagain. Then update the test at line 109. - I did not test this in the app. The bug only happens on native, and Retry is turned off on web.
Next Steps: An internal engineer should remove
DeployBlockerCashif they agree. Track theReplaceReceiptfollow-up on the feature issue linked above.
- The limit is documented. The feature issue, Add a "Retry" button for a failed receipt upload, says: "Scoped to
6 remaining items
Thanks @BartekObudzinski for checking it! I am back from OOO, I can help with that
Reacted by Bruno RochaThanks! Welcome back
Reacted by Tomasz Lesniakiewicz- addedReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2and removedDailyKSv2KSv2
on Oct 2, 2026 I've split this into two parts:
-
ReplaceReceipt fixes the case reported here. The Try again button now appears next to Save on both iOS and Android in the replace flow. Pressing it re-uploads the receipt to the same expense
PR: Show Try again when replacing a receipt fails #102893 is ready for review @brunovjk -
TrackExpense will come in a separate follow-up PR, I will open that PR next.
Reacted by Bruno Rocha-
Great, thank you!
- addedDailyKSv2KSv2and removedReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
on Oct 9, 2026 - changed the title
[-]Android & iOS - Expense - Retry button is not shown when uploading receipt fails[/-][+][Due for payment 2026-10-16] Android & iOS - Expense - Retry button is not shown when uploading receipt fails[/+]on Oct 9, 2026 The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Metadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsNo status
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.4.95-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #99902
Email or phone of affected tester (no customers): jsdoijnodsdisojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 17 Pro Max / iOS 27.0
App Component: Money Requests
Action Performed:
Expected Result:
Retry button will be shown when uploading receipt fails.
Actual Result:
Retry button is not shown when uploading receipt fails.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug7272007_1790634353574.ScreenRecording_09-29-2026_06-22-15_1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @brunovjk