Repository navigation
Expense - Scan confirm page receipt has 8px gap above first field instead of 16px - #102640
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-09-30.at.19.52.02.mov |
ikevin127
left a comment
There was a problem hiding this comment.
Thanks for the fix, the 16px gap looks right. Requesting changes for one thing (comment below): the isCompactMode ternary remounts ReceiptSection every time compact mode flips (Show more, forced show more on field errors, rotation).
That reloads the receipt and parses PDFs again, which wasn't happening before this PR. React Compiler doesn't prevent it. Wrapping it in a View with styles.dContents / styles.mv2 fixes it in one line, so please check the compact layout on iOS and Android after the change.
|
@ikevin127 I pushed the fix
|
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - Tests well, comment addressed - thanks!
I also added a quick fix for attendee gap issue here https://expensify.slack.com/archives/C049HHMV9SM/p1790822826668199 |
|
🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.1-0 🚀
|
|
No help site update is needed: this PR only adjusts spacing around the receipt and date field on the Scan confirmation page, so no article sentence becomes incorrect. |
|
Deploy Blocker #102855 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.1-9 🚀
Bundle Size Analysis (Sentry): |



Explanation of Change
Fixed Issues
$ #102586
PROPOSAL:
Tests
The receipt sits 16px above the first field, the same as on the Manual, Time, and Distance (manual and odometer) forms.
Offline tests
QA Steps
The receipt sits 16px above the first field, the same as on the Manual, Time, and Distance (manual and odometer) forms.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari