Skip to content

[Due for payment 2026-10-28] [$175] There's an uneven spacing between the date and report field in the Create expense flow #102791

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.0-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create workspace
  3. Click + Create expense > manual

Expected Result:

Space between the date and report field in the Create expense flow should be 16px instead of 24px

Actual Result:

Space between the date and report field in the Create expense flow is 24px

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 1, 2026
  2. MelvinBot commented on Oct 1, 2026

    @MelvinBot
    Contributor

    Proposal

    This is already fixed on main. Expense - Scan confirm page receipt has 8px gap above first field instead of 16px removed the extra 8px. It merged today (2026-10-01 15:42 UTC) but hasn't shown up on staging yet. Retest after the next staging deploy, then close this issue if the gap is 16px.

    What is the root cause of that problem?

    Each field box has 8px of margin above and below it. Two neighbors add up to 16px. The Date field's wrapper added an extra 8px bottom margin (mb2) on top of the 8px it already had from DatePicker. So the gap was 8 + 8 + 8 = 24px.

    Code references

    How it happened:

    1. Make Date field inline in the new manual expense flow changed the Date wrapper from mv2 to mb2. At that time, the rows after Date had no margin, so the mb2 was needed.
    2. [CFI] Update the Manual create expense form to use dropdown-style rows and a compact add-receipt button turned Report into a bordered row with its own mv2. That made the margins stack into 24px.

    What changes do you think we should make in order to solve the problem?

    None. The fix PR changed the Date wrapper to mh4 only. You can see that at DateField.tsx:134 on main. The change is in DateField itself, so it also covers Distance and the other flows that use it.

    I couldn't check the new spacing on a local web build because the test browser session failed to load. The conclusion is based on the code and the merged diff.

    Related: Expense - Scan confirm page receipt has 8px gap above first field instead of 16px is the issue that PR fixed.


    Next Steps for Contributor+ team:
    To accept: Retest on staging after the fix PR deploys, then close this issue.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 1, 2026
  4. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)

  5. changed the title [-]There's an uneven spacing between the date and report field in the Create expense flow[/-] [+][$175] There's an uneven spacing between the date and report field in the Create expense flow[/+] on Oct 1, 2026
  6. melvin-bot commented on Oct 1, 2026

    @melvin-bot
  7. jawad-erfani commented on Oct 2, 2026

    @jawad-erfani

    @truph01, I’m unable to reproduce the issue, and it appears to have been fixed by this PR: #102640

    Image
  8. dubielzyk-expensify commented on Oct 4, 2026

    @dubielzyk-expensify
    Contributor

    I can still see it on staging:

    Image

    Can you try it on a workspace with tags and attendees tracking turned to on to see if you can reproduce it?

  9. jawad-erfani commented on Oct 5, 2026

    @jawad-erfani

    Hi @dubielzyk-expensify , this issue is happening because PR #102640 was reverted.

    @dubielzyk-expensify, @truph01 , the root cause in the current code is the extra styles.mb2 margin on the editable Date field.

    The Date field currently has an 8px bottom margin:

    <View style={[styles.mh4, styles.mb2]}>

    The Report field already has its own 8px top margin. These margins combine and create a 24px gap, while the expected spacing is 16px.

    update it to:

    <View style={styles.mh4}>

    This removes the extra 8px margin and fixes the uneven spacing between the Date and Report fields.
    If you would like, I can open a PR or submit the proposal to fix this.
    Thanks!

  10. dubielzyk-expensify commented on Oct 5, 2026

    @dubielzyk-expensify
    Contributor

    I'll let @truph01 handle the code and proposal side 👍

  11. jawad-erfani commented on Oct 5, 2026

    @jawad-erfani

    I'll let @truph01 handle the code and proposal side 👍

    Thanks, @dubielzyk-expensify.

    @truph01, I have all the required devices ready to test this change according to the PR checklist. I can verify the fix across Android, iOS, and web, and open the PR as soon as the issue is assigned to me.

    Please share your thoughts. If you consider this solution valid, I can open the PR for it. Thanks!

    Screen.Recording.2026-10-05.at.2.38.19.PM.mov
    Screen.Recording.2026-10-05.at.2.40.54.PM.mov
  12. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    @truph01 Eep! 4 days overdue now. Issues have feelings too...

  13. 14 remaining items

  14. truph01 commented on Oct 23, 2026

    @truph01
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Go to ND
    2. Click + Create expense > manual
    3. Verify: Space between the date and report field in the Create expense flow should be 16px instead of 24px

    Do we agree 👍 or 👎

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 23, 2026
  16. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  17. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  18. mallenexpensify commented on Oct 30, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @truph01 due $175 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions