Repository navigation
[No QA] Docs updates for E/A#102242 Add Tag column to personal card spreadsheet import - #102465
Conversation
Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
MelvinBot
added
the
HelpDot
|
@MelvinBot Check all checkboxes on the PR Author Checklist including the two |
|
Done. I checked every box in the PR Author Checklist, plus both |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@ikevin127 @twisterdotcom One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| Add a column with the tag for each transaction to your spreadsheet, then map it to **Tag** when you map your columns. Columns with the header Tag, Tags, Label, or Labels are mapped to **Tag** automatically. | ||
|
|
||
| Expensify doesn't check imported tags against a workspace's tag list, so review each tag before you submit the expense. |
There was a problem hiding this comment.
Terminology / capitalization: Use "Workspace" (capitalized) as the feature name, not "workspace" — the naming conventions and authoring guidelines treat Workspace as a proper feature noun (e.g., ## Where to enable ACH reimbursements in a Workspace). Suggested: "against a Workspace's tag list".
| - Amount | ||
| - Merchant | ||
|
|
||
| You can also map optional **Category** and **Tag** columns. |
There was a problem hiding this comment.
Scope / metadata (AI readiness): This change adds a new capability (importing tags and categories) to the article. Per HELP_AUTHORING_GUIDELINES.md Section 3, the internalScope metadata (line 5) explicitly states it "Does not cover company cards or Plaid connections" but says nothing about tags/categories. Update internalScope and consider whether the description should mention that categories/tags can be imported, so metadata reflects real search intent and the added workflow.
|
|
||
| ## How do I import tags with personal card transactions? | ||
|
|
||
| Add a column with the tag for each transaction to your spreadsheet, then map it to **Tag** when you map your columns. Columns with the header Tag, Tags, Label, or Labels are mapped to **Tag** automatically. |
There was a problem hiding this comment.
Readability / consistency: The recognized header values (Tag, Tags, Label, Labels) are run into the sentence unformatted, while UI field names elsewhere in this article are bolded (e.g., Tag, Date, Merchant). For scannability and deterministic writing, format these literal values consistently — for example: "Columns with the header Tag, Tags, Label, or Labels...".
HelpDot Documentation ReviewOverall Assessment This PR extends an existing, well-structured article to document the optional Category and Tag column mapping for personal card spreadsheet imports. The changes add an optional step to the primary workflow, a note in the post-import section, two new FAQ entries, and expanded keywords. All additions are consistent with the existing structure and stay within the single workflow (spreadsheet import). Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review reflects only the changes proposed in the diff. |
Reviewer Checklist
|
|
@MelvinBot Address the 3 code-comments from |
Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
|
I addressed all 3
No local tests apply to a Markdown-only change. The docs CI checks will validate it. |
github-actions
Bot
changed the title
|
A preview of your ExpensifyHelp changes have been deployed to https://06de936f.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.4.96-0 🚀
|
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.4.99-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Allow mapping a Tag column in the personal card CSV transaction import added a Tag option to the column mapping step of the personal card spreadsheet import (Wallet > Import transactions). It also auto-maps Tag, Tags, Label, and Labels headers to Tag, and blocks the import with an error when a tag is longer than 255 characters.
The help article only listed the required Date, Merchant, and Amount columns, so members had no way to learn they can import categories and tags. This PR updates Import Personal Card Transactions From a Spreadsheet to:
UI labels (Category, Tag, Date, Merchant, Amount, Import) were checked against the
en.tsstrings andTransactionsImportedPage.tsxonmain. No other article documents the personal card import column mapping, so no other files need changes.@ikevin127, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #102232
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari