Repository navigation
Conversation
…n when copying settings Co-authored-by: daledah <daledah@users.noreply.github.com>
27 of 40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://e766e4b9.helpdot.pages.dev ⚡️ Updated articles: |
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Feel free to reopen if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Show the Upgrade step when copying rules to a Collect workspace, which changed user-visible behavior in the Copy settings flow.
Before that PR, selecting Rules or Merchant rules with a Collect destination workspace skipped the Upgrade step, fired the copy, and failed. Now the Some features require a Control plan page is shown first and nothing is copied until the destination workspaces are upgraded.
Copy-Workspace-Settings.mdonly said "some settings require the destination workspaces to be on the Control plan" without naming any, and its numbered steps went straight from Select settings to the summary, so a reader hitting the upgrade prompt had nothing to match it against.This PR updates
docs/articles/new-expensify/workspaces/Copy-Workspace-Settings.mdonly:Label verification
Every UI label used in the article was checked against the current app rather than written from memory:
workspace.common.rulesinsrc/languages/en.tsworkspace.duplicateWorkspace.merchantRulesinsrc/languages/en.tsworkspace.copyPolicySettings.upgrade.titleinsrc/languages/en.tscommon.upgrade/common.continue, as used byCopyPolicySettingsUpgradePage.tsxworkspace.common.moreFeaturesinsrc/languages/en.tsThe Rules and Merchant rules rows could not be exercised in the live session because the test account has no Control workspace with rules enabled, so those two labels were confirmed from the translation source instead.
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: the article keeps a single#heading plus# FAQ, uses only##sections, bolds every UI label in sentence case, adds no new cross-links, and adds no screenshots.Fixed Issues
$
PROPOSAL:
Docs-only follow-up. The code change is already merged in Show the Upgrade step when copying rules to a Collect workspace, which $ Auto - Workspace - Unable to "Copy settings" from Control to Collect workspace, so no issue is linked here.
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
This PR changes one Markdown file under
docs/articlesand no app code, so there is nothing to exercise in the app. Reviewing the rendered article is the test.Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
Docs-only change with no app code touched.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@daledah, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.