Skip to content

[No QA] Docs updates for E/A#101710 Rules copy requires a Control destination workspace - #102160

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-copy-settings-rules-upgrade
Closed

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-copy-settings-rules-upgrade

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for Show the Upgrade step when copying rules to a Collect workspace, which changed user-visible behavior in the Copy settings flow.

Before that PR, selecting Rules or Merchant rules with a Collect destination workspace skipped the Upgrade step, fired the copy, and failed. Now the Some features require a Control plan page is shown first and nothing is copied until the destination workspaces are upgraded.

Copy-Workspace-Settings.md only said "some settings require the destination workspaces to be on the Control plan" without naming any, and its numbered steps went straight from Select settings to the summary, so a reader hitting the upgrade prompt had nothing to match it against.

This PR updates docs/articles/new-expensify/workspaces/Copy-Workspace-Settings.md only:

  • Names Rules and Merchant rules as the settings that require a Control destination workspace, and notes the distinction that a Collect workspace can still turn Rules on by itself.
  • Adds the Some features require a Control plan page as step 5 of How to copy workspace settings, so the numbered steps match the real flow.
  • Names Rules and Merchant rules in the existing "Why can't I copy certain settings?" FAQ.
  • Adds a "Why am I asked to upgrade when I copy Rules or Merchant rules?" FAQ.
Label verification

Every UI label used in the article was checked against the current app rather than written from memory:

Label Verified against
Copy settings, Select workspaces, Select settings Live web build — confirmed in the running app
Rules workspace.common.rules in src/languages/en.ts
Merchant rules workspace.duplicateWorkspace.merchantRules in src/languages/en.ts
Some features require a Control plan workspace.copyPolicySettings.upgrade.title in src/languages/en.ts
Upgrade, Continue common.upgrade / common.continue, as used by CopyPolicySettingsUpgradePage.tsx
More features workspace.common.moreFeatures in src/languages/en.ts

The Rules and Merchant rules rows could not be exercised in the live session because the test account has no Control workspace with rules enabled, so those two labels were confirmed from the translation source instead.

Written against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: the article keeps a single # heading plus # FAQ, uses only ## sections, bolds every UI label in sentence case, adds no new cross-links, and adds no screenshots.

Fixed Issues

$
PROPOSAL:

Docs-only follow-up. The code change is already merged in Show the Upgrade step when copying rules to a Collect workspace, which $ Auto - Workspace - Unable to "Copy settings" from Control to Collect workspace, so no issue is linked here.

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

This PR changes one Markdown file under docs/articles and no app code, so there is nothing to exercise in the app. Reviewing the rendered article is the test.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
// The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

Docs-only change with no app code touched.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@daledah, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…n when copying settings

Co-authored-by: daledah <daledah@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 24, 2026 13:03
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 24, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#101710 Rules copy requires a Control destination workspace [No QA] Docs updates for E/A#101710 Rules copy requires a Control destination workspace Sep 24, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://e766e4b9.helpdot.pages.dev ⚡️

Updated articles:

Copy link
Copy Markdown
Contributor

No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Feel free to reopen if you disagree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants