Repository navigation
Conversation
…lections Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>
This was referenced Sep 23, 2026
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree! |
24 of 40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to Extend Reconciliation - All Expenses export to any group-by:card selection (
Expensify/App#101522).That PR carved out an exception to the rule that export templates are hidden for group selections: on a search grouped by Card, selecting a card group row now keeps Reconciliation - All Expenses in the Export menu alongside Current view, scoped to every expense on the selected card groups. Every other grouping is unchanged.
No help article described this. The help site was inaccurate in two ways:
Search-and-Download-Expenses.mddocumented group exports as Current view only, which is no longer true for card groups.Changes:
docs/articles/new-expensify/reports-and-expenses/Statement-Matching-and-Reconciliation.md— added## How to Export the Card Transactions You Are Reconcilingwith the four-step flow from the Card statements view, a note that the export covers unscrolled transactions and individually checked ones, and an FAQ covering why the template is hidden for members who aren't a Workspace Admin or card admin. Added export terms tokeywordsandinternalScope.docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md— extended theExport grouped expensessection with the Card exception and an explicit statement that every other grouping still offers Current view only. Added the FAQ## Why don't I see export templates when I select a group?.docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md— added Reconciliation - All Expenses to the template list and its availability rule to theWhy don't I see certain export templates?FAQ.UI labels verified against source
Every label was checked against the code rather than the rendered app, since NewDot web could not be driven in a browser for this run:
Reconciliation - All Expenses—src/languages/en.ts:11338Current view—src/languages/en.ts:11334(note: the menu item isCurrent view, not "Export current view")Card statements/Card accruals—src/languages/en.ts:9666-9667Display/Group by/Card—src/languages/en.ts:9856Both Accounting shortcuts named in the articles really are
groupBy:cardsearches, so the exception applies to them:SearchSuggestionUtils.ts:292(Card statements) andSearchSuggestionUtils.ts:340(Card accruals).The "Workspace Admin or card admin of a card-enabled workspace" gate on the template comes from
isAdminOfCardEnabledPolicyinsrc/libs/actions/Search.ts:2084andsrc/hooks/useSearchBulkActions.ts:752.Authoring guideline compliance
Checked against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md:#headings were introduced, only##.Statement-Matching-and-Reconciliation.mduses Title Case throughout; the other two use sentence case), so the edits don't introduce inconsistency within a file.Not changed, flagged for a separate pass:
How-to-Export-Expenses.mdrefers to the menu item as Export current view in three places, but the actual label is Current view. That predates this PR and fixing it is out of scope here.Fixed Issues
$ #99172
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Suggested check for the reviewer — this is a docs-only change, so it needs a read-through rather than a build:
Offline tests
N/A — documentation only, no app code changes.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ZhenjaHorbach, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.