Skip to content

Keep the narrow Spend page header static instead of echoing the selected tab #101720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
Sep 23, 2026
Merged

Keep the narrow Spend page header static instead of echoing the selected tab #101720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/components/Search/SearchPageHeader/SearchPageHeaderCommon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@ import getSearchPageHeaderTitle from './getSearchPageHeaderTitle';

type SearchPageHeaderCommonProps = {
queryJSONType: SearchDataTypes;
shouldShowLoadingBar?: boolean;
};

function SearchPageHeaderCommon({queryJSONType, shouldShowLoadingBar}: SearchPageHeaderCommonProps) {
function SearchPageHeaderCommon({queryJSONType}: SearchPageHeaderCommonProps) {
const {translate} = useLocalize();
const typeMenuSections = useSearchTypeMenuSections();
const {currentSearchKey} = useSearchQueryContext();
Expand All @@ -24,7 +23,6 @@ function SearchPageHeaderCommon({queryJSONType, shouldShowLoadingBar}: SearchPag

return (
<TopBar
shouldShowLoadingBar={shouldShowLoadingBar}
breadcrumbLabel={title}
shouldDisplayHelpButton
/>
Expand Down
14 changes: 10 additions & 4 deletions src/components/Search/SearchPageHeader/SearchPageHeaderNarrow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,32 @@
import TopBar from '@components/Navigation/TopBar';
import type {SearchQueryJSON} from '@components/Search/types';

import useLocalize from '@hooks/useLocalize';

import SearchSelectedNarrow from '@pages/Search/SearchSelectedNarrow';

import React from 'react';

import SearchPageHeaderCommon from './SearchPageHeaderCommon';

type SearchPageHeaderNarrowProps = {
queryJSON: SearchQueryJSON;
shouldShowLoadingBar: boolean;
isMobileSelectionModeEnabled: boolean;
};

function SearchPageHeaderNarrow({queryJSON, shouldShowLoadingBar = false, isMobileSelectionModeEnabled}: SearchPageHeaderNarrowProps) {
const {translate} = useLocalize();

if (isMobileSelectionModeEnabled) {
return <SearchSelectedNarrow queryJSON={queryJSON} />;
}

// The narrow header is the top-level page title, so it stays a static "Spend". The tab selector rendered directly
// below it already names the current view, and repeating that name here would show the same label twice.
return (
<SearchPageHeaderCommon
queryJSONType={queryJSON.type}
<TopBar
shouldShowLoadingBar={shouldShowLoadingBar}
breadcrumbLabel={translate('common.spend')}
shouldDisplayHelpButton
/>
);
}
Expand Down
4 changes: 2 additions & 2 deletions src/components/Search/SearchPageHeader/getSearchPageHeaderTitle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ type SearchPageHeaderTitleDeps = {
};

/**
* Resolves the Search page header title using a single priority chain shared by the wide and narrow headers so the two
* can't diverge:
* Resolves the title for the wide Search page content header, which names the current view. The narrow header is the
* top-level page title and stays a static "Spend", so it deliberately doesn't use this helper. The priority chain is:
* a. the active saved search's display name,
* b. the matched suggested-search label, then the data-type fallbacks (task / trip / invoice / chat),
* c. the generic "Spend" fallback.
Expand Down
Loading