Conversation
Co-authored-by: Lucien Akchoté <lakchote@users.noreply.github.com>
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Expensify/App#100678, which extended vendor matching to DualEntry (expense Vendor picker, workspace Vendors page, merchant rules, and vendor-name lookup).
The help site had no article covering vendor matching for DualEntry. The sibling articles for QuickBooks Online and Sage Intacct already exist, and a Rillet one is in flight in Expensify/App#100899, so this adds the matching DualEntry article and follows that structure.
New:
docs/articles/new-expensify/connections/dualentry/Manage-Vendor-Matching-for-DualEntry.mdIt documents the behavior introduced or changed by PR #100678:
vendorMatchingbeta gate inhasVendorFeature).getDualEntryVendorskeeps active vendors that are either assigned to the connection's selected Subsidiary or not assigned to any subsidiary, so the article explains that scoping and what happens after a subsidiary change.Updated:
docs/articles/new-expensify/connections/dualentry/Configure-DualEntry.md— one cross-link from the export settings section to the new article.The article is marked
noindex: true/sitemap: falsewhile the feature is beta-gated, matching the Rillet vendor matching article.All UI labels were taken verbatim from
src/languages/en.ts(workspace.dualEntry.*,workspace.moreFeatures.vendors.*,workspace.vendors.*,violations.inactiveVendor,workspace.rules.vendorUnavailable) and the navigation labels were checked against the live web build. Note that both the DualEntry connection and the Vendors row are beta-gated, so neither is visible on a standard account today.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/679020
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review", or the title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@lakchote, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.