SelectionList ListItem decomposition - sweep and flag deletion by jmusial · Pull Request #100954 · Expensify/App

jmusial · 2026-09-11T11:46:38Z

Explanation of Change

Migrate the last BaseListItem wrappers (SpendCategorySelectorListItem, SpendRuleListItem, SplitListItem) onto ListItemComposed, deleteBaseListItem.
Replace the rightHandSideComponent render prop with item.actionElement.
Remove flags that died with their last consumer like shouldDisplayRBR, prop-level shouldShowRightCaret, FooterComponent.
BaseSelectListItem renders item.leftElement, falling back to a compact avatar from item.icons.
Slim ListItem/types.ts (drop BaseListItemProps and per-row aliases) and add tests for the migrated rows.

Fixed Issues

$ #98362
PROPOSAL:

Tests

Open the app and log in with an account that has several contacts.
Navigate to FAB > Start chat.
Verify that each contact row shows an "Add to group" button at the row end, and the row for your own account (self DM) shows none.
Press "Add to group" on a contact that is not first in the list.
Verify that the button turns into a checked checkbox, the row stays in place, and a "Next" button appears in the footer.
Press the row of a second contact (not its button).
Verify that the second contact is added to the group instead of opening a 1:1 chat.
Press the checkbox on the first selected contact.
Verify that it unchecks and shows "Add to group" again.

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-09-17.at.10.50.25.mov

Android: mWeb Chrome

Screen.Recording.2026-09-17.at.10.51.51.mov

iOS: Native

Screen.Recording.2026-09-17.at.10.43.50.mov

iOS: mWeb Safari

Screen.Recording.2026-09-17.at.10.44.26.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-17.at.10.34.17.mov

jmusial · 2026-09-16T09:24:42Z

@codex review

codecov · 2026-09-16T09:25:35Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Search/SearchAutocompleteList.tsx	`88.42% <100.00%> (ø)`
...eReportListItemRow/ExpenseReportListItemAvatar.tsx	`100.00% <100.00%> (ø)`
...chList/ListItem/ExpenseReportListItemRow/index.tsx	`0.00% <ø> (ø)`
src/components/SelectionList/BaseSelectionList.tsx	`84.14% <ø> (ø)`
...onents/SelectionList/ListItem/BareUserListItem.tsx	`100.00% <100.00%> (ø)`
...ents/SelectionList/ListItem/BaseSelectListItem.tsx	`100.00% <100.00%> (ø)`
...components/SelectionList/ListItem/CardListItem.tsx	`0.00% <ø> (ø)`
...ts/SelectionList/ListItem/InviteMemberListItem.tsx	`100.00% <ø> (ø)`
...onents/SelectionList/ListItem/ListItemRenderer.tsx	`85.71% <ø> (ø)`
...nts/SelectionList/ListItem/MultiSelectListItem.tsx	`100.00% <ø> (ø)`
... and 20 more
... and 14 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b08459eaa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jmusial · 2026-09-16T09:48:27Z

@codex review

chatgpt-codex-connector · 2026-09-16T09:53:44Z

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 02dd45e2dc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jmusial · 2026-09-16T11:01:56Z

@MelvinBot review

MelvinBot · 2026-09-16T11:13:07Z

Review

The refactor looks good. Deleting BaseListItem in favour of ListItemComposed + ListItemContext, and replacing the rightHandSideComponent render prop with item.actionElement, both land cleanly. Nothing here blocks merge. Five things worth a second look, plus the PR description.

I ran tsc --noEmit locally (exit 0) and all CI is green apart from the two checklist bots.

Equivalences I checked and confirmed are safe

rightHandSideComponent is fully gone from the SelectionList surface — the remaining hits in src/ are TextInput's unrelated prop of the same name. No orphaned callers.
SingleSelectListItem dropping styles.optionRow is a no-op: src/components/SelectionList/ListItem/BaseSelectListItem.tsx:67 already puts it in wrapperStyle.
SplitListItem dropping fontSize={fontScale.text} is a no-op: src/components/Text.tsx:48 defaults fontSize to variables.fontSizeNormal, which is exactly fontScale.text. Bonus, it retires a deprecated prop.
SearchAutocompleteList dropping the item-level wrapperStyle: [pr3, pl3] is a no-op: wrapperStyle is never read off the item (it comes from style.listItemWrapperStyle via BaseSelectionList.tsx:330), and SearchRouterItem already hardcodes styles.ph3 on the pressable.
ExpenseReportListItemAvatar hardcoding AVATAR_SIZE.SMALL is safe: its only caller is the wide row, which always passed isLargeScreenWidth.
The flattened wrappers in ExpenseReportListItem and SearchMergeReportsListItem are visually equivalent — the dropped flexRow/justifyContentBetween/alignItemsCenter (and flexColumn/alignItemsStretch) wrapped a single flex1 child.
TravelDomainListItem's badge doesn't actually move: selectionButtonPosition defaults to LEFT there, so the badge stays last in the row.
fsClass on a plain View in ChatListItem/TaskListItem is the sanctioned pattern per src/libs/Fullstory/types.ts.

1. The RBR indicator is silently dropped for seven rows

BaseListItem rendered the brick-road dot itself, with shouldDisplayRBR defaulting to true. ListItemPressable renders children only, and only SelectableListItem still draws it. So ChatListItem, TaskListItem, ExpenseReportListItem, SearchMergeReportsListItem, SplitListItem, SpendRuleListItem, and SpendCategorySelectorListItem lose the capability, and shouldDisplayRBR is gone from the types.

I could not find a consumer that sets brickRoadIndicator on any of those item types, so it looks inert today. It's still an undocumented capability drop — worth a line in the PR description so the next person doesn't have to re-derive it.

2. `MultiSelectListItem` clones the item instead of taking a prop

MultiSelectListItem.tsx:42-55 builds {...item, leftElement: <CompactAvatar/>} to replace the removed leftElement prop. Two consequences: onSelectRow now hands callers a shallow clone rather than their own object, and that clone carries a React element.

I checked every ListItem={MultiSelectListItem} consumer and they all key off keyForList/value, so nothing breaks. But the removed prop was the cleaner seam. If the clone stays, a one-line comment noting that item identity isn't preserved would help.

3. `NewChatPage` now builds an action element for every option, not just rendered rows

NewChatPage/index.tsx:353-356 clones every option in every section and constructs a <ListSelectionButton> or <AddToGroupButton> for each. rightHandSideComponent used to be called only for rows the list actually rendered, so this goes from O(visible rows) to O(all contacts).

React Compiler memoizes the map (compliance check passes, and toggleOption reads through refs), so it runs once per sections change rather than per render. That makes it acceptable, but on a long contact list it is still real eager work. Worth confirming against a High Traffic account.

Minor side effect of the same change: toggleOption's {...option} spread carries actionElement into selectedOptions state. Harmless — buildDraftParticipants keeps only login/accountID, so no React element reaches Onyx — just retained garbage.

4. `UserSelectionListItem` moved `item.rightElement` ahead of the selection button

As rightHandSideComponent it rendered after the checkbox; it now sits inside the text row at UserSelectionListItem.tsx:88. Its only consumer (Search/FilterComponents/UserSelector.tsx) doesn't set rightElement, so this is inert — flagging it only so the order change is a known decision rather than a surprise later.

5. The PR description is empty

There's no Explanation of Change, Tests and QA Steps still carry the template's // TODO: These must be filled out marker, and every screenshot block is empty. For a refactor across 30+ list-item files, reviewers will want before/after on at least the Search rows (chat, task, expense report, merge reports), NewChatPage, UnshareBankAccount, and the workspace plan type page.

Nice touches: the new SpendRuleListItemTest and SpendCategorySelectorListItemTest cover components that had no tests before, and AddToGroupButton reading isFocused from context is a genuine improvement over threading it through a render prop.

Next Steps: Reply with @MelvinBot <your feedback> to refine this review.

view run

jmusial · 2026-09-16T14:12:24Z

@MelvinBot updated 2 & 4. 1 intended, 3 list limit rows rendered, I think can be left as is

MelvinBot · 2026-09-16T14:21:29Z

Agreed on 1 and 3. 4 is resolved. The fix for 2 introduced one regression, though.

Moving the avatar into `BaseSelectListItem` breaks `SingleSelectWithAvatarListItem`

BaseSelectListItem.tsx:85 now renders the icon avatar instead of item.leftElement whenever the item has icons — and the new test case 'both icons and leftElement' codifies that precedence.

But SingleSelectWithAvatarListItem.tsx:45 passes {...item, leftElement: avatarElement} while leaving item.icons in place. So the icon branch wins, its AVATAR_SIZE.DEFAULT avatar is now dead code, and the row instead gets ListItemCompactAvatar's AVATAR_SIZE.X_SMALL. The row keeps its [optionRow, pv3, w100] spacing, sized for the bigger avatar.

Two live surfaces:

Report details → Export — DynamicReportDetailsExportPage.tsx:101 sets icons on both export options.
Domain → Add admin — DomainAddAdminPage.tsx:115 feeds option-list personal details, which carry participant avatars in icons.

Both render at DEFAULT on main and at X_SMALL on this branch. No test covers it, which is why CI is green.

Flipping the precedence to item.leftElement ?? icon-avatar would contradict the test case you just added, so the cleaner fix is probably to drop the now-dead leftElement from SingleSelectWithAvatarListItem and let the avatar size be the thing it configures — or, if X_SMALL is acceptable there, delete the component and point its two callers at SingleSelectListItem. That would fit this PR's theme nicely. Either way it's a visible size change, so worth a design check.

One related note: plain SingleSelectListItem now grows an avatar for any item carrying icons. I went through its consumers and none set item.icons today, so it's inert — just a new implicit behavior on the component whose docstring calls it a text-only row.

On your other three

1 (RBR drop) — understood, intended. No action.

3 (eager action elements) — you're right, leave it. I hadn't traced the paging: useSearchSelector/base.ts:169 caps at MAX_SELECTION_LIST_PAGE_LENGTH (50), so sections is bounded regardless of contact count. 50 cheap element objects per sections change is nothing.

2 — the clone is properly gone. Item identity is preserved through onSelectRow now, and the avatar styling (CompactAvatar + styles.mr3) is byte-identical to what MultiSelectListItem did before. The rewritten test is also a real improvement over mocking BaseSelectListItem.

4 — resolved. item.rightElement is now simply not rendered by UserSelectionListItem. SelectableListItem only renders actionElement, so setting rightElement on one of those rows silently does nothing. Its only consumer (Search/FilterComponents/UserSelector.tsx) doesn't set it, so nothing breaks.

Still worth doing

The PR description is unchanged — Explanation of Change is empty, QA Steps still carries the template's // TODO: These must be filled out marker, and the screenshot blocks are blank. For a refactor this wide, screenshots of the Search rows, NewChatPage, and now the two avatar surfaces above would save the reviewer a lot of guessing.

Next Steps: Reply with @MelvinBot <your feedback> to refine this review.

view run

melvin-bot · 2026-09-17T09:05:41Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

heyjennahay

Product review not required

truph01 · 2026-09-18T07:46:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-09-18.at.14.33.52.mov

Android: mWeb Chrome

Screen.Recording.2026-09-18.at.14.35.40.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2026-09-18.at.14.45.38.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-18.at.14.29.47.mov

truph01 · 2026-09-18T07:46:31Z

@jmusial Could you resolve the AI's comments above?

jmusial · 2026-09-18T12:43:58Z

~~@huult~~ (sorry - tagged wrong person) @truph01 codex comment fixed, Melvin ones were addressed before

roryabraham · 2026-09-21T20:14:48Z

+        value?: string;
+
+        /** Should display tag 'Recommended' */
+        isRecommended?: boolean;


NAB because it's an existing prop, but this is a configuration prop used for conditional rendering of a child component - it should be removed and replaced with composition. @MelvinBot create a follow-up issue for this specific decomposition. Assign @jmusial and @roryabraham. Label it Weekly

Created [SelectionList ListItem] Replace the isRecommended config prop on TravelDomainListItem with composition — assigned jmusial and roryabraham, labeled Weekly.

Scoped it to just this prop: the flag exists only to gate a Badge at TravelDomainListItem.tsx:68, and there's exactly one consumer (DomainSelectorStep.tsx:40), so it's a small change. The issue lays out two options — compose the row at the call site and drop the travel-specific Badge/copy out of src/components/SelectionList/, or pass the badge element via the existing actionElement/rightElement slots — and links it back to [$1000] [Tracking] SelectionList ListItem - Composition over Configuration.

github-actions · 2026-09-21T20:18:10Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-21T20:21:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-21T20:24:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100954.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6ecdf22-a3d654c-2602bccf20017ca96b283efde862062d69cad54d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6ecdf22-a3d654c-b93a09ee82ce3e1008a3598f6ddccebe75fc4246/index.html

Web 🕸️
https://100954.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-23T06:16:54Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.92-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-23T06:21:09Z

No help site changes are required for this PR, so I did not create a docs draft PR.

This is an internal component refactor. Nothing a user sees, clicks, or reads changed.

What I checked

The PR is structural only. It consolidates the remaining BaseListItem wrappers onto ListItemComposed, swaps the rightHandSideComponent render prop for an item.actionElement field, and deletes flags whose last consumer went away (shouldDisplayRBR, prop-level shouldShowRightCaret, FooterComponent). All 44 changed files are components, types, or tests.

No copy changed. Every translate() call in the diff is relocated, not modified. The keys are identical before and after:

newChatPage.addToGroup and newChatPage.addUserToGroup — moved out of src/pages/NewChatPage/index.tsx into the new src/pages/NewChatPage/AddToGroupButton.tsx
common.unshare, common.areYouSure, walletPage.unshareBankAccountWarning — same strings, restructured component in src/pages/settings/Wallet/UnshareBankAccount/UnshareBankAccount.tsx
travel.domainSelector.recommended — same badge, now passed as leftElement in src/components/SelectionList/ListItem/TravelDomainListItem.tsx

No src/languages/*.ts file is touched, and no new translation key is introduced.

The plan type lock is preserved, not changed. In src/pages/workspace/DynamicWorkspaceOverviewPlanTypePage.tsx the isPlanTypeLocked condition is unchanged (isControl && isAnnual && !policy.canDowngrade). The lock icon only moved from a lockedIcon callback passed as rightHandSideComponent onto item.actionElement. Annual Control workspaces still show the lock and still cannot downgrade to Collect.

Articles I checked and left alone, because the flows they document are unchanged:

docs/articles/new-expensify/chat/Create-a-New-Chat.md — its "Start a Group Chat" steps still match the app exactly: select Add to group, participants show a green checkmark, then Next.
docs/articles/new-expensify/billing-and-subscriptions/manage-your-subscription-and-billing/manage-subscription/Change-Your-Workspace-Plan.md — the annual downgrade restriction it describes still applies identically.

One caveat: I could not drive NewDot in a browser on this run, so this is based on code review rather than live UI verification. The diff contains no string change and no changed conditional to verify — the copy and the gating logic are identical before and after.

Since no docs PR was needed, there is nothing for you to review or mark Ready for review. If you want a docs update for a reason outside this diff, reply with @MelvinBot <what to document> and I'll draft one.

view run

OSBotify · 2026-09-24T12:31:04Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

jmusial added 2 commits September 11, 2026 12:10

Delete BaseListItem

5717e91

remove rightHandSideComponent as a prop

d89dbd5

melvin-bot Bot assigned jmusial Sep 11, 2026

This was referenced Sep 16, 2026

[Due for payment 2026-10-18] [$1000] [Tracking] SelectionList ListItem - Composition over Configuration #97971

Open

[SelectionList ListItem] PR 5 — Sweep and flag deletion #98362

Closed

Merge branch 'main' into chore/list-item-cleanup

6b08459

chatgpt-codex-connector Bot reviewed Sep 16, 2026

View reviewed changes

Comment thread src/components/SelectionList/ListItem/UserSelectionListItem.tsx

readd the right item in UserSelectionListItem

02dd45e

Code cleanup

b7ad2f4

fix some of Melvins findings

a063ad7

update test

68ff08a

fix regression

ae1d939

jmusial changed the title ~~Chore/list item cleanup~~ SelectionList ListItem- sweep and flag deletion Sep 16, 2026

jmusial changed the title ~~SelectionList ListItem- sweep and flag deletion~~ SelectionList ListItem decomposition - sweep and flag deletion Sep 16, 2026

Merge branch 'main' into chore/list-item-cleanup

9acc318

jmusial marked this pull request as ready for review September 17, 2026 09:05

jmusial requested review from a team as code owners September 17, 2026 09:05

melvin-bot Bot requested review from heyjennahay and truph01 and removed request for a team September 17, 2026 09:05

github-actions Bot reviewed Sep 17, 2026

View reviewed changes

Comment thread src/pages/NewChatPage/AddToGroupButton.tsx Outdated

jmusial mentioned this pull request Sep 17, 2026

SelectionList ListItem decomposition - Search-row highlight conversions #101417

Merged

38 tasks done

heyjennahay reviewed Sep 17, 2026

View reviewed changes

jmusial added 2 commits September 18, 2026 14:37

Merge branch 'main' into chore/list-item-cleanup

5e3c134

fix ui comment

74ee84e

truph01 approved these changes Sep 21, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham September 21, 2026 08:05

roryabraham approved these changes Sep 21, 2026

View reviewed changes

roryabraham merged commit 6ecdf22 into Expensify:main Sep 21, 2026
35 of 37 checks passed

MelvinBot mentioned this pull request Sep 21, 2026

[SelectionList ListItem] Replace the isRecommended config prop on TravelDomainListItem with composition #101800

Open

4 tasks

OSBotify mentioned this pull request Sep 23, 2026

Deploy Checklist: New Expensify 2026-09-23 #101971

Closed

Conversation

jmusial commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

jmusial commented Sep 16, 2026

Uh oh!

codecov Bot commented Sep 16, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jmusial commented Sep 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 16, 2026

Uh oh!

jmusial commented Sep 16, 2026

Uh oh!

MelvinBot commented Sep 16, 2026

Review

1. The RBR indicator is silently dropped for seven rows

2. MultiSelectListItem clones the item instead of taking a prop

3. NewChatPage now builds an action element for every option, not just rendered rows

4. UserSelectionListItem moved item.rightElement ahead of the selection button

5. The PR description is empty

Uh oh!

jmusial commented Sep 16, 2026

Uh oh!

MelvinBot commented Sep 16, 2026

Moving the avatar into BaseSelectListItem breaks SingleSelectWithAvatarListItem

On your other three

Still worth doing

Uh oh!

melvin-bot Bot commented Sep 17, 2026

Uh oh!

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Sep 18, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Sep 18, 2026

Uh oh!

jmusial commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roryabraham Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 21, 2026

Uh oh!

OSBotify commented Sep 21, 2026

Uh oh!

github-actions Bot commented Sep 21, 2026

Uh oh!

OSBotify commented Sep 23, 2026

Uh oh!

MelvinBot commented Sep 23, 2026

Uh oh!

OSBotify commented Sep 24, 2026

Uh oh!

Reviewers

Assignees

Labels

jmusial commented Sep 11, 2026 •

edited

Loading

codecov Bot commented Sep 16, 2026 •

edited by github-actions Bot

Loading

2. `MultiSelectListItem` clones the item instead of taking a prop

3. `NewChatPage` now builds an action element for every option, not just rendered rows

4. `UserSelectionListItem` moved `item.rightElement` ahead of the selection button

Moving the avatar into `BaseSelectListItem` breaks `SingleSelectWithAvatarListItem`

jmusial commented Sep 18, 2026 •

edited

Loading