Skip to content

[SelectionList ListItem] PR 5 — Sweep and flag deletion #98362

Description

@MelvinBot

Part of the SelectionList ListItem — Composition over Configuration tracking effort. See PR split in this comment.

PR 5 — Sweep and flag deletion

  • Migrates: the full residue, enumerated — SpendCategorySelectorListItem, SpendRuleListItem, SplitListItem (the three remaining direct BaseListItem wrappers). Nothing else is left: every other ValidListItem entry lands in PRs 1-5 or is covered transitively.
  • Components needed: none new.
  • Implementation details:
    • SplitListItem migrates its pressable/layout like any variant; only its highlight stays on raw useAnimatedHighlightStyle.
    • Each flag dies with its last consumer: shouldDisplayRBR, prop-level shouldShowRightCaret (item-level flag from useConfirmationSections.ts stays), rightHandSideComponent, FooterComponent, wrapperStyle/testID forwarding.
    • ListItem/types.ts reduction; drop render-prop compat.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

ReviewingHas a PR in reviewSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions