Repository navigation
refactor reportDrafts explicitly in the expense confirmation flow - #100697
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…ticipant-submission helpers
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
|
friendly bump @DylanDylann |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-09-22.at.17.26.58.mov |
Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
|
@pecanoro i updated |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 pecanoro has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.4.93-0 🚀
|
|
🤖 No help site changes are required for this PR, so I did not create a docs PR. Why: this is an internal refactor with no user-facing behavior, UI, or copy change. It threads What I checkedChanged files — all plumbing plus tests, no strings, no components, no new flows:
No Help site articles under @daledah, if you think a user-visible behavior did change here that I missed, reply with the specific difference and I'll draft the docs PR. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.93-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66414
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-09-09.at.18.02.18.mov