Skip to content

[Due for payment 2026-10-15] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_DRAFT in src/libs/ReportUtils.ts #66414

Open

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/ReportUtils.ts
  • Onyx Key: ONYXKEYS.COLLECTION.REPORT_DRAFT
  • Reference: Line 931: ONYXKEYS.COLLECTION.REPORT_DRAFT

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @bfitzexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. tgolen commented on Aug 19, 2025

    @tgolen
    ContributorAuthor

    This is a long-running project, so this will be gotten to eventually.

  8. 131 remaining items

  9. daledah commented on Oct 15, 2026

    @daledah
    Contributor

    Hi @mallenexpensify since this issue requires too many PRs, I'd like to request the payment for the next batch of PRs that were already deployed to production. We still need to keep this issue open for more upcoming PRs.

    #89939 -> 250
    #91279 -> 250
    #92964 -> 250
    #98960 -> 250
    #100697 -> 250
    #102400 -> 250

    The total amount is $250 * 6 = 1500

    @DylanDylann @tgolen Can you please confirm?

  10. tgolen commented on Oct 15, 2026

    @tgolen
    ContributorAuthor

    Agreed with that!

    Total Approved: $1,500

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Oct 15, 2026
  12. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_DRAFT` in `src/libs/ReportUtils.ts`[/-] [+][Due for payment 2026-10-15] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_DRAFT` in `src/libs/ReportUtils.ts`[/+] on Oct 15, 2026
  13. melvin-bot commented on Oct 15, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  14. mallenexpensify commented on Oct 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @DylanDylann due $1500 via NewDot
    Contributor+: @daledah due $1500 via NewDot

  15. daledah commented on Oct 20, 2026

    @daledah
    Contributor

    Reopening this issue since we still have a few PRs to complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.ReviewingHas a PR in reviewSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions