[WAITING ON CHECKLIST] Generic Error Displayed When Assigning a Card Already Assigned on Another Feed

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Add a third-party card feed to a domain
2. Assign a card from that feed to Member A
3. Add the same third-party card feed to a workspace
4. Attempt to assign the same card to Member A again
5. Observe the error shown

Expected Result:

Error message displayed as:
“This card has already been assigned to this member on a different feed.”

Actual Result:

A generic error message is displayed:
“Card assignment failed.”

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022014116649028178751
• Upwork Job ID: 2014116649028178751
• Last Price Increase: 2026-01-21

Issue Owner

Current Issue Owner: @flodnv

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[yatin-italy]

Its BE issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022014116649028178751

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[jliexpensify]

@ikevin127 could you confirm it's BE? Thanks!

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A generic error message is displayed:
“Card assignment failed.”

What is the root cause of that problem?

The generic error is set in the failureData here

App/src/libs/actions/CompanyCards.ts

Lines 335 to 338 in 3779ccf

	errors: {
	failed: translate('workspace.companyCards.assignCardFailedError'),
	},
	};

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/index.tsx

Lines 115 to 117 in 3779ccf

	if (failedCompanyCardAssignment) {
	return failedCompanyCardAssignment;
	}

The backend returns the error in assignCard key, which is not used to display in the company card page

What changes do you think we should make in order to solve the problem?

Because we always set isAssignmentFinished to true in the finallyData, the flow is always closed here even if the API fails

We should only set isAssignmentFinished to true in successData then the confirmation page will not be closed and the backend error appears

successData: [
            ....
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: ONYXKEYS.ASSIGN_CARD,
                value: {isAssignmentFinished: true},
            },
        ],
finallyData: [
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: ONYXKEYS.ASSIGN_CARD,
                value: {isAssigning: false},
            },
        ],

App/src/libs/actions/CompanyCards.ts

Line 403 in 3779ccf

value: {isAssigning: false, isAssignmentFinished: true},

What alternative solutions did you explore? (Optional)

The backend can return the error to this key ${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${domainOrWorkspaceAccountID}_${bankName} instead

Then we should set the error based on the timestamp here

errors: ErrorUtils.getMicroSecondOnyxErrorWithMessage(translate('workspace.companyCards.assignCardFailedError')),

App/src/libs/actions/CompanyCards.ts

Lines 335 to 338 in 3779ccf

	errors: {
	failed: translate('workspace.companyCards.assignCardFailedError'),
	},
	};

And get the last error to display here

errors={getLatestErrorMessageField(item)}

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableItem.tsx

Line 141 in 3779ccf

errors={errors}

This approach ensures that the backend error with the larger timestamp is always prioritized first. If the backend doesn't return any error, display a generic frontend error which we set in the failuerData

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[yatin-italy]

@ikevin127 could you confirm it's BE? Thanks!

@jliexpensify @ikevin127 I want to apologize. I checked again and also reviewed the solution provided by nkdengineer. It looks like this issue can be fixed on the frontend.