[Tracking] NewDot SignIn page on HybridApp follow up improvements

[Julesssss]

The NewDot Signin page on HybridApp feature has been merged. Here are our follow up improvements and related bugs:

Tasks

TODO

• [Due for payment 2026-02-17] User Settings-Infinite loading after importing the onyx state and relaunching the app #64606
• [Due for payment 2025-12-12] [HOLD on #74727] [$375] Android - Apple login page overlaps with device status bar #64116

Completed

• [$250] Android - App is signed out when adding 2FA to account #60770
• [$250] Android - Login - App language is not preserved after relaunching app #69246
• Enable Google SSO on Android HybridApp builds #69575
• Ensure the tryNewDot NVP is applied during account reopening #63506
• [$250] [Due for payment 2025-09-12] SignInModal shifts when keyboard appears #69068
• [Due for payment 2025-09-12] iOS - Login - Expensify app logo is black after opening invalid magic link and relaunching app #69305
• [HOLD #49844] Sign in-"All caught up" briefly shown when sign in after the other account signed out from OD #64117
• [Due for payment 2025-06-27] [$250] Translation strings not showing on SignInPage after sign out #64375
• [Due for payment 2025-07-22] [$250] HybridApp SignIn page - Add HYBRID_APP onyx key #65786
• Email - The invited user redirects to the Home page instead of the created room #67920
• [$250] SignIn Modal appears without animation for anon user #69069
• [Due for payment 2025-07-25] Fix hybridApp soft exceptions #66256
• [$250] iOS Hybrid - Native share - No "Please sign in.." message while sharing an image #64694
• [$250] [Due for payment 2025-08-22] Sign in page text not displayed correctly after switching experiences  #67953
• IOS - Clear cache-User is redirected to the Join page after tapping Clear cache and restart #64118
• [HOLD 49844] Android - App returns to 2FA login page after clear cache and restart #64114
• Travel - Back button on the first screen of travel flow does not closes NewDot #65369
• Create Account - Interact with Magic Link not added magic code for login #64684
• ReactNativeManager.clearOldDotAfterSignOut() crash
• [Hold #49844] [$250] HybridApp - Can't validate the account of a new sign-up on a controlled private domain #55771
• Deep link - Concierge opens when opening public room link, user is signed out #65297
• [Due for payment 2025-09-12] iOS - Login - Extra padding above "Done" row in language menu when accessed via public room #67863
• Sign out page flashes on sign out
• Add new test cases to QA test suite (asked here)
• • [Tracking] HybridApp TTI improvements #69795

[Julesssss]

Hey @mateuuszzzzz @289Adam289 @war-in, thanks for the effort with the new SignIn page!

While we're awaiting deployment and QA testing please could you take a look at any of the polish issues listed above.

[DylanDylann]

@Julesssss Could I help with these follow-up issues? Because I already had context while reviewing the first PR

[MarioExpensify]

Hey @Julesssss, it seems we have a new one: #64606 It was demoted from blocker but it seems related.

[mateuuszzzzz]

Hi @DylanDylann I'm curious if you're still able to reproduce this flashing on sign-out .

EDIT: I'm able to reproduce it

[Julesssss]

We noticed this crash while the feature was live, which a fair amount of reproductions:

          Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x83f20 __exceptionPreprocess
1  libobjc.A.dylib                0x172b8 objc_exception_throw
2  UIKitCore                      0x56e2ec -[UIViewController _presentViewController:withAnimationController:completion:]
3  UIKitCore                      0x8e99e0 __63-[UIViewController _presentViewController:animated:completion:]_block_invoke_2
4  UIKitCore                      0x95434 +[UIView(Animation) performWithoutAnimation:]
5  UIKitCore                      0x56f9f0 __63-[UIViewController _presentViewController:animated:completion:]_block_invoke
6  UIKitCore                      0x5699b4 -[UIViewController _performCoordinatedPresentOrDismiss:animated:]
7  UIKitCore                      0x5696dc -[UIViewController _presentViewController:animated:completion:]
8  UIKitCore                      0x569570 -[UIViewController presentViewController:animated:completion:]
9  Expensify                      0x13e940 specialized static ReactNativeManager.clearOldDotAfterSignOut() + 167 (ReactNativeManager.swift:167)
10 libdispatch.dylib              0x213c _dispatch_call_block_and_release
11 libdispatch.dylib              0x3dd4 _dispatch_client_callout
12 libdispatch.dylib              0x125a4 _dispatch_main_queue_drain
13 libdispatch.dylib              0x121b8 _dispatch_main_queue_callback_4CF
14 CoreFoundation                 0x56710 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
15 CoreFoundation                 0x53914 __CFRunLoopRun
16 CoreFoundation                 0x52cd8 CFRunLoopRunSpecific
17 GraphicsServices               0x11a8 GSEventRunModal
18 UIKitCore                      0x40aae8 -[UIApplication _run]
19 UIKitCore                      0x4bed98 UIApplicationMain
20 Expensify                      0x44990 main + 16 (main.swift:16)
21 ???                            0x1ca113154 (Missing)

Further logs:

com.expensify.expensifylite_issue_df706cc4a2eefcafb62e68ee0ebb1d81_crash_session_6c6036ca9bd9463b881d30e066e6acc6_DNE_0_v2.json

[mateuuszzzzz]

I found more descriptive log for this error:

Fatal Exception: NSInvalidArgumentException
Application tried to present modally a view controller <UIViewController: 0x123111000> that is already being presented by <ExpensifyRootViewController: 0x1063dab00>.

Since we're calling clearOldDotAfterSignOut from components, it might be triggered more than once due to changing dependencies. I'll address this in the PR that brings back the SignInPage.

EDIT: Should be fixed now.

[mateuuszzzzz]

On top of the PRs that reintroduce the new SignInPage, I’ve created two additional PRs that fix the reload issue in development.

Previously, after signing in, reloading the app would bring us back to the SignInPage. This happened because we were passing HybridAppSettings from OldDot via initial props. Every reload after signing in was using outdated initial props, since props don’t change between reloads.

I’ve updated this behavior in those PRs so that HybridAppSettings is now sent through a native method and can only be obtained once per NewDot lifecycle. This prevents multiple NewDot initializations during reloads.

Here’s the PR (the diff will be clearer once the initial PRs are merged). I’d like to keep this change in a separate PR to avoid introducing additional variables that could complicate debugging if any issues arise.

ND: #65178
OD: https://github.com/Expensify/Mobile-Expensify/pull/13607

[Julesssss]

Sounds good, thanks. Currently we're just waiting on this deep link/action PR before we merge the SignIn page changes

[mateuuszzzzz]

I prepared two PRs that will simplify solving 2 issues that become visible on new SignInPage (more info in PR description). I'll continue testing on Monday.

ND: #65506
OD: https://github.com/Expensify/Mobile-Expensify/pull/13616