Repository navigation
[HOLD for payment 2024-11-13] Redundant OpenReport requests when opening a thread #51680
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.55-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tgolen
Slack conversation: Reported it in #49162 (comment)
Action Performed:
- Have User 1 and User 2 in a chat together
- User 1 adds a comment
- User 1 opens the comment in a thread
- User 1 adds a comment to the thread
- User 2 opens the thread
Expected Result:
User 2 should only have a single call to OpenReport
Actual Result:
Use 2 has two calls to OpenReport
Workaround:
Can the user still use Expensify without this being fixed? Yes, it is non-breaking.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Oct 29, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)melvin-bot commentedon Oct 29, 2024
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.tgolen commentedon Oct 29, 2024
@twisterdotcom @situchan This was something I reported in #49162 (comment) and @nkdengineer already debugged it and wrote a quick proposal for it. I'm opening this issue so the problem can be fixed. We can skip looking at other proposals for this one.
@nkdengineer Can you please comment on this issue so I can assign it to you?
nkdengineer commentedon Oct 29, 2024
@tgolen I'm here.
nkdengineer commentedon Oct 29, 2024
Thanks, I will open the PR tomorrow morning.
twisterdotcom commentedon Oct 29, 2024
Zim zam zoom. Here to watch the masters at work and pay out.
26 remaining items
melvin-bot commentedon Nov 13, 2024
Payment Summary - WIP
Upwork Job
BugZero Checklist (@twisterdotcom)
shubham1206agra commentedon Nov 13, 2024
@tgolen @twisterdotcom This seems to be still happening according to #49948 (comment). Can anyone check?
tgolen commentedon Nov 13, 2024
Anyone should be able to check and see if they can reproduce it. @shubham1206agra can you give it a try first?
tgolen commentedon Nov 13, 2024
OK, I followed the links (so many trails to follow) and I ended up at a Slack thread which talks about multiple
OpenApprequests, which is different than this (onlyOpenReport).twisterdotcom commentedon Nov 14, 2024
Okay, let's pay out for this OpenReport fix.
twisterdotcom commentedon Nov 14, 2024
Just need to pay out the two offers.
melvin-bot commentedon Nov 18, 2024
@tgolen, @twisterdotcom, @c3024, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
twisterdotcom commentedon Nov 18, 2024
@nkdengineer please accept the upwork offer. I will pay out when I'm going through my upwork inbox at some point this week.
JmillsExpensify commentedon Nov 18, 2024
$125 approved for @bernhardoj
nkdengineer commentedon Jan 5, 2025
@twisterdotcom Could you please help pay out here?
Thanks!