[$250] 3 OpenReport API calls for the same report

@iwiznia

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727446418470879

Action Performed:

User A and user B are on a chat
User A adds a comment
User A creates a thread under their comment
User B clicks the thread

Expected Result:

Thread opens and no duplicate OpenReport API calls for same report

Actual Result:

3 OpenReport API calls for the same report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021841330786260257123
Upwork Job ID: 1841330786260257123
Last Price Increase: 2024-11-13

Issue Owner

Current Issue Owner: @shubham1206agra

@VictoriaExpensify

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are 2 OpenReport calls when open a thread that we never loaded yet.

What is the root cause of that problem?

The 1st OpenReport is called in this effect. The purpose of this effect is to call the OpenReport on mount, but we only want to call it when the report onyx is already loaded. We did this after migrating from withOnyx to useOnyx here.

App/src/pages/home/ReportScreen.tsx

Lines 489 to 496 in 69483ff

    
           useEffect(() => { 
        
               // Call OpenReport only if we are not linking to a message or the report is not available yet 
        
               if (isLoadingReportOnyx || reportActionIDFromRoute) { 
        
                   return; 
        
               } 
        
               fetchReportIfNeeded(); 
        
               // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps 
        
           }, [isLoadingReportOnyx]);

The 2nd and 3rd call is triggered from this effect.

App/src/pages/home/ReportScreen.tsx

Lines 577 to 588 in 69483ff

    
               // If you already have a report open and are deeplinking to a new report on native, 
        
               // the ReportScreen never actually unmounts and the reportID in the route also doesn't change. 
        
               // Therefore, we need to compare if the existing reportID is the same as the one in the route 
        
               // before deciding that we shouldn't call OpenReport. 
        
               if (onyxReportID === prevReport?.reportID && (!onyxReportID || onyxReportID === reportIDFromRoute)) { 
        
                   return; 
        
               } 
        
               fetchReportIfNeeded(); 
        
               ComposerActions.setShouldShowComposeInput(true); 
        
               // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps 
        
           }, [

When we open the thread that we haven't loaded yet, the report will initially be undefined. The 1st OpenReport will optimistically merge the reportName as Chat Report.

App/src/libs/actions/Report.ts

Lines 779 to 783 in 69483ff

    
           const optimisticReport = reportActionsExist(reportID) 
        
               ? {} 
        
               : { 
        
                     reportName: ReportConnection.getAllReports()?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]?.reportName ?? CONST.REPORT.DEFAULT_REPORT_NAME, 
        
                 };

This will update the report to {reportName: 'Chat Report'}, and so, the report onyx now contains an empty reportID.

App/src/pages/home/ReportScreen.tsx

Lines 169 to 173 in 69483ff

    
           const report = useMemo( 
        
               (): OnyxEntry<OnyxTypes.Report> => 
        
                   reportOnyx && { 
        
                       lastReadTime: reportOnyx.lastReadTime, 
        
                       reportID: reportOnyx.reportID ?? '',

Because onyxReportID (empty string) is different from prevReport?.reportID (undefined), the 2nd OpenReport is called. After the 1st OpenReport is finished, the onyxReportID is updated to the correct reportID (X). Again, because the onyxReportID (X) is different from prevReport?.reportID (empty string), the 3rd OpenReport is called.

What changes do you think we should make in order to solve the problem?

There are 2 solutions. First, if we see the comment here,

App/src/pages/home/ReportScreen.tsx

Lines 577 to 585 in 69483ff

    
           // If you already have a report open and are deeplinking to a new report on native, 
        
           // the ReportScreen never actually unmounts and the reportID in the route also doesn't change. 
        
           // Therefore, we need to compare if the existing reportID is the same as the one in the route 
        
           // before deciding that we shouldn't call OpenReport. 
        
           if (onyxReportID === prevReport?.reportID && (!onyxReportID || onyxReportID === reportIDFromRoute)) { 
        
               return; 
        
           } 
        
           fetchReportIfNeeded();

it's mentioned that when deeplinking from a report to another report, the report screen is not unmounted and the reportID param is not updated, so the old conditions doesn't work when comparing prev reportID params to the current reportID params.

The report screen is not unmounted part is still true today because if we deeplink to the same screen with a different params, react-navigation will just update the screen params, so this part isn't true anymore.

the reportID in the route also doesn't change.

So, the first solution is to use the old conditions by comparing the prev reportID params and the current reportID params.

if (prevReportIDFromRoute === reportIDFromRoute) {
    return;
}

The second solution is to push a new screen if the reportID is different. To do that, we can override the deeplink here.

App/src/libs/Navigation/linkingConfig/subscribe/index.native.ts

Lines 21 to 29 in 69483ff

    
           if (path) { 
        
               const stateFromPath = getStateFromPath(path, config); 
        
               if (stateFromPath) { 
        
                   const focusedRoute = findFocusedRoute(stateFromPath); 
        
                   if (focusedRoute && focusedRoute.name === SCREENS.SEARCH.CENTRAL_PANE) { 
        
                       Navigation.navigate(path as Route); 
        
                       return; 
        
                   } 
        
               }

if (focusedRoute?.name === SCREENS.REPORT && hasAuthToken()) {
    Navigation.navigate(path as Route);
    return;
}

Then, we can remove the OpenReport call here.

App/src/pages/home/ReportScreen.tsx

Lines 577 to 585 in 69483ff

    
           // If you already have a report open and are deeplinking to a new report on native, 
        
           // the ReportScreen never actually unmounts and the reportID in the route also doesn't change. 
        
           // Therefore, we need to compare if the existing reportID is the same as the one in the route 
        
           // before deciding that we shouldn't call OpenReport. 
        
           if (onyxReportID === prevReport?.reportID && (!onyxReportID || onyxReportID === reportIDFromRoute)) { 
        
               return; 
        
           } 
        
           fetchReportIfNeeded();

Job added to Upwork: https://www.upwork.com/jobs/~021841330786260257123

@shubham1206agra

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

I think #vip-vsb is the best place for this since it's related to threads

@VictoriaExpensify

@VictoriaExpensify, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@VictoriaExpensify

@VictoriaExpensify, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

@VictoriaExpensify

@VictoriaExpensify, @shubham1206agra Still overdue 6 days?! Let's take care of this!

@shubham1206agra

hey @shubham1206agra - can you please check the conversation Ioni linked here - #49948 (comment)

It looks like this issue is still happening

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@VictoriaExpensify

@VictoriaExpensify, @shubham1206agra Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Issue not reproducible during KI retests. (First week)

@VictoriaExpensify

@VictoriaExpensify, @shubham1206agra 12 days overdue now... This issue's end is nigh!

@VictoriaExpensify

@VictoriaExpensify Please close this

Fixed over here: #51680

Navigation Menu

Repository navigation

[$250] 3 OpenReport API calls for the same report #49948

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

38 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	useEffect(() => {
	// Call OpenReport only if we are not linking to a message or the report is not available yet
	if (isLoadingReportOnyx \|\| reportActionIDFromRoute) {
	return;
	}
	fetchReportIfNeeded();
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, [isLoadingReportOnyx]);

	// If you already have a report open and are deeplinking to a new report on native,
	// the ReportScreen never actually unmounts and the reportID in the route also doesn't change.
	// Therefore, we need to compare if the existing reportID is the same as the one in the route
	// before deciding that we shouldn't call OpenReport.
	if (onyxReportID === prevReport?.reportID && (!onyxReportID \|\| onyxReportID === reportIDFromRoute)) {
	return;
	}

	fetchReportIfNeeded();
	ComposerActions.setShouldShowComposeInput(true);
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, [

	const optimisticReport = reportActionsExist(reportID)
	? {}
	: {
	reportName: ReportConnection.getAllReports()?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]?.reportName ?? CONST.REPORT.DEFAULT_REPORT_NAME,
	};

	const report = useMemo(
	(): OnyxEntry<OnyxTypes.Report> =>
	reportOnyx && {
	lastReadTime: reportOnyx.lastReadTime,
	reportID: reportOnyx.reportID ?? '',

	if (path) {
	const stateFromPath = getStateFromPath(path, config);
	if (stateFromPath) {
	const focusedRoute = findFocusedRoute(stateFromPath);
	if (focusedRoute && focusedRoute.name === SCREENS.SEARCH.CENTRAL_PANE) {
	Navigation.navigate(path as Route);
	return;
	}
	}

[$250] 3 OpenReport API calls for the same report #49948

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 30, 2024

bernhardoj commented on Oct 1, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Oct 2, 2024

melvin-bot commented on Oct 2, 2024

VictoriaExpensify commented on Oct 2, 2024

melvin-bot commented on Oct 7, 2024

38 remaining items

melvin-bot commented on Nov 6, 2024

melvin-bot commented on Nov 11, 2024

melvin-bot commented on Nov 13, 2024

VictoriaExpensify commented on Nov 13, 2024

melvin-bot commented on Nov 13, 2024

melvin-bot commented on Nov 15, 2024

mvtglobally commented on Nov 16, 2024

melvin-bot commented on Nov 19, 2024

shubham1206agra commented on Nov 19, 2024

muttmuure commented on Nov 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions