Repository navigation
Expense - Unable to drag and drop receipt to Upload receipt RHP #49901
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.We think that this bug might be related to #wave-control
offending PR #47990
Edited by proposal-police: This proposal was edited at 2024-09-29 20:15:28 UTC.
Edits: Fix code links, added video
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to drag and drop receipt to Upload receipt RHP
What is the root cause of that problem?
here we are explictly disable the drag and drop functionality when backTo route is not available.
in this PR #47990, we replaced getActiveRouteWithoutParams with getReportRHPActiveRoute which return empty string when report is not in RHP.
What changes do you think we should make in order to solve the problem?
Here, If getReportRHPActiveRoute return empty string then we should get the active route from getActiveRouteWithoutParams.
Navigation.navigate( ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute( // rest of params Navigation.getReportRHPActiveRoute() || Navigation.getActiveRouteWithoutParams(), ), )
Screen.Recording.2024-09-30.at.1.47.38.AM.mov
Edited by proposal-police: This proposal was edited at 2024-09-29 20:25:27 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to drag and drop receipt to Upload receipt RHP
What is the root cause of that problem?
We recently started using
Navigation.getReportRHPActiveRoute()everywhere, but this issue only happens onScan page
It's becauseshouldShowWrapperwill befalseand the top part will be cut off
What changes do you think we should make in order to solve the problem?
We can create a new variable
const isEditing = action === CONST.IOU.ACTION.EDITand we can pass it here
shouldShowWrapper={isEditing}Optional: We can also fix this in IOURequestStepScan/index.native.tsx file
We should check for other pages too where we have this issue and fix itWhat alternative solutions did you explore? (Optional)
Or we can do something like this here
shouldShowWrapper={!!backTo || isEditing}Alternative 2
Pass shouldShowWrapper hereshouldShowWrapperProposal
Please re-state the problem that we are trying to solve in this issue.
Android- expense - In camera screen receipt header is missing
What is the root cause of that problem?
The
backToisundefined, which prevents the wrapper from showing and causes this issue.backToisundefinedbecauseNavigation.getReportRHPActiveRoute()returnsundefinedwhen clicked from the money request view.
What changes do you think we should make in order to solve the problem?
We should check if
getReportRHPActiveRoutereturnsundefined, and if so, usegetActiveRouteWithoutParams.// src/components/ReportActionItem/MoneyRequestView.tsx#L538 {shouldShowReceiptEmptyState && ( <ReceiptEmptyState hasError={hasErrors} disabled={!canEditReceipt} onPress={() => Navigation.navigate( ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute( CONST.IOU.ACTION.EDIT, iouType, transaction?.transactionID ?? '-1', report?.reportID ?? '-1', - Navigation.getReportRHPActiveRoute(), + Navigation.getReportRHPActiveRoute() || Navigation.getActiveRouteWithoutParams(), ), ) } /> )}What alternative solutions did you explore? (Optional)
We used getActiveRouteWithoutParams instead of getReportRHPActiveRoute.
// src/components/ReportActionItem/MoneyRequestView.tsx#L538 {shouldShowReceiptEmptyState && ( <ReceiptEmptyState hasError={hasErrors} disabled={!canEditReceipt} onPress={() => Navigation.navigate( ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute( CONST.IOU.ACTION.EDIT, iouType, transaction?.transactionID ?? '-1', report?.reportID ?? '-1', - Navigation.getReportRHPActiveRoute(), + Navigation.getActiveRouteWithoutParams(), ), ) } /> )}Note: Same as my proposal posted previously.
Details
POC-
Not a Web-E blocker
I think @bernhardoj already fixed this here? Should I assign you to this one? I don't think this should be weekly btw, I'll change it to Hourly until we confirm this is solved today since it's a rough bug.
⚠️ Looks like this issue was linked to a Deploy Blocker hereIf you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
@carlosmiceli yes, I'm fixing it in #49916. Not sure if I need to get assigned here though.
The linked PR fixes this blocker and is ready for merging and cherry-picking to staging
Since @luacmartins is reviewing that PR I'll let him decide, should @bernhardoj be assigned to this issue too?
Confirmed fix on staging.
This was a regression so I'm gonna close the issue.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Image can be dragged and dropped to Upload receipt RHP
Actual Result:
Image cannot be dragged and dropped to Upload receipt RHP
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6618334_1727525236867.20240928_200433.mp4
View all open jobs on GitHub