Repository navigation
Android- expense - In camera screen receipt header is missing #49881
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Launch app
- Tap on a workspace chat
- Create a expense
- Open the expense and tap plus receipt placeholder and try to upload a image using camera
Expected Result:
In camera screen receipt header must not be missing
Actual Result:
In camera screen receipt header is missing
Reproduction on: Redmi note 10s android 13
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Sep 28, 2024
Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Sep 28, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Sep 28, 2024
Production:
huult commentedon Sep 29, 2024
Edited by proposal-police: This proposal was edited at 2024-09-29 07:56:39 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android- expense - In camera screen receipt header is missing
What is the root cause of that problem?
The
backToisundefined, which prevents the wrapper from showing and causes this issue.App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx
Line 479 in 3047c1b
backToisundefinedbecauseNavigation.getReportRHPActiveRoute()returnsundefinedwhen clicked from the money request view.App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 538 in 3047c1b
What changes do you think we should make in order to solve the problem?
We should check if
getReportRHPActiveRoutereturnsundefined, and if so, usegetActiveRouteWithoutParams.// src/components/ReportActionItem/MoneyRequestView.tsx#L538 {shouldShowReceiptEmptyState && ( <ReceiptEmptyState hasError={hasErrors} disabled={!canEditReceipt} onPress={() => Navigation.navigate( ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute( CONST.IOU.ACTION.EDIT, iouType, transaction?.transactionID ?? '-1', report?.reportID ?? '-1', - Navigation.getReportRHPActiveRoute(), + Navigation.getReportRHPActiveRoute() || Navigation.getActiveRouteWithoutParams(), ), ) } /> )}What alternative solutions did you explore? (Optional)
We used getActiveRouteWithoutParams instead of getReportRHPActiveRoute.
// src/components/ReportActionItem/MoneyRequestView.tsx#L538 {shouldShowReceiptEmptyState && ( <ReceiptEmptyState hasError={hasErrors} disabled={!canEditReceipt} onPress={() => Navigation.navigate( ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute( CONST.IOU.ACTION.EDIT, iouType, transaction?.transactionID ?? '-1', report?.reportID ?? '-1', - Navigation.getReportRHPActiveRoute(), + Navigation.getActiveRouteWithoutParams(), ), ) } /> )}Details
POCScreen.Recording.2024-09-29.at.14.52.46.mov
Nodebrute commentedon Sep 29, 2024
Edited by proposal-police: This proposal was edited at 2024-09-29 20:35:32 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to drag and drop receipt to Upload receipt RHP
What is the root cause of that problem?
We recently started using
Navigation.getReportRHPActiveRoute()everywhere, but this issue only happens onScan pageApp/src/pages/iou/request/step/IOURequestStepScan/index.tsx
Line 698 in 3047c1b
It's because
shouldShowWrapperwill befalseand the top part will be cut offApp/src/pages/iou/request/step/IOURequestStepScan/index.tsx
Line 698 in 3047c1b
What changes do you think we should make in order to solve the problem?
We can create a new variable
const isEditing = action === CONST.IOU.ACTION.EDITand we can pass it hereApp/src/pages/iou/request/step/IOURequestStepScan/index.tsx
Line 698 in 3047c1b
We should also fix this in IOURequestStepScan/index.native.tsx file
We should check for other pages too where we have this issue and fix it
What alternative solutions did you explore? (Optional)
Or we can do something like this here
Alternative 2
Pass shouldShowWrapper here
App/src/pages/iou/request/step/IOURequestStepScan/index.tsx
Line 698 in 3047c1b
melvin-bot commentedon Sep 30, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
huult commentedon Sep 30, 2024
Proposal Update
NikkiWines commentedon Sep 30, 2024
Looks like this is already being resolved here - asked for a status update there.
rayane-d commentedon Sep 30, 2024
The linked PR fixes this blocker and is ready for merging and cherry-picking to staging
luacmartins commentedon Sep 30, 2024
Thank you @rayane-djouah!
luacmartins commentedon Sep 30, 2024
PR merged and being CPed
luacmartins commentedon Sep 30, 2024
Confirmed fix on staging.