[Pending / Scanning] Message containing a report says it is from the workspace name instead of the cardholder's name

@kevinksullivan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726081403491199

Action Performed:

Get assigned a >$0 limit on cardtest.expensify.com domain
Navigate to NewDot in your test account, and go to Settings > Wallet > Expensify Card > Reveal details (on virtual card)
Navigate to this paypal link and select “buy” on the first button on that screen, and use your virtual card details to make the purchase.
Check workspace chat

Cardholder's name displayed in report

Message containing a report says it is from the workspace name. Same issue observed for IOUs as well

Unknown

Which of our officially supported platforms is this issue occurring on?

Add any screenshot/video evidence

@miljakljajic

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Discussing broader expected behavior here

Pasting from slack:

Seems the issue might is from this line here, which is causing the second part of this line to always be true

 const isWorkspaceActor = isInvoiceReport || (ReportUtils.isPolicyExpenseChat(report) && (!actorAccountID || displayAllActors));

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.