Repository navigation
Expense - Incorrect avatar for pay preview and missing avatar & username after submitting expense #49889
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Action Performed:
- Go to staging.new.expensify.com
- Go to DM
- Click + > Pay someone
- Enter amount > Pay the user
- Click + > Submit expense
- Submit expense to the user
Expected Result:
In Step 4, the report preview avatar for "paying preview" should display the sender avatar because the sender pays the money
In Step 6, when submitting expense after paying the user, the expense preview will have the sender avatar and sender name
Actual Result:
In Step 4, the report preview avatar for "paying preview" displays the receiver avatar instead of sender avatar
In Step 6, when submitting expense after paying the user, the expense preview is missing sender avatar and sender name briefly, then it appears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Sep 28, 2024
Triggered auto assignment to @MonilBhavsar (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Sep 28, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MonilBhavsar commentedon Sep 30, 2024
@grgia @eh2077 this seems to be coming from #49172
For pay requests, childOwnerAccountID is the payee and not the payer. Also, the report action is always ReportPreview.
grgia commentedon Sep 30, 2024
Looking now
grgia commentedon Sep 30, 2024
This seems to be a BE problem.
Why are pay requests setting the childOwnerAccountID to the payee?
melvin-bot commentedon Sep 30, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jasperhuangg commentedon Sep 30, 2024
We reverted the problematic PR #49945. Gonna remove the label but keep this open so @grgia can fix this in a followup.
melvin-bot commentedon Sep 30, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
MonilBhavsar commentedon Oct 10, 2024
closing as PR was reverted and issue was fixed