Repository navigation
Category rules - "Approver" is enabled when "Add approvals" is still disabled in Workflows #48977
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Issue was found when executing this PR: #48171
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
- Rules feature is enabled.
- Go to staging.new.expensify.com
- Go to workspace settings > Categories.
- Click on any category.
- Note that the message under Approver says that "add approvals to unlock this feature".
- Go to Rules.
- Note that the same message is also said for "Prevent self-approvals".
- Go to workspace settings.
- Enable workflows, but do not enable Add approvals in Workflows page.
- Go back to Rules.
- Note that "Prevent self-approvals" is disabled because Add approvals feature is not enabled so the feature remains locked.
- Go back to the same category in Step 3.
- Note that Approver feature is unlocked even though Add approvals feature is not enabled.
Expected Result:
In Step 12, Approver feature should remain locked until Add approvals feature is enabled on Workflows page.
Actual Result:
In Step 12, Approver feature is unlocked when Add approvals feature is disabled on Workflows page, which is inconsistent with the behavior with "Prevent self-approvals" feature in Rules in Step 10.
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- [x ] MacOS: Desktop
Screenshots/Videos
Bug6599647_1726041745900.20240911_155552.mp4
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @mjasikowski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Sep 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Sep 11, 2024
We think that this bug might be related to #wave-control
Nodebrute commentedon Sep 11, 2024
Edited by proposal-police: This proposal was edited at 2023-11-04T12:30:45Z.
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Approver" is enabled when "Add approvals" is still disabled in Workflows
What is the root cause of that problem?
We are only checking if workflows are enabled
App/src/pages/workspace/categories/CategorySettingsPage.tsx
Line 271 in e9642dc
What changes do you think we should make in order to solve the problem?
We should use
const workflowApprovalsUnavailable = PolicyUtils.getWorkflowApprovalsUnavailable(policy);and then use it here instead of
areWorkflowsEnabledOptional: we can also change the condition here to
workflowApprovalsUnavailableWhat alternative solutions did you explore? (Optional)
mjasikowski commentedon Sep 11, 2024
tagging @WojtekBoman as the original author of #48171
BrtqKr commentedon Sep 11, 2024
#48325 (comment)
is this related?
12 remaining items
marcaaron commentedon Sep 16, 2024
Agree we should stick to the Design Doc on this one. It's hard to tell whether we are blocked on anything here, but sounds like @WojtekBoman is on the case. @mjasikowski I can take this off your hands since I am leading this project - but fine if you want to stick around 😄
mjasikowski commentedon Sep 20, 2024
@marcaaron feel free to take over, I'm OOO frequently now due to personal issues
melvin-bot commentedon Sep 20, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
marcaaron commentedon Sep 23, 2024
I see this has been fixed on staging so I think we can close it out.