[$250] Task – App crashes when click on assignee in existing task

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4989792
Email or phone of affected tester (no customers): applausetester+jpcategory_2@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/
Log in
Open any chat
Create a task without assignee
Open task details and click on assignee

Expected Result:

Assignee list opens

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Screenshots/Videos

2009.txt

Bug6609721_1726820372331.Assignee_crash.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021838194512143553982
Upwork Job ID: 1838194512143553982
Last Price Increase: 2024-09-23
Automatic offers:

jjcoffee | Reviewer | 104086587
nkdengineer | Contributor | 104086588

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@flodnv

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when click on assignee in existing task

What is the root cause of that problem?

Use 'report' before initialization

App/src/pages/tasks/TaskAssigneeSelectorModal.tsx

Line 127 in 4c9a3fb

if (report && !ReportUtils.isTaskReport(report)) {

What changes do you think we should make in order to solve the problem?

Delay using the report until the report is complete.

// .src/pages/tasks/TaskAssigneeSelectorModal.tsx#L127
    const report: OnyxEntry<Report> = useMemo(() => {
        if (!route.params?.reportID) {
            return;
        }

+        InteractionManager.runAfterInteractions(() => {
+            requestAnimationFrame(() => {
                if (report && !ReportUtils.isTaskReport(report)) {
                    Navigation.isNavigationReady().then(() => {
                        Navigation.dismissModal(report.reportID);
                    });
                }
+            });
+        });

        return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    }, [reports, route]);

Details

POC

Screen.Recording.2024-09-20.at.16.04.35.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes

What is the root cause of that problem?

The report is used before it's initialize

App/src/pages/tasks/TaskAssigneeSelectorModal.tsx

Lines 123 to 129 in 4c9a3fb

    
           const report: OnyxEntry<Report> = useMemo(() => { 
        
               if (!route.params?.reportID) { 
        
                   return; 
        
               } 
        
               if (report && !ReportUtils.isTaskReport(report)) { 
        
                   Navigation.isNavigationReady().then(() => { 
        
                       Navigation.dismissModal(report.reportID);

What changes do you think we should make in order to solve the problem?

Update this to get the report data from reports to check it's task report or not

const report: OnyxEntry<Report> = useMemo(() => {
    if (!route.params?.reportID) {
        return;
    }
    const reportOnyx = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    if (reportOnyx && !ReportUtils.isTaskReport(reportOnyx)) {
        Navigation.isNavigationReady().then(() => {
            Navigation.dismissModal(reportOnyx.reportID);
        });
    }
    return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
}, [reports, route]);

What alternative solutions did you explore? (Optional)

Or we can move the navigate logic to another useEffect

const report: OnyxEntry<Report> = useMemo(() => {
    if (!route.params?.reportID) {
        return;
    }
    return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
}, [reports, route]);

useEffect(() => {
    if (report && !ReportUtils.isTaskReport(report)) {
        Navigation.isNavigationReady().then(() => {
            Navigation.dismissModal(report.reportID);
        });
    }
}, [report]);

Why did this just start happening upon this deploy? What PR caused this?

@flodnv

@flodnv Maybe it is caused by #48325. I tried to revert to the latest commit in production and install node-module again and the bug didn't happen. The bug started happening when I reverted to the first different between production and staging and re-install node-module again.

Ugh, automation failed and the payment date should have been yesterday. I'll work on the payment process tomorrow.

The PR that introduced the bug has been identified. Link to the PR: I wasn't able to identify an offending PR
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes - if one doesn't already exist
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open any chat
Create a task without an assignee
Open task details and click on assignee
Verify that the assignee page appears

Do we agree 👍 or 👎

I think this will be caught during regular regression tests, since we have many tests on tasks.

@nkdengineer

Payouts due: 10-01-2024

Contributor: $250 @nkdengineer
Contributor+: $250 @jjcoffee

Upwork job is here.

Closing - I believe that I sent the payment via Upwork, but something looks off in Upwork. Please reply if you didn't get the payment and I'll fund the new job I sent your way. I'll return later to complete the regression test.

@alexpensify

@alexpensify I didn't receive any payment, just the notification that the contract has ended and weirdly another about accepting an offer (I've accepted this).

@alexpensify

@alexpensify Same for me, the job just closed without payment. I accepted the new 2nd offer though, it can be paid out there.

Thanks for these updates! There is an issue an Upwork that is being investigated to address the payment process. I'm going to hold until there is a fix. Convo: https://expensify.slack.com/archives/C01GTK53T8Q/p1728319262830679

@jjcoffee

@jjcoffee and @nkdengineer, our team figured out the Upwork bug, and I tried to complete the payment via another payment path in Upwork. Their support team is working on a permanent fix for the bug. I'd really appreciate it if you could confirm today's payment sent successfully under the new contract. Thanks!

@alexpensify

@alexpensify Yes it was sent for me 💯 Thanks!

Me too, thank you!

Awesome, thanks for hanging in there with me. This bug is a wild one on the Upwork side.

Navigation Menu

Repository navigation

[$250] Task – App crashes when click on assignee in existing task #49514

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

30 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const report: OnyxEntry<Report> = useMemo(() => {
	if (!route.params?.reportID) {
	return;
	}
	if (report && !ReportUtils.isTaskReport(report)) {
	Navigation.isNavigationReady().then(() => {
	Navigation.dismissModal(report.reportID);

[$250] Task – App crashes when click on assignee in existing task #49514

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 20, 2024

melvin-bot commented on Sep 20, 2024

github-actions commented on Sep 20, 2024

huult commented on Sep 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

nkdengineer commented on Sep 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

flodnv commented on Sep 20, 2024

nkdengineer commented on Sep 20, 2024

30 remaining items

alexpensify commented on Oct 2, 2024

jjcoffee commented on Oct 3, 2024

luacmartins commented on Oct 3, 2024

alexpensify commented on Oct 4, 2024

alexpensify commented on Oct 4, 2024

jjcoffee commented on Oct 7, 2024

nkdengineer commented on Oct 7, 2024

alexpensify commented on Oct 7, 2024

alexpensify commented on Oct 8, 2024

nkdengineer commented on Oct 9, 2024

jjcoffee commented on Oct 9, 2024

alexpensify commented on Oct 9, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions