Repository navigation
Deploy Checklist: New Expensify 2024-08-02 #46687
Description
Release Version: 9.0.16-8
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Fix send validate code in Validation Form #45395
- Fix distance changes to incorrect value when the waypoint is changed without saving #45744
- Replace
addresswithaddressesfor private personal details #45751 - fix: add receipt name when track expense #45752
- fix(PopoverMenu): fix opening external links #45762
- fix: multiple chat reports picked for onboarding #45785
- fix: Split - App allows splitting when the sum of splits is not equal to the total amount #46175
- advanced filters category #46197
- Offline and errors pattern in Sage Intacct integration #46294
- [No QA] Update en.ts #46332
- Fix chat list in RHP auto scroll down when updating money request fields #46353
- Replace Enable your wallet with Add personal bank account task #46359
- fix: Context menu - Unable to add reaction by Enter key. #46379
- Add delay before calling reconnect when server is back up #46399
- fix: Partially approved expenses are not GBR'ed in LHN #46467
- Create description, merchant and reportID filters #46477
- Use new Search query syntax when calling api #46481
- Update node version for QSP #46504
- fix: use
KeyboardAvoidingViewfrom keyboard controller #46513 - [NoQA] FIX / ProposalPolice™ GH Actions Workflow - Graceful Fail (Solves Notifications on Fail Issue) #46550
- fix: disable editing money request of archived workspace #46560
- Fullstory component properties added all children components unmasked #46568
- [No QA] electron-updater: Fix conflicting downloads #46596
- [NoQA] fix: test runner compilation #46597
- [No QA] Code clean up, change variable name and add comment in lhn option list #46632
- [No QA] Adding QBO images for Help Site rewrites #46634
- perf: access personal details directly instead of using Array.find #46665
- [No QA] Update Sage-Intacct-Troubleshooting.md #46669
- [No QA] Use GitHub-generated release notes #46688
- [CP Staging] Revert "fix: use
KeyboardAvoidingViewfrom keyboard controller" #46749 - [CP Staging] Revert "fix: add receipt name when track expense" #46751
- Wrap in Modal.close callback to fix IOS #46755
- Fix workspace currency isn't used when opening the money request page in workspace chat #46756
- Revert "Fix send validate code in Validation Form" #46846
- [CP Staging] Wrap onSelected that opens another modal in Modal.close #46847
Deploy Blockers:
- Track expense -Self DM turns to skeleton loading with RBR on LHN when submitting track expense #46718
- [PAID] [Search v2.1] - Sorting on Drafts and Finished does not work at all #46720
- Contact Method – Received email twice when add new Contact Method #46723
- [HOLD for payment 2024-08-14] [HOLD for payment 2024-08-13] [$250] Workspace - Default currency set in workspace is not displayed in BNP while submit expense in WS chat #46727
- Invoice - Improve the email when an invoice is sent over NewDot #46731
- Chat - Conversation doesn't expand to full view after completing editing a message #46743
- Search - Keyboard overlaps the conversation opened from search results/start chat #46744
- [$250] Bank account - Date of birth page is not full screen if keyboard is not previously dismissed #46745
- [HOLD for payment 2024-08-14] [HOLD for payment 2024-08-13] iOS - Distance - Unable to delete waypoint from 3-dot menu #46746
- [HOLD for payment 2024-08-14] [HOLD for payment 2024-08-13] [$250] Xero - Unable disconnect: a warning modal doesn't shown #46764
- [$250] Group - App crash when removing a member on the process splitting expense #46805
- Group - App crash when removing a member on the process splitting expense #46806
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Aug 2, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.16-0 🚀
mvtglobally commentedon Aug 2, 2024
Regression is at 40% left
Blockers
#46718
#46720
#46727
#46731
Beamanator commentedon Aug 2, 2024
#46749 fixed these 3 blockers (checking them all off):
mvtglobally commentedon Aug 5, 2024
Regression is a few steps left
Unchecked PRs
#45395 - Pending validation on iOS and Android
#45752 - is failing #46718. Issue closed checking off
#46353 is failing with KI #45434. Repro in prod checking off
#46359 - is failing with #46231, but it seems to be reverted. Pls double check internally
#46560 - is failing with KI #45851. Checking off as repro in PROD
#46568 - is pending validation on all platforms
Checking CP
Blockers
#46727
#46746
#46764
mvtglobally commentedon Aug 5, 2024
Regression is completed
Unchecked PRs
#46359 - is failing with #46231, but it seems to be reverted. Pls double check internally
#46568 - Can you pls help us with more specific test steps. Team validated regression flows in general, but anything specific to check here?
Blockers
#46727
#46746
#46764
#46805
roryabraham commentedon Aug 5, 2024
#46727 is fixed, checking it off
roryabraham commentedon Aug 5, 2024
#46746 is fixed, checking it off
marcaaron commentedon Aug 6, 2024
Demoting #46805
marcaaron commentedon Aug 6, 2024
Adding #46723 as it is an App blocker not a web blocker
marcaaron commentedon Aug 6, 2024
No more blockers. Android “Switched Report Cached” timings look kind of elevated, but not terrible. And I'm not sure what to attribute that to. It's also worse today compared to over the weekend so I suspect it's that more people are around testing.
I'd like to get this deploy out so we can maybe get another one in before DBSEC. But will ask in #newdot-quality if someone can investigate.
marcaaron commentedon Aug 6, 2024