[HOLD for payment 2024-08-14] [HOLD for payment 2024-08-13] [$250] Workspace - Default currency set in workspace is not displayed in BNP while submit expense in WS chat

@bfitzexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4805490
Email or phone of affected tester (no customers): applausetester+ck0208@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Slack conversation:

Action Performed:

Precondition: Create a new expensifail account on ND site & create a new workspace

Go to Workspace settings >> tap on Profile menu
Set the workspace currency to something different that your local currency
Navigate to the workspace chat
Tap on + icon in composer
Select Submit expense

Expected Result:

The same currency that is set in workspace profile settings should display in BNP while submitting expense in workspace chat

Actual Result:

User's local currency get displayed in BNP while submit expense in WS chat though user has set a different currency in WS settings

Note: Correct default currency get reflected in BNP after refreshing the workspace chat page & then selecting submit expense opetion

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6560237_1722607924664.Recording__133.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012cb00b4b68f61310
Upwork Job ID: 1819442698262740619
Last Price Increase: 2024-08-02

Issue Owner

Current Issue Owner: @bfitzexpensify

@carlosmiceli

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think this issue might be related to the #collect project.

Production

Recording.2693.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default workspace currency isn't used when opening submit expense.

What is the root cause of that problem?

When we start a money request, we will initialize the data here, including the currency from the policy.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 95 to 100 in fefda46

    
           useEffect(() => { 
        
               if (transaction?.reportID === reportID) { 
        
                   return; 
        
               } 
        
               IOU.initMoneyRequest(reportID, policy, isFromGlobalCreate, transactionRequestType.current); 
        
           }, [transaction, policy, reportID, iouType, isFromGlobalCreate]);

However, policy is initially undefined and we only re-init when the reportID is different or when changing the tab.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 110 to 118 in fefda46

    
           const resetIOUTypeIfChanged = useCallback( 
        
               (newIOUType: IOURequestType) => { 
        
                   if (transaction?.iouRequestType === newIOUType) { 
        
                       return; 
        
                   } 
        
                   IOU.initMoneyRequest(reportID, policy, isFromGlobalCreate, newIOUType); 
        
               }, 
        
               [policy, reportID, isFromGlobalCreate, transaction], 
        
           );

This is because the policy depends on the report onyx,

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 184 to 190 in fefda46

    
           export default withOnyx<IOURequestStartPageProps, IOURequestStartPageOnyxProps>({ 
        
               report: { 
        
                   key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT}${route?.params?.reportID}`, 
        
               }, 
        
               policy: { 
        
                   key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`, 
        
               },

and it's a known issue if the onyx depends on another onyx as I explained in my proposal on this old issue. In our case, the report is initially undefined for the policy onyx key function.

Weirdly, this only started to happen after #45762, specifically the PopoverMenu file changes. Before the PR, the report is still undefined for the policy key function, but the component isn't rendered until the policy is available.

What changes do you think we should make in order to solve the problem?

Even though it started to happen after #45762, the root cause is in the withOnyx. Because withOnyx is deprecated, we can just migrate IOURequestStartPage to using useOnyx which won't have the withOnyx bug.

@mollfpr

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix workspace currency isn't used when opening the money request page in workspace chat #46756

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

@mollfpr requires payment through NewDot Manual Requests
@bernhardoj requires payment through NewDot Manual Requests

@mollfpr

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mollfpr

Payment summary:

@mollfpr to be paid $250 for C+ work via manual request
@bernhardoj to be paid $250 for contributor work via manual request

Requested in ND.

@mollfpr

Payment Summary

Upwork Job

Reviewer: @mollfpr owed $250 via NewDot
Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@bfitzexpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1819442698262740619/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@bernhardoj

$250 approved for @bernhardoj

@mollfpr

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I couldn't find the offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be good.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Prerequisite:
Go to Workspace settings and set the workspace currency to something different than your local currency

Navigate to the workspace chat
Tap on the + icon in the composer
Select Submit expense
Verify the currency shown is the workspace currency
👍 or 👎

Works for me! Proposed in https://github.com/Expensify/Expensify/issues/420653. Closing this out

@mollfpr

$250 approved for @mollfpr

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-14] [HOLD for payment 2024-08-13] [$250] Workspace - Default currency set in workspace is not displayed in BNP while submit expense in WS chat #46727

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

30 remaining items

Payment Summary

BugZero Checklist (@bfitzexpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	useEffect(() => {
	if (transaction?.reportID === reportID) {
	return;
	}
	IOU.initMoneyRequest(reportID, policy, isFromGlobalCreate, transactionRequestType.current);
	}, [transaction, policy, reportID, iouType, isFromGlobalCreate]);

	const resetIOUTypeIfChanged = useCallback(
	(newIOUType: IOURequestType) => {
	if (transaction?.iouRequestType === newIOUType) {
	return;
	}
	IOU.initMoneyRequest(reportID, policy, isFromGlobalCreate, newIOUType);
	},
	[policy, reportID, isFromGlobalCreate, transaction],
	);

	export default withOnyx<IOURequestStartPageProps, IOURequestStartPageOnyxProps>({
	report: {
	key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT}${route?.params?.reportID}`,
	},
	policy: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`,
	},

[HOLD for payment 2024-08-14] [HOLD for payment 2024-08-13] [$250] Workspace - Default currency set in workspace is not displayed in BNP while submit expense in WS chat #46727

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 2, 2024

melvin-bot commented on Aug 2, 2024

github-actions commented on Aug 2, 2024

izarutskaya commented on Aug 2, 2024

izarutskaya commented on Aug 2, 2024

bernhardoj commented on Aug 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

30 remaining items

melvin-bot commented on Aug 7, 2024

melvin-bot commented on Aug 7, 2024

bfitzexpensify commented on Aug 13, 2024

bernhardoj commented on Aug 13, 2024

melvin-bot commented on Aug 14, 2024

Payment Summary

BugZero Checklist (@bfitzexpensify)

JmillsExpensify commented on Aug 14, 2024

mollfpr commented on Aug 14, 2024

bfitzexpensify commented on Aug 15, 2024

JmillsExpensify commented on Aug 20, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions