[HOLD for payment 2024-08-19] [$250] LHN – Concierge chat opens when change priority mode to Most recent

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4761236&group_by=cases:section_id&group_order=asc&group_id=296775
Email or phone of affected tester (no customers): gocemate+a686@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Login with new gmail account
Go to Account settings> Preferences> Focus
Go to Account settings> Preferences> Most recent

Expected Result:

User should stay on Preferences page

Actual Result:

User navigates to Concierge chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6551399_1721815858022.Recording__3548.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cd28acd2df01cf0e
Upwork Job ID: 1816460956793747307
Last Price Increase: 2024-07-25
Automatic offers:

DylanDylann | Reviewer | 103326560
nkdengineer | Contributor | 103326561

Issue Owner

Current Issue Owner: @mallenexpensify

@arosiclair

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #vip-vsp

Hm interestingly, it doesn't happen if you already have multiple chats or rooms. Doesn't seem like something worth blocking for, going to demote.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User navigates to Concierge chat

What is the root cause of that problem?

When the onboarding data is changed we resolve the onboarding value here. If we log in with a new account and complete the onboarding flow and then isOnboardingFlowCompleted the second time, isOnboardingFlowStatusKnownPromise promise will return the onboarding data to the old data because after we complete the onboarding flow, the onboarding data is changed and we don't reset the isOnboardingFlowStatusKnownPromise promise.

App/src/libs/actions/Welcome.ts

Line 178 in b0f810d

resolveOnboardingFlowStatus(value);

The problem happens when we change the priority mode from focus to recent, we have a logic here to call the OpenApp API again.

App/src/libs/actions/App.ts

Lines 72 to 76 in b0f810d

    
           if (nextPriorityMode === CONST.PRIORITY_MODE.DEFAULT && priorityMode === CONST.PRIORITY_MODE.GSD) { 
        
               // eslint-disable-next-line @typescript-eslint/no-use-before-define 
        
               openApp(); 
        
           } 
        
           priorityMode = nextPriorityMode;

It leads isLoadingApp changing and this useEffect is triggered again. As I explained above because the onboarding data is the old data onNotCompleted callback is called and the navigation state is reset. Then the concierge chat is opened as the recent chat.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 59 to 63 in b0f810d

    
           Welcome.isOnboardingFlowCompleted({ 
        
               onNotCompleted: () => { 
        
                   const {adaptedState} = getAdaptedStateFromPath(ROUTES.ONBOARDING_ROOT, linkingConfig.config); 
        
                   navigationRef.resetRoot(adaptedState); 
        
               },

What changes do you think we should make in order to solve the problem?

We should reset the isOnboardingFlowStatusKnownPromise promise when the onboarding data is changed

isOnboardingFlowStatusKnownPromise = new Promise<OnboardingData>((resolve) => {
    resolveOnboardingFlowStatus = resolve;
});
resolveOnboardingFlowStatus(value);

App/src/libs/actions/App.ts

Lines 72 to 76 in b0f810d

    
           if (nextPriorityMode === CONST.PRIORITY_MODE.DEFAULT && priorityMode === CONST.PRIORITY_MODE.GSD) { 
        
               // eslint-disable-next-line @typescript-eslint/no-use-before-define 
        
               openApp(); 
        
           } 
        
           priorityMode = nextPriorityMode;

What alternative solutions did you explore? (Optional)

Or we can revert the change in this PR #45327 to use an onboarding variable and update it every time the onboarding data changes.

App/src/libs/actions/App.ts

Lines 72 to 76 in b0f810d

    
           if (nextPriorityMode === CONST.PRIORITY_MODE.DEFAULT && priorityMode === CONST.PRIORITY_MODE.GSD) { 
        
               // eslint-disable-next-line @typescript-eslint/no-use-before-define 
        
               openApp(); 
        
           } 
        
           priorityMode = nextPriorityMode;

There were regressions fixed by other contributors:
#46110 (comment)
#46110 (comment)

@olya-ivanochko

📣 @olya-ivanochko! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@DylanDylann

@DylanDylann , @nkdengineer , can you confirm if there are regressions on this issue? See one revert after staging in the PR. Thx

@mallenexpensify

@mallenexpensify We had a regression on this issue and I fixed it here. All revert PRs were closed.

@nkdengineer

Thx @nkdengineer per CONTRIBUTING.md

a 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue

Contributor: @nkdengineer paid $125 via Upwork
Contributor+: @DylanDylann paid $125 via Upwork.

@DylanDylann plz complete the BZ checklist above. , thanks

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Login with new gmail account
Go to Account settings> Preferences> Focus
Go to Account settings> Preferences> Most recent
Verify that: User should stay on Preferences page

Do we agree 👍 or 👎

@mallenexpensify

Not overdue. Waiting for @mallenexpensify

@DylanDylann

Thanks @DylanDylann , all set!

https://github.com/Expensify/Expensify/issues/423313

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-19] [$250] LHN – Concierge chat opens when change priority mode to Most recent #46110

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

39 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (nextPriorityMode === CONST.PRIORITY_MODE.DEFAULT && priorityMode === CONST.PRIORITY_MODE.GSD) {
	// eslint-disable-next-line @typescript-eslint/no-use-before-define
	openApp();
	}
	priorityMode = nextPriorityMode;

	Welcome.isOnboardingFlowCompleted({
	onNotCompleted: () => {
	const {adaptedState} = getAdaptedStateFromPath(ROUTES.ONBOARDING_ROOT, linkingConfig.config);
	navigationRef.resetRoot(adaptedState);
	},

[HOLD for payment 2024-08-19] [$250] LHN – Concierge chat opens when change priority mode to Most recent #46110

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 24, 2024

github-actions commented on Jul 24, 2024

lanitochka17 commented on Jul 24, 2024

francoisl commented on Jul 24, 2024

nkdengineer commented on Jul 25, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

39 remaining items

olya-ivanochko commented on Aug 19, 2024

melvin-bot commented on Aug 19, 2024

mallenexpensify commented on Aug 20, 2024

nkdengineer commented on Aug 20, 2024

mallenexpensify commented on Aug 21, 2024

DylanDylann commented on Aug 21, 2024

DylanDylann commented on Aug 26, 2024

mallenexpensify commented on Aug 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions