Skip to content

[HOLD for payment 2024-08-19] [$250] Sign in – Onboarding modal is missing in new tab #47054

Closed
Closed
[HOLD for payment 2024-08-19] [$250] Sign in – Onboarding modal is missing in new tab#47054
Assignees
trjExpensifyNikkiWinesishpaul777
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v.9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): ponikarchuks+98824@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. In Sign in page enter new Gmail account
  3. When Onboarding modal appears open new tab and paste https://staging.new.expensify.com/

Expected Result:

Onboarding modal is present in new tab

Actual Result:

Onboarding modal is missing in new tab

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6565266_1723093480769.Onboarding_modal.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f33db55519f8fc02
  • Upwork Job ID: 1821535504288913507
  • Last Price Increase: 2024-08-08
  • Automatic offers:
    • ishpaul777 | Contributor | 103468942
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 8, 2024
  2. melvin-bot
    assigned
    trjExpensify
    on Aug 8, 2024

  3. melvin-bot commented on Aug 8, 2024

    @melvin-bot
    melvin-botBot
    on Aug 8, 2024 – with Melvin Bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot
    assigned
    NikkiWines
    on Aug 8, 2024

  5. melvin-bot commented on Aug 8, 2024

    @melvin-bot
    melvin-botBot
    on Aug 8, 2024 – with Melvin Bot

    Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Aug 8, 2024

  7. github-actions commented on Aug 8, 2024

    @github-actions
    github-actionsBot
    on Aug 8, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. IuliiaHerets commented on Aug 8, 2024

    @IuliiaHerets
    IuliiaHerets
    on Aug 8, 2024
    Author

    We think that this bug might be related to #vip-vsb

  9. trjExpensify commented on Aug 8, 2024

    @trjExpensify
    trjExpensify
    on Aug 8, 2024
    Contributor

    So strange. Can't reproduce with private domain, can reproduce with public domain:

    2024-08-08_14-11-43.mp4
  10. trjExpensify
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 8, 2024

  11. 46 remaining items

  12. melvin-bot commented on Aug 12, 2024

    @melvin-bot
    melvin-botBot
    on Aug 12, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ishpaul777] Determine if we should create a regression test for this bug.
    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  13. NikkiWines commented on Aug 14, 2024

    @NikkiWines
    NikkiWines
    on Aug 14, 2024
    Contributor

    @NikkiWines Should I eligible for compenstation since this #47097 uses my proposal #47054 (comment)?. The only difference is it creates a new function to resolve the onboarding promise.

    @dominictb Yes, since the core logic used in the fix is the same, I think some compensation should be provided as the issue had been marked as external and help wanted at the time of your proposal being made. @trjExpensify what do you think?

  14. trjExpensify commented on Aug 14, 2024

    @trjExpensify
    trjExpensify
    on Aug 14, 2024
    Contributor

    I think we can do a partial payment agreed, so when this comes around, I'll be sure to send an offer for $125.

  15. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Aug 18, 2024

  16. ishpaul777 commented on Aug 19, 2024

    @ishpaul777
    ishpaul777
    on Aug 19, 2024
    Contributor

    Ready for payment 🎉

  17. ishpaul777 commented on Aug 21, 2024

    @ishpaul777
    ishpaul777
    on Aug 21, 2024
    Contributor

    gentle bump @trjExpensify : )

  18. melvin-bot commented on Aug 21, 2024

    @melvin-bot
    melvin-botBot
    on Aug 21, 2024 – with Melvin Bot

    @trjExpensify, @NikkiWines, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  19. trjExpensify commented on Aug 23, 2024

    @trjExpensify
    trjExpensify
    on Aug 23, 2024
    Contributor

    Yup, I've been OoO. Payment summary as follows:

    @ishpaul777 paid, @dominictb I've reached out to you for your Upwork profile.

  20. melvin-bot
    removed
    Overdue
    on Aug 23, 2024

  21. trjExpensify commented on Aug 23, 2024

    @trjExpensify
    trjExpensify
    on Aug 23, 2024
    Contributor

    @dominictb offer now sent.

  22. dominictb commented on Aug 23, 2024

    @dominictb
    dominictb
    on Aug 23, 2024
    Contributor

    @trjExpensify Offer accepted 🙏

  23. trjExpensify commented on Aug 23, 2024

    @trjExpensify
    trjExpensify
    on Aug 23, 2024
    Contributor

    Paid, closing!

  24. trjExpensify
    closed this as completedon Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions