Skip to content

[HOLD for payment 2024-08-09] [$250] Categorizing - Page blinks after selecting a category during categorization #46063

Closed
Closed
[HOLD for payment 2024-08-09] [$250] Categorizing - Page blinks after selecting a category during categorization#46063
Assignees
jliexpensifyroryabrahambernhardojeh2077
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Jul 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Account has no workspace
  1. Go to staging.new.expensify.com
  2. Go to self DM
  3. Track a manual expense
  4. Click Categorize it from the actionable whisper
  5. Select any category

Expected Result:

Page will not blink after selecting a category during categorization

Actual Result:

Page blinks after selecting a category during categorization

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6550721_1721752108588.bandicam_2024-07-24_00-25-27-455.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f0f7b8664b135266
  • Upwork Job ID: 1815855751043659627
  • Last Price Increase: 2024-07-23
  • Automatic offers:
    • eh2077 | Reviewer | 103288936
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 23, 2024
  2. melvin-bot
    assigned
    roryabraham
    on Jul 23, 2024

  3. melvin-bot commented on Jul 23, 2024

    @melvin-bot
    melvin-botbot
    on Jul 23, 2024 – with Melvin Bot

    Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    on Jul 23, 2024

  5. github-actions commented on Jul 23, 2024

    @github-actions
    github-actionsbot
    on Jul 23, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  6. lanitochka17 commented on Jul 23, 2024

    @lanitochka17
    lanitochka17
    on Jul 23, 2024
    Author

    We think that this bug might be related to #vip-vsp

  7. francoisl commented on Jul 23, 2024

    @francoisl
    francoisl
    on Jul 23, 2024
    Contributor

    The flicker is barely noticeable, not sure it's worth blocking on this.

    There's also this open issue about the chat view flickering - not sure it's related but could be.

  8. roryabraham
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    HourlyKSv2
    on Jul 23, 2024

  9. 32 remaining items

  10. melvin-bot
    changed the title [-][$250] Categorizing - Page blinks after selecting a category during categorization[/-] [+][HOLD for payment 2024-08-09] [$250] Categorizing - Page blinks after selecting a category during categorization[/+] on Aug 2, 2024

  11. melvin-bot commented on Aug 2, 2024

    @melvin-bot
    melvin-botbot
    on Aug 2, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot
    removed
    ReviewingHas a PR in review
    on Aug 2, 2024

  13. melvin-bot commented on Aug 2, 2024

    @melvin-bot
    melvin-botbot
    on Aug 2, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-09. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Aug 2, 2024

    @melvin-bot
    melvin-botbot
    on Aug 2, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
    • [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@eh2077] Determine if we should create a regression test for this bug.
    • [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  15. eh2077 commented on Aug 7, 2024

    @eh2077
    eh2077
    on Aug 7, 2024
    Contributor

    Checklist

    • [@eh2077] The PR that introduced the bug has been identified. Link to the PR: I don't think there's a PR that's responsible for this. It's an edge use case we want to polish.
    • [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: No
    • [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No
    • [@eh2077] Determine if we should create a regression test for this bug. Yes, it's actually a new feature we added though it's an edge case

    Regression test

    Precondition:

    • Account has no workspace
    1. Go to self DM
    2. Track a manual expense
    3. Click Categorize it from the actionable whisper
    4. Select any category
    5. Verify the confirmation page opens without any blink
    6. Press the Category field to edit it
    7. Change to a different category
    8. Press the back button
    9. Verify the confirmation page closes

  16. jliexpensify commented on Aug 8, 2024

    @jliexpensify
    jliexpensify
    on Aug 8, 2024
    Contributor

    Payment Summary

  17. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Aug 8, 2024

  18. bernhardoj commented on Aug 9, 2024

    @bernhardoj
    bernhardoj
    on Aug 9, 2024
    Contributor

    Requested in ND.

  19. JmillsExpensify commented on Aug 9, 2024

    @JmillsExpensify
    JmillsExpensify
    on Aug 9, 2024
    Contributor

    $250 approved for @bernhardoj

  20. melvin-bot
    added
    Overdue
    on Aug 12, 2024

  21. jliexpensify commented on Aug 12, 2024

    @jliexpensify
    jliexpensify
    on Aug 12, 2024
    Contributor

    Apologies for the delay @eh2077 - paid and job closed!

  22. jliexpensify
    closed this as completedon Aug 12, 2024
  23. melvin-bot
    removed
    Overdue
    on Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions