Skip to content

Thread - App flickers & returns to main chat when leaving and reentering thread #45834

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Send a message.
  4. Open the message in thread > Send a message in thread.
  5. Leave the thread via thread header.
  6. Click on the thread subtitle to return to main chat.
  7. Open the thread again from the main chat.
  8. Note that app auto returns to main chat.

DM issue

  1. Go to staging.new.expensify.com
  2. Go to DM.
  3. Send a message.
  4. Open the message in thread > Send a message in thread.
  5. Leave the thread via thread header.
  6. Click on the thread subtitle to return to main chat.
  7. Open the thread again from the main chat.
  8. Note that thread flickers briefly.

Expected Result:

No flicker issue and app will remain on the same thread when leaving and reentering thread.

Actual Result:

  • In workspace chat, thread flickers and auto returns to main chat after leaving and reentering thread.
  • In DM, thread flickers briefly and remains on the same thread when leaving and reentering thread in DM.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6547839_1721477323941.20240720_200016.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @chiragsalian

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 20, 2024
  2. melvin-bot commented on Jul 20, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 20, 2024

    @melvin-bot

    Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jul 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. tsa321 commented on Jul 21, 2024

    @tsa321
    Contributor

    This seems related to my PR regarding loading the skeleton of the report screen (I believe only related to report action list). However, the loading is also displayed for the composer and header of the report, which are different components from the the report action list. I will investigate further.

  6. tsa321 commented on Jul 21, 2024

    @tsa321
    Contributor

    It seems like this is a backend issue. When user leaves the thread and returns to the parent report, and then goes back to the thread again, GetMissingOnyxMessages sets the report and report_actions to null.

    ss-2

  7. 34 remaining items

  8. muttmuure commented on Aug 6, 2024

    @muttmuure
    Contributor
  9. chiragsalian commented on Aug 21, 2024

    @chiragsalian
    Contributor

    oh whoops i thought this was an external issue. I'll try to catch up on this when i get the chance.

  10. moved this from LOW to CRITICAL in [#whatsnext] #qualityon Aug 27, 2024
  11. muttmuure commented on Aug 27, 2024

    @muttmuure
    Contributor

    Oh, I think I misunderstood what this issue was, I'm going to add it to UX reliability

  12. chiragsalian commented on Sep 3, 2024

    @chiragsalian
    Contributor

    Okay i finally got some free time to check this out today. I tested on main and staging and I'm unable to reproduce the issue.
    After i leave the thread, when i click into the thread again i only see an OpenReport network request. I do not see a GetMissingOnyxMessages request. Maybe this was resolved but a change in flow elsewhere.

    Can someone else retest and confirm if this issue still persists? @m-natarajan @tsa321 @muttmuure. If not we can close out this issue.

  13. tsa321 commented on Sep 4, 2024

    @tsa321
    Contributor

    I think this issue has been fixed. I am unable to reproduce it in staging.

  14. muttmuure commented on Sep 5, 2024

    @muttmuure
    Contributor

    OK seems to be fixed on staging for me

  15. muttmuure commented on Sep 5, 2024

    @muttmuure
    Contributor

    Going to close

  16. muttmuure commented on Sep 5, 2024

    @muttmuure
    Contributor

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersBugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions