You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@Julesssss should we be surfacing the expensify.cash details at all? I can't imagine how it would be useful to show anything that's not an email or phone number.
It is also an issue for real customers, here's my customer Sarah and I'm 100% sure these are all from messaging me:
Activity
melvin-bot commentedon Jul 12, 2024
Triggered auto assignment to @grgia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 12, 2024
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jul 12, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
1 remaining item
Julesssss commentedon Jul 12, 2024
Removing the blocker labels. This doesn't occur for new/typical users and only shows up for power users like the Expensify and Applause teams:
shubham1206agra commentedon Jul 12, 2024
Happening to my account too. But I am not in either category.
Tony-MK commentedon Jul 12, 2024
Tony-MK commentedon Jul 12, 2024
Hey @Julesssss and @shubham1206agra, Are there other specific contact methods that should be shown except if the partner name is
expensify.com?Julesssss commentedon Jul 12, 2024
Do you mean to replace the domain with Expensify?
Tony-MK commentedon Jul 12, 2024
Well, @Julesssss, this is an FE problem and some logins are visible.
I would like to know if any other
login?.partnerNameshould be displayed except for the Expensify domain.However, after testing with other domains I believe the solution works.
Thanks.
dominictb commentedon Jul 14, 2024
Dupe of #45266
rayane-d commentedon Jul 15, 2024
Happening to my account too
RachCHopkins commentedon Jul 15, 2024
@Julesssss should we be surfacing the expensify.cash details at all? I can't imagine how it would be useful to show anything that's not an email or phone number.
It is also an issue for real customers, here's my customer Sarah and I'm 100% sure these are all from messaging me:
Julesssss commentedon Jul 15, 2024
Closing as dupe of #45266.
Thanks @RachCHopkins,that does sound valid so lets continue to resolve on the above issue.