Skip to content

There are too many contact methods showing #45336

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720707891026509

Action Performed:

  1. Open app
  2. Go to settings > profile
  3. Click Contact methods

Expected Result:

Only the added contact methods should appear

Actual Result:

There are many contact emails are appearing

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-11.at.7.54.04.PM.mov

Snip - (4) New Expensify - Google Chrome

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 12, 2024
  2. melvin-bot commented on Jul 12, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jul 12, 2024

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jul 12, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 12, 2024
  6. 1 remaining item

  7. Julesssss commented on Jul 12, 2024

    @Julesssss
    Contributor

    Removing the blocker labels. This doesn't occur for new/typical users and only shows up for power users like the Expensify and Applause teams:

    Screenshot 2024-07-12 at 14 13 18

  8. shubham1206agra commented on Jul 12, 2024

    @shubham1206agra
    Contributor

    Happening to my account too. But I am not in either category.

  9. Tony-MK commented on Jul 12, 2024

    @Tony-MK
  10. Tony-MK commented on Jul 12, 2024

    @Tony-MK
    Contributor

    Hey @Julesssss and @shubham1206agra, Are there other specific contact methods that should be shown except if the partner name is expensify.com?

  11. Julesssss commented on Jul 12, 2024

    @Julesssss
    Contributor

    Hey @Julesssss and @shubham1206agra, Are there other specific contact methods that should be shown except if the partner name is expensify.com?

    Do you mean to replace the domain with Expensify?

  12. Tony-MK commented on Jul 12, 2024

    @Tony-MK
    Contributor

    Hey @Julesssss and @shubham1206agra, Are there other specific contact methods that should be shown except if the partner name is expensify.com?

    Do you mean to replace the domain with Expensify?

    Well, @Julesssss, this is an FE problem and some logins are visible.

    I would like to know if any other login?.partnerName should be displayed except for the Expensify domain.

    However, after testing with other domains I believe the solution works.

    Thanks.

  13. dominictb commented on Jul 14, 2024

    @dominictb
    Contributor

    Dupe of #45266

  14. rayane-d commented on Jul 15, 2024

    @rayane-d
    Contributor

    Happening to my account too

  15. RachCHopkins commented on Jul 15, 2024

    @RachCHopkins
    Contributor

    @Julesssss should we be surfacing the expensify.cash details at all? I can't imagine how it would be useful to show anything that's not an email or phone number.

    It is also an issue for real customers, here's my customer Sarah and I'm 100% sure these are all from messaging me:

    image

  16. Julesssss commented on Jul 15, 2024

    @Julesssss
    Contributor

    Closing as dupe of #45266.

    Thanks @RachCHopkins,that does sound valid so lets continue to resolve on the above issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions