Contact methods - 'expensify.cash-25ffc67..." is created after logging back into the account

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Logout from any account
Log back in
Go to account settings > Profile > Contact methods

Expected Result:

Ony added contact methods are displayed in contact methods

Actual Result:

Ony added contact methods are displayed in contact methods

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6538782_1720692944075.Contact_method_Issue.mp4

View all open jobs on GitHub

@puneetlath

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Ony added contact methods are displayed in contact methods

What is the root cause of that problem?

In ContactMethodsPage, the loginList data:

App/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

Lines 135 to 137 in 58e2575

loginList: {

key: ONYXKEYS.LOGIN_LIST,

},

contains the login data which has partnerName: "chat-expensify-com" but we do not need it in this page.

What changes do you think we should make in order to solve the problem?

We need to create a login list selector, that will remove that type of login data and use it in:

App/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

Lines 135 to 137 in 58e2575

loginList: {

key: ONYXKEYS.LOGIN_LIST,

},

and the other similar cases.
The selector function is something like:

selector: (data) => {
            return Object.fromEntries(
                Object.entries(data).filter(
                    ([key, value]) => value.partnerName !== 'chat-expensify-com'
                )
            );
        },

What alternative solutions did you explore? (Optional)

In the main solution, I am using partnerName !== 'chat-expensify-com' to filter the login data. We can also use partnerID if this prop to filter.

Proposal updated

Happening to my account too

@RachCHopkins

Hey @RachCHopkins. tagging you here as you pointed out that this is occurring for real customers.

Going to raise in Slack to find out what the expected behavior is here.

@nkuoch

@nkuoch I see you added getting the loginlist in Auth a couple weeks ago here.

It seems like that is most likely the cause of this issue as it seems like Login::getList is including these expensify.cash- logins. So we probably need to either filter them out after getting the results or write a different query that doesn't get these. What do you think?

@nkuoch

@nkuoch Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@nkuoch

Looks like the fix for this was merged and deployed. And it looks like it's working correctly. Thanks @nkuoch!

Navigation Menu

Repository navigation

Contact methods - 'expensify.cash-25ffc67..." is created after logging back into the account #45266

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal updated

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	loginList: {
	key: ONYXKEYS.LOGIN_LIST,
	},

	loginList: {
	key: ONYXKEYS.LOGIN_LIST,
	},

Contact methods - 'expensify.cash-25ffc67..." is created after logging back into the account #45266

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 11, 2024

dominictb commented on Jul 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dominictb commented on Jul 12, 2024

Proposal updated

rayane-d commented on Jul 15, 2024

Julesssss commented on Jul 15, 2024

puneetlath commented on Jul 16, 2024

puneetlath commented on Jul 17, 2024

melvin-bot commented on Jul 24, 2024

puneetlath commented on Jul 24, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions