Repository navigation
[$250] Thread – Unable to leave thread in a task detail. #44964
Description
Activity
Triggered auto assignment to @puneetlath (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsb
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is no option to leave thread in report details page.
What is the root cause of that problem?
The condition of showing the leave button requires the report to not be a thread.
App/src/pages/ReportDetailsPage.tsx
Lines 243 to 244 in e0ccba5
Previously, we had a 3-dot button that shows the leave option for the thread, but now it's removed, but the leave button condition isn't updated yet.
What changes do you think we should make in order to solve the problem?
I propose that we just use
ReportUtils.canLeaveChatfunction to check whether we can leave a report or not. Then, we can move the other current conditions tocanLeaveChat.const shouldShowLeaveButton = ReportUtils.canLeaveChat(report, policy) function canLeaveChat(report: OnyxEntry<Report>, policy: OnyxEntry<Policy>): boolean { if (isGroupChat) return true; if (isPolicyExpenseChat && !report.isOwnPolicyExpenseChat && !isPolicyAdmin) return true; ...Last, we need to update the
leaveChatlogic so that leaving a thread will callleaveRoominstead ofleaveGroupChat.
App/src/pages/ReportDetailsPage.tsx
Lines 224 to 232 in e0ccba5
We can do that by switching the check.
if (isGroupChat) { leaveGroupChat() return; } leaveRoom()16 remaining items
Sounds good. I like consolidating the logic into ReportUtils.canLeaveChat.
PR is ready
cc: @akinwale
⚠️ Looks like this issue was linked to a Deploy Blocker hereIf you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker hereIf you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
deployed to production Jul 23
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
This was a regression from #44252.
- [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@akinwale] Determine if we should create a regression test for this bug.
- [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
- Launch Expensify
- Open a chat report
- Send a message
- Reply in the thread of the message that was sent
- Click or tap on the chat header
- Verify that the Leave option is displayed in the menu
Do we agree 👍 or 👎?
Reacted by April BekkalaPAYMENT SUMMARY FOR JULY 30
- Fix: @bernhardoj [$250] payment via New Dot
- PR Review: @akinwale [$250] Offer
Requested in ND.
$250 approved for @bernhardoj
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.5-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4700550
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Expected Result:
Leave thread option is present in a task detail
Actual Result:
Leave thread option is missing in a task detail
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6535884_1720445500918.Leave_thread.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @akinwale